mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 20:12:31 +01:00
4462578a1c
Bug#25422 (Hang with log tables) Bug 17876 (Truncating mysql.slow_log in a SP after using cursor locks the thread) Bug 23044 (Warnings on flush of a log table) Bug 29129 (Resetting general_log while the GLOBAL READ LOCK is set causes a deadlock) Prior to this fix, the server would hang when performing concurrent ALTER TABLE or TRUNCATE TABLE statements against the LOG TABLES, which are mysql.general_log and mysql.slow_log. The root cause traces to the following code: in sql_base.cc, open_table() if (table->in_use != thd) { /* wait_for_condition will unlock LOCK_open for us */ wait_for_condition(thd, &LOCK_open, &COND_refresh); } The problem with this code is that the current implementation of the LOGGER creates 'fake' THD objects, like - Log_to_csv_event_handler::general_log_thd - Log_to_csv_event_handler::slow_log_thd which are not associated to a real thread running in the server, so that waiting for these non-existing threads to release table locks cause the dead lock. In general, the design of Log_to_csv_event_handler does not fit into the general architecture of the server, so that the concept of general_log_thd and slow_log_thd has to be abandoned: - this implementation does not work with table locking - it will not work with commands like SHOW PROCESSLIST - having the log tables always opened does not integrate well with DDL operations / FLUSH TABLES / SET GLOBAL READ_ONLY With this patch, the fundamental design of the LOGGER has been changed to: - always open and close a log table when writing a log - remove totally the usage of fake THD objects - clarify how locking of log tables is implemented in general. See WL#3984 for details related to the new locking design. Additional changes (misc bugs exposed and fixed): 1) mysqldump which would ignore some tables in dump_all_tables_in_db(), but forget to ignore the same in dump_all_views_in_db(). 2) mysqldump would also issue an empty "LOCK TABLE" command when all the tables to lock are to be ignored (numrows == 0), instead of not issuing the query. 3) Internal errors handlers could intercept errors but not warnings (see sql_error.cc). 4) Implementing a nested call to open tables, for the performance schema tables, exposed an existing bug in remove_table_from_cache(), which would perform: in_use->some_tables_deleted=1; against another thread, without any consideration about thread locking. This call inside remove_table_from_cache() was not required anyway, since calling mysql_lock_abort() takes care of aborting -- cleanly -- threads that might hold a lock on a table. This line (in_use->some_tables_deleted=1) has been removed. sql/handler.cc: Moved logic for system / log tables in the SQL layer. sql/handler.h: Moved logic for system / log tables in the SQL layer. sql/lock.cc: Revised locking of log tables sql/log.cc: Major cleanup: changed how log tables are locked / written to. sql/log.h: Major cleanup: changed how log tables are locked / written to. sql/mysql_priv.h: performance schema helpers sql/slave.cc: open_ltable() lock flags sql/sp.cc: open_ltable() lock flags sql/sql_acl.cc: open_ltable() lock flags sql/sql_class.h: performance schema helpers sql/sql_delete.cc: log tables cleanup in TRUNCATE sql/sql_error.cc: Internal handlers can also intercept warnings sql/sql_insert.cc: open_ltable() lock flags sql/sql_parse.cc: performance schema helpers sql/sql_plugin.cc: open_ltable() lock flags sql/sql_rename.cc: log tables cleanup in RENAME sql/sql_servers.cc: open_ltable() lock flags sql/sql_show.cc: Move INFORMATION_SCHEMA_NAME to table.cc sql/sql_table.cc: log tables cleanup (admin operations, ALTER TABLE) sql/sql_udf.cc: open_ltable() lock flags sql/table.cc: Implemented TABLE_CATEGORY. sql/share/errmsg.txt: Changed the wording and name of ER_CANT_READ_LOCK_LOG_TABLE sql/table.h: Implemented TABLE_CATEGORY. storage/csv/ha_tina.cc: Moved logic for system / log tables in the SQL layer. storage/csv/ha_tina.h: Moved logic for system / log tables in the SQL layer. storage/myisam/ha_myisam.cc: Moved logic for system / log tables in the SQL layer. storage/myisam/ha_myisam.h: Moved logic for system / log tables in the SQL layer. client/mysqldump.c: Don't lock tables in the ignore list. Don't issue empty LOCK TABLES queries. sql/sql_base.cc: log tables cleanup performance schema helpers mysql-test/r/ps.result: Adjust test results mysql-test/r/show_check.result: Adjust test results mysql-test/r/status.result: Adjust test results mysql-test/t/log_state.test: Added tests for Bug#29129 mysql-test/t/ps.test: Make the test output deterministic mysql-test/t/show_check.test: Make the test output deterministic mysql-test/r/log_state.result: Changed the default location of the log output to LOG_FILE, for backward compatibility with MySQL 5.0 --- Adjust test results mysql-test/r/log_tables.result: cleanup for -ps-protocol mysql-test/t/log_tables.test: cleanup for -ps-protocol sql/set_var.cc: Changed the default location of the log output to LOG_FILE, for backward compatibility with MySQL 5.0 --- log tables cleanup
172 lines
5.6 KiB
C++
172 lines
5.6 KiB
C++
/* Copyright (C) 2003 MySQL AB
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation; version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
|
|
You should have received a copy of the GNU General Public License
|
|
along with this program; if not, write to the Free Software
|
|
Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/stat.h>
|
|
#include <my_dir.h>
|
|
#include "transparent_file.h"
|
|
|
|
#define DEFAULT_CHAIN_LENGTH 512
|
|
/*
|
|
Version for file format.
|
|
1 - Initial Version. That is, the version when the metafile was introduced.
|
|
*/
|
|
|
|
#define TINA_VERSION 1
|
|
|
|
typedef struct st_tina_share {
|
|
char *table_name;
|
|
char data_file_name[FN_REFLEN];
|
|
uint table_name_length, use_count;
|
|
/*
|
|
Below flag is needed to make log tables work with concurrent insert.
|
|
For more details see comment to ha_tina::update_status.
|
|
*/
|
|
my_bool is_log_table;
|
|
/*
|
|
Here we save the length of the file for readers. This is updated by
|
|
inserts, updates and deletes. The var is initialized along with the
|
|
share initialization.
|
|
*/
|
|
off_t saved_data_file_length;
|
|
pthread_mutex_t mutex;
|
|
THR_LOCK lock;
|
|
bool update_file_opened;
|
|
bool tina_write_opened;
|
|
File meta_file; /* Meta file we use */
|
|
File tina_write_filedes; /* File handler for readers */
|
|
bool crashed; /* Meta file is crashed */
|
|
ha_rows rows_recorded; /* Number of rows in tables */
|
|
uint data_file_version; /* Version of the data file used */
|
|
} TINA_SHARE;
|
|
|
|
struct tina_set {
|
|
off_t begin;
|
|
off_t end;
|
|
};
|
|
|
|
class ha_tina: public handler
|
|
{
|
|
THR_LOCK_DATA lock; /* MySQL lock */
|
|
TINA_SHARE *share; /* Shared lock info */
|
|
off_t current_position; /* Current position in the file during a file scan */
|
|
off_t next_position; /* Next position in the file scan */
|
|
off_t local_saved_data_file_length; /* save position for reads */
|
|
off_t temp_file_length;
|
|
uchar byte_buffer[IO_SIZE];
|
|
Transparent_file *file_buff;
|
|
File data_file; /* File handler for readers */
|
|
File update_temp_file;
|
|
String buffer;
|
|
/*
|
|
The chain contains "holes" in the file, occured because of
|
|
deletes/updates. It is used in rnd_end() to get rid of them
|
|
in the end of the query.
|
|
*/
|
|
tina_set chain_buffer[DEFAULT_CHAIN_LENGTH];
|
|
tina_set *chain;
|
|
tina_set *chain_ptr;
|
|
uchar chain_alloced;
|
|
uint32 chain_size;
|
|
uint local_data_file_version; /* Saved version of the data file used */
|
|
bool records_is_known;
|
|
|
|
private:
|
|
bool get_write_pos(off_t *end_pos, tina_set *closest_hole);
|
|
int open_update_temp_file_if_needed();
|
|
int init_tina_writer();
|
|
int init_data_file();
|
|
|
|
public:
|
|
ha_tina(handlerton *hton, TABLE_SHARE *table_arg);
|
|
~ha_tina()
|
|
{
|
|
if (chain_alloced)
|
|
my_free(chain, 0);
|
|
if (file_buff)
|
|
delete file_buff;
|
|
}
|
|
const char *table_type() const { return "CSV"; }
|
|
const char *index_type(uint inx) { return "NONE"; }
|
|
const char **bas_ext() const;
|
|
ulonglong table_flags() const
|
|
{
|
|
return (HA_NO_TRANSACTIONS | HA_REC_NOT_IN_SEQ | HA_NO_AUTO_INCREMENT |
|
|
HA_BINLOG_ROW_CAPABLE | HA_BINLOG_STMT_CAPABLE);
|
|
}
|
|
ulong index_flags(uint idx, uint part, bool all_parts) const
|
|
{
|
|
/*
|
|
We will never have indexes so this will never be called(AKA we return
|
|
zero)
|
|
*/
|
|
return 0;
|
|
}
|
|
uint max_record_length() const { return HA_MAX_REC_LENGTH; }
|
|
uint max_keys() const { return 0; }
|
|
uint max_key_parts() const { return 0; }
|
|
uint max_key_length() const { return 0; }
|
|
/*
|
|
Called in test_quick_select to determine if indexes should be used.
|
|
*/
|
|
virtual double scan_time() { return (double) (stats.records+stats.deleted) / 20.0+10; }
|
|
/* The next method will never be called */
|
|
virtual bool fast_key_read() { return 1;}
|
|
/*
|
|
TODO: return actual upper bound of number of records in the table.
|
|
(e.g. save number of records seen on full table scan and/or use file size
|
|
as upper bound)
|
|
*/
|
|
ha_rows estimate_rows_upper_bound() { return HA_POS_ERROR; }
|
|
|
|
int open(const char *name, int mode, uint open_options);
|
|
int close(void);
|
|
int write_row(uchar * buf);
|
|
int update_row(const uchar * old_data, uchar * new_data);
|
|
int delete_row(const uchar * buf);
|
|
int rnd_init(bool scan=1);
|
|
int rnd_next(uchar *buf);
|
|
int rnd_pos(uchar * buf, uchar *pos);
|
|
bool check_and_repair(THD *thd);
|
|
int check(THD* thd, HA_CHECK_OPT* check_opt);
|
|
bool is_crashed() const;
|
|
int rnd_end();
|
|
int repair(THD* thd, HA_CHECK_OPT* check_opt);
|
|
/* This is required for SQL layer to know that we support autorepair */
|
|
bool auto_repair() const { return 1; }
|
|
void position(const uchar *record);
|
|
int info(uint);
|
|
int extra(enum ha_extra_function operation);
|
|
int delete_all_rows(void);
|
|
int create(const char *name, TABLE *form, HA_CREATE_INFO *create_info);
|
|
bool check_if_incompatible_data(HA_CREATE_INFO *info,
|
|
uint table_changes);
|
|
|
|
THR_LOCK_DATA **store_lock(THD *thd, THR_LOCK_DATA **to,
|
|
enum thr_lock_type lock_type);
|
|
|
|
/*
|
|
These functions used to get/update status of the handler.
|
|
Needed to enable concurrent inserts.
|
|
*/
|
|
void get_status();
|
|
void update_status();
|
|
|
|
/* The following methods were added just for TINA */
|
|
int encode_quote(uchar *buf);
|
|
int find_current_row(uchar *buf);
|
|
int chain_append();
|
|
};
|
|
|