mirror of
https://github.com/MariaDB/server.git
synced 2025-01-17 20:42:30 +01:00
4f18083b08
The problem was that TRUNCATE TABLE didn't take a exclusive lock on a table if it resorted to truncating via delete of all rows in the table. Specifically for InnoDB tables, this could break proper isolation as InnoDB ends up aborting some granted locks when truncating a table. The solution is to take a exclusive metadata lock before TRUNCATE TABLE can proceed. This guarantees that no other transaction is using the table. Incompatible change: Truncate via delete no longer fails if sql_safe_updates is activated (this was a undocumented side effect). libmysqld/CMakeLists.txt: Add new files to the build list. libmysqld/Makefile.am: Add new files to the build list. mysql-test/extra/binlog_tests/binlog_truncate.test: Add test case for Bug#42643 mysql-test/include/mix1.inc: Update test case as TRUNCATE TABLE now grabs a exclusive lock. Ensure that TRUNCATE waits for granted locks on the table. mysql-test/suite/binlog/t/binlog_truncate_innodb.test: As with other data modifying statements, TRUNCATE is still not possible in a transaction with isolation level READ COMMITTED or READ UNCOMMITED. It would be possible to implement so, but it is not worth the effort. mysql-test/suite/binlog/t/binlog_truncate_myisam.test: Test under different binlog formats. mysql-test/suite/binlog/t/disabled.def: Re-enable test case. mysql-test/t/innodb_bug38231.test: Truncate no longer works with row-level locks. mysql-test/t/mdl_sync.test: Ensure that a acquired lock is not given up due to a conflict. mysql-test/t/partition_innodb_semi_consistent.test: End transaction as to release metadata locks. mysql-test/t/truncate.test: A metadata lock is now taken before the object is verified. sql/CMakeLists.txt: Add new files to the build list. sql/Makefile.am: Add new files to the build list. sql/datadict.cc: Introduce a new file specific for data dictionary operations. sql/datadict.h: Add header file. sql/sql_base.cc: Rename data dictionary function. sql/sql_bitmap.h: Include dependency. sql/sql_delete.cc: Move away from relying on mysql_delete() to delete all rows of a table. Thus, move any bits related to truncate to sql_truncate.cc sql/sql_delete.h: Remove parameter. sql/sql_parse.cc: Add protection against the global read lock -- a intention exclusive lock can be acquired in the truncate path. sql/sql_show.cc: Add sync point for testing scenarios where a pending flush is ignored. sql/sql_truncate.cc: Acquire a shared metadata lock before accessing table metadata. Upgrade the lock to a exclusive one if the table can be re-created. Rework binlog rules to better reflect the requirements. sql/sql_yacc.yy: Set appropriate lock types for table to be truncated. sql/table.h: Move to data dictionary header.
403 lines
12 KiB
Text
403 lines
12 KiB
Text
SET @old_binlog_format=@@binlog_format;
|
|
SET BINLOG_FORMAT=ROW;
|
|
RESET MASTER;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
# Even though the isolation level might be permissive, truncate
|
|
# table follows a stricter isolation as its locking is based on
|
|
# (exclusive) metadata locks.
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL READ COMMITTED;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL READ COMMITTED;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL READ COMMITTED;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Table_map # # table_id: # (test.t2)
|
|
master-bin.000001 # Write_rows # # table_id: # flags: STMT_END_F
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
SET BINLOG_FORMAT=STATEMENT;
|
|
RESET MASTER;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
# Truncate is not supported for SBR if the isolation level is
|
|
# READ UNCOMMITTED or READ COMMITTED. These specific isolation
|
|
# levels are tested elsewhere.
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL REPEATABLE READ;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t2 VALUES (1),(2),(3);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
**** Truncate of empty table shall be logged
|
|
TRUNCATE TABLE t1;
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
TRUNCATE TABLE t2;
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t2
|
|
DROP TABLE t1,t2;
|
|
#
|
|
# Bug#42643: InnoDB does not support replication of TRUNCATE TABLE
|
|
#
|
|
CREATE TABLE t1 (a INT) ENGINE=InnoDB;
|
|
CREATE TABLE t2 (a INT) ENGINE=InnoDB;
|
|
INSERT INTO t1 VALUES (1),(2);
|
|
SET TRANSACTION ISOLATION LEVEL SERIALIZABLE;
|
|
# Connection: default
|
|
BEGIN;
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
# Connection: truncate
|
|
TRUNCATE TABLE t1;
|
|
# Connection: default
|
|
INSERT INTO t2 SELECT * FROM t1;
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
COMMIT;
|
|
# Connection: truncate
|
|
# Reaping TRUNCATE TABLE
|
|
SELECT COUNT(*) FROM t1;
|
|
COUNT(*)
|
|
0
|
|
SELECT COUNT(*) FROM t2;
|
|
COUNT(*)
|
|
4
|
|
# Connection: default
|
|
show binlog events from <binlog_start>;
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Query # # BEGIN
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Query # # use `test`; INSERT INTO t2 SELECT * FROM t1
|
|
master-bin.000001 # Xid # # COMMIT /* XID */
|
|
master-bin.000001 # Query # # use `test`; TRUNCATE TABLE t1
|
|
DROP TABLE t1,t2;
|
|
SET BINLOG_FORMAT=@old_binlog_format;
|