mariadb/strings
Davi Arnaut 0eb26fdfa8 Bug#53445: Build with -Wall and fix warnings that it generates
Apart strict-aliasing warnings, fix the remaining warnings
generated by GCC 4.4.4 -Wall and -Wextra flags.

One major source of warnings was the in-house function my_bcmp
which (unconventionally) took pointers to unsigned characters
as the byte sequences to be compared. Since my_bcmp and bcmp
are deprecated functions whose only difference with memcmp is
the return value, every use of the function is replaced with
memcmp as the special return value wasn't actually being used
by any caller.

There were also various other warnings, mostly due to type
mismatches, missing return values, missing prototypes, dead
code (unreachable) and ignored return values.

BUILD/SETUP.sh:
  Remove flags that are implied by -Wall and -Wextra.
  Do not warn about unused parameters in C++.
BUILD/check-cpu:
  Print only the compiler version instead of verbose banner.
  Although the option is gcc specific, the check was only
  being used for GCC specific checks anyway.
client/mysql.cc:
  bcmp is no longer defined.
client/mysqltest.cc:
  Pass a string to function expecting a format string.
  Replace use of bcmp with memcmp.
cmd-line-utils/readline/Makefile.am:
  Always define _GNU_SOURCE when compiling GNU readline.
  Required to make certain prototypes visible.
cmd-line-utils/readline/input.c:
  Condition for the code to be meaningful.
configure.in:
  Remove check for bcmp.
extra/comp_err.c:
  Use appropriate type.
extra/replace.c:
  Replace use of bcmp with memcmp.
extra/yassl/src/crypto_wrapper.cpp:
  Do not ignore the return value of fgets. Retrieve the file
  position if fgets succeed -- if it fails, the function will
  bail out and return a error.
extra/yassl/taocrypt/include/blowfish.hpp:
  Use a single array instead of accessing positions of the sbox_
  through a subscript to pbox_.
extra/yassl/taocrypt/include/runtime.hpp:
  One definition of such functions is enough.
extra/yassl/taocrypt/src/aes.cpp:
  Avoid potentially ambiguous conditions.
extra/yassl/taocrypt/src/algebra.cpp:
  Rename arguments to avoid shadowing related warnings.
extra/yassl/taocrypt/src/blowfish.cpp:
  Avoid potentially ambiguous conditions.
extra/yassl/taocrypt/src/integer.cpp:
  Do not define type within a anonymous union.
  Use a variable to return a value instead of
  leaving the result in a register -- compiler
  does not know the logic inside the asm.
extra/yassl/taocrypt/src/misc.cpp:
  Define handler for pure virtual functions.
  Remove unused code.
extra/yassl/taocrypt/src/twofish.cpp:
  Avoid potentially ambiguous conditions.
extra/yassl/testsuite/test.hpp:
  Function must have C language linkage.
include/m_string.h:
  Remove check which relied on bcmp being defined -- they weren't
  being used as bcmp is only visible when _BSD_SOURCE is defined.
include/my_bitmap.h:
  Remove bogus helpers which were used only in a few files and
  were causing warnings about dead code.
include/my_global.h:
  Due to G++ bug, always silence false-positive uninitialized
  variables warnings when compiling C++ code with G++.
  Remove bogus helper.
libmysql/Makefile.shared:
  Remove built-in implementation of bcmp.
mysql-test/lib/My/SafeProcess/safe_process.cc:
  Cast pid to largest possible type for a process identifier.
mysys/mf_loadpath.c:
  Leave space of the ending nul.
mysys/mf_pack.c:
  Replace bcmp with memcmp.
mysys/my_bitmap.c:
  Dead code removal.
mysys/my_gethwaddr.c:
  Remove unused variable.
mysys/my_getopt.c:
  Silence bogus uninitialized variable warning.
  Do not cast away the constant qualifier.
mysys/safemalloc.c:
  Cast to expected type.
mysys/thr_lock.c:
  Silence bogus uninitialized variable warning.
sql/field.cc:
  Replace bogus helper with a more appropriate logic which is
  used throughout the code.
sql/item.cc:
  Remove bogus logical condition which always evaluates to TRUE.
sql/item_create.cc:
  Simplify code to avoid signedness related warnings.
sql/log_event.cc:
  Replace use of bcmp with memcmp.
  No need to use helpers for simple bit operations.
sql/log_event_old.cc:
  Replace bmove_align with memcpy.
sql/mysqld.cc:
  Move use declaration of variable to the ifdef block where it
  is used. Remove now-unnecessary casts and arguments.
sql/set_var.cc:
  Replace bogus helpers with simple and classic bit operations.
sql/slave.cc:
  Cast to expected type and silence bogus warning.
sql/sql_class.h:
  Don't use enum values as bit flags, the supposed type safety is
  bogus as the combined bit flags are not a value in the enumeration.
sql/udf_example.c:
  Only declare variable when necessary.
sql/unireg.h:
  Replace use of bmove_align with memcpy.
storage/innobase/os/os0file.c:
  Silence bogus warning.
storage/myisam/mi_open.c:
  Remove bogus cast, DBUG_DUMP expects a pointer to unsigned
  char.
storage/myisam/mi_page.c:
  Remove bogus cast, DBUG_DUMP expects a pointer to unsigned
  char.
strings/bcmp.c:
  Remove built-in bcmp.
strings/ctype-ucs2.c:
  Silence bogus warning.
tests/mysql_client_test.c:
  Use a appropriate type as expected by simple_command().
2010-07-02 15:30:47 -03:00
..
.cvsignore
bchange.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
bcopy-duff.c Many files: 2006-12-23 20:17:15 +01:00
bfill.c Many files: 2006-12-23 20:17:15 +01:00
bmove.c Many files: 2006-12-23 20:17:15 +01:00
bmove512.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
bmove_upp-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
bmove_upp.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
bzero.c Many files: 2006-12-23 20:17:15 +01:00
ChangeLog
CHARSET_INFO.txt Updating charset doc files. 2008-05-28 15:03:47 +05:00
CMakeLists.txt Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
conf_to_src.c Changes of copyright output from "--version" and similar. 2008-11-14 17:29:38 +01:00
ctype-big5.c Merge host.loc:/home/uchum/work/5.0-bugteam 2008-04-23 11:06:26 +05:00
ctype-bin.c ctype-bin.c: 2007-06-06 00:22:35 +02:00
ctype-cp932.c Bug#44352 UPPER/LOWER function doesn't work correctly 2009-05-05 11:55:22 +05:00
ctype-czech.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
ctype-euc_kr.c Backporting "WL#3332 Korean Enhancements" and 2009-07-24 11:27:23 +05:00
ctype-eucjpms.c Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl 2008-02-20 19:49:26 +01:00
ctype-extra.c Merge bk-internal.mysql.com:/home/bk/mysql-5.0-maint 2007-08-07 06:53:40 -04:00
ctype-gb2312.c Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl 2008-02-20 19:49:26 +01:00
ctype-gbk.c Merge host.loc:/home/uchum/work/5.0-bugteam 2008-04-23 11:06:26 +05:00
ctype-latin1.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
ctype-mb.c Bug#29125 Windows Server X64: so many compiler warnings 2009-02-10 17:47:54 -05:00
ctype-simple.c Bug#46448 trailing spaces are not ignored when user collation maps space != 0x20 2009-10-12 13:13:15 +05:30
ctype-sjis.c Bug#44352 UPPER/LOWER function doesn't work correctly 2009-05-05 11:55:22 +05:00
ctype-tis620.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
ctype-uca.c A post fix for BUG#45645 Mysql server close all connection and restart using lower function 2009-10-20 12:47:00 +05:00
ctype-ucs2.c Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
ctype-ujis.c Merge dl145h.mysql.com:/data0/mkindahl/mysql-5.0-rpl 2008-02-20 19:49:26 +01:00
ctype-utf8.c Merge from 5.0 for 43414 2009-08-28 18:21:54 +02:00
ctype-win1250ch.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
ctype.c Addendum to Bug #45286: backport macro name form other tree 2009-06-06 15:05:44 +02:00
decimal.c Bug#42733: Type-punning warnings when compiling MySQL -- 2010-06-10 17:16:43 -03:00
do_ctype.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
dump_map.c my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
int2str.c BUG#31799: Scrambled number output due to integer overflow 2007-10-31 10:34:26 +01:00
is_prefix.c Many files: 2006-12-23 20:17:15 +01:00
latin2.def
llstr.c Bug#31177: Server variables can't be set to their current values 2007-11-30 06:32:04 +01:00
longlong2str-x86.s Many files: 2006-12-23 20:17:15 +01:00
longlong2str.c BUG#31799: Scrambled number output due to integer overflow 2007-10-31 10:34:26 +01:00
longlong2str_asm.c Many files: 2006-12-23 20:17:15 +01:00
macros.asm my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
make-ccc Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
Makefile.am Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
memcmp.c Many files: 2006-12-23 20:17:15 +01:00
memcpy.c Many files: 2006-12-23 20:17:15 +01:00
memset.c Many files: 2006-12-23 20:17:15 +01:00
my_strchr.c Fixed compiler warnings 2007-02-23 13:13:55 +02:00
my_strtoll10-x86.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
my_strtoll10.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
my_vsnprintf.c Bug#29125 Windows Server X64: so many compiler warnings 2009-02-13 11:41:47 -05:00
ptr_cmp.asm my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
r_strinstr.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
README
str2int.c Many files: 2006-12-23 20:17:15 +01:00
str_alloc.c Many files: 2006-12-23 20:17:15 +01:00
str_test.c Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00
strappend-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strappend.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strcat.c Many files: 2006-12-23 20:17:15 +01:00
strcend.c Many files: 2006-12-23 20:17:15 +01:00
strchr.c Many files: 2006-12-23 20:17:15 +01:00
strcmp.c Many files: 2006-12-23 20:17:15 +01:00
strcont.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strend-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strend.c Many files: 2006-12-23 20:17:15 +01:00
strfill.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
string.doc
strings-not-used.h Many files: 2006-12-23 20:17:15 +01:00
strings-x86.s Many files: 2006-12-23 20:17:15 +01:00
strings.asm my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strinstr-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strinstr.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strlen.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strmake-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strmake.c Bug #46042: backported the fix for the valgrind warning from 5.1 2009-07-16 16:13:26 +03:00
strmov-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strmov.c Bug #48866: mysql.test fails under Fedora 12 2009-12-16 19:31:19 +02:00
strnlen.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strnmov-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strnmov.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strrchr.c Many files: 2006-12-23 20:17:15 +01:00
strstr-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strstr.c Many files: 2006-12-23 20:17:15 +01:00
strto.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
strtod.c Fixed a lot of compiler warnings and errors detected by Forte C++ on Solaris 2007-08-13 16:11:25 +03:00
strtol.c Many files: 2006-12-23 20:17:15 +01:00
strtoll.c Many files: 2006-12-23 20:17:15 +01:00
strtoul.c Many files: 2006-12-23 20:17:15 +01:00
strtoull.c Many files: 2006-12-23 20:17:15 +01:00
strxmov-sparc.s my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strxmov.asm my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
strxmov.c Many files: 2006-12-23 20:17:15 +01:00
strxnmov.c WL#3817: Simplify string / memory area types and make things more consistent (first part) 2007-05-10 12:59:39 +03:00
t_ctype.h Many files: 2006-12-23 20:17:15 +01:00
uca-dump.c my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
uctypedump.c Many files: 2006-12-31 02:29:11 +01:00
udiv.c Many files: 2006-12-23 20:17:15 +01:00
utr11-dump.c my_strtoll10-x86.s: 2006-12-31 01:02:27 +01:00
xml.c Bug#53445: Build with -Wall and fix warnings that it generates 2010-07-02 15:30:47 -03:00

File   : README
Author : Richard A. O'Keefe.
Updated: 30 April 1984
Purpose: Explain the new strings package.

    The UNIX string libraries (described in the string(3) manual page)
differ from UNIX to UNIX (e.g. strtok is not in V7 or 4.1bsd).  Worse,
the sources are not in the public domain, so that if there is a string
routine which is nearly what you want but not quite you can't  take  a
copy  and  modify it.  And of course C programmers on non-UNIX systems
are at the mercy of their supplier.

    This package was designed to let me do reasonable things with  C's
strings  whatever UNIX (V7, PaNiX, UX63, 4.1bsd) I happen to be using.
Everything in the System III manual is here and does just what the  S3
manual  says  it does.  There are also lots of new goodies.  I'm sorry
about the names, but the routines do have to work  on  asphyxiated-at-
birth  systems  which  truncate identifiers.  The convention is that a
routine is called
 str [n] [c] <operation>
If there is an "n", it means that the function takes an (int) "length"
argument, which bounds the number of characters to be moved or  looked
at.  If the function has a "set" argument, a "c" in the name indicates
that  the complement of the set is used.  Functions or variables whose
names start with _ are support routines which aren't really meant  for
general  use.  I don't know what the "p" is doing in "strpbrk", but it
is there in the S3 manual so it's here too.  "istrtok" does not follow
this rule, but with 7 letters what can you do?

    I have included new versions of atoi(3) and atol(3) as well.  They
use a new primitive str2int, which takes a pair of bounds and a radix,
and does much more thorough checking than the normal atoi and atol do.
The result returned by atoi & atol is valid if and only if errno == 0.
There is also an output conversion routine int2str, with itoa and ltoa
as interface macros.  Only after writing int2str did I notice that the
str2int routine has no provision for unsigned numbers.  On reflection,
I don't greatly care.   I'm afraid that int2str may depend on your "C"
compiler in unexpected ways.  Do check the code with -S.

    Several of these routines have "asm" inclusions conditional on the
VaxAsm option.  These insertions can make the routines which have them
quite a bit faster, but there is a snag.  The VAX architects, for some
reason best known to themselves and their therapists, decided that all
"strings" were shorter than 2^16 bytes.  Even when the length operands
are in 32-bit registers, only 16 bits count.  So the "asm" versions do
not work for long strings.  If you can guarantee that all your strings
will be short, define VaxAsm in the makefile, but in general, and when
using other machines, do not define it.

    To use this library, you need the "strings.a" library file and the
"strings.h" and "ctypes.h" header files.  The other header  files  are
for compiling the library itself, though if you are hacking extensions
you  may  find  them useful.  General users really shouldn't see them.
I've defined a few macros I find useful in "strings.h"; if you have no
need for "index", "rindex", "streql", and "beql", just edit them  out.
On the 4.1bsd system I am using declaring all these functions 'extern'
does not mean that they will all be loaded; but only the ones you use.
When using lesser systems you may find it necessary to break strings.h
up, or you could get by with just adding "extern" declarations for the
functions you want as you need them.  Many of these functions have the
same names as functions in the "standard C library", by design as this
is a replacement/reimplementation of part of that library.  So you may
have to talk the loader into loading this library first.   Again, I've
found no problems on 4.1bsd.

    You may wonder at my failure to provide manual pages for this code.
For the things in V7, 4.?, or SIII, you should be able to use whichever
manual page came with that system,  and anything I might write would be
so like it as to raise suspicions of violating AT&T copyrights.  In the
sources you will find comments which provide far more documentation for
these routines than AT&T ever provided for their strings stuff,  I just
don't happen to have put it in nroff -man form.   Had I done so, the .3
files would have outbulked the .c files!

    These files are in the public domain.  This includes getopt.c, which
is the work of Henry Spencer, University of Toronto Zoology, who says of
it "None of this software is derived from Bell software. I had no access
to the source for Bell's versions at the time I wrote it.  This software
is hereby explicitly placed in the public domain.  It may  be  used  for
any purpose on any machine by anyone." I would greatly prefer it if *my*
material received no military use.