mariadb/storage/rocksdb
Nikita Malyavin 0c595bdeaa MDEV-22434 UPDATE on RocksDB table with WITHOUT OVERLAPS fails
Insert worked incorrect as well. RocksDB used table->record[0] internally to store some
intermediate results for key conversion, during index searching among other operations.
So table->record[0] is spoiled during ha_rnd_index_map in ha_check_overlaps, so in turn
the broken record data was inserted.

The fix is to store RocksDB intermediate result in its own buffer instead of table->record[0].

`rocksdb` MTR suite is is checked and runs fine.
No need for additional tests. The existing overlaps.test covers the case completely.
However, I am not going to add anything related to rocksdb to suite, to keep it away
from additional dependencies.

To run tests with RocksDB engine, one can add following to engines.combinations:
[rocksdb]
plugin-load=$HA_ROCKSDB_SO
default-storage-engine=rocksdb
rocksdb
2020-06-05 20:04:37 +10:00
..
mysql-test Merge 10.4 into 10.5 2020-04-25 21:57:52 +03:00
rocksdb@bba5e7bc21 MDEV-21930 RocksDB does not compile anymore, with Visual Studio 2020-03-23 11:25:01 +01:00
tools
unittest
.clang-format Copy of 2019-06-15 21:29:46 +03:00
.gitignore
atomic_stat.h
build_rocksdb.cmake Merge 10.3 into 10.4 2020-05-30 11:04:27 +03:00
CMakeLists.txt MDEV-21303 Make executables MariaDB named 2020-03-21 20:20:29 +01:00
event_listener.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
event_listener.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
get_rocksdb_files.sh
ha_rocksdb.cc MDEV-22434 UPDATE on RocksDB table with WITHOUT OVERLAPS fails 2020-06-05 20:04:37 +10:00
ha_rocksdb.h MDEV-22434 UPDATE on RocksDB table with WITHOUT OVERLAPS fails 2020-06-05 20:04:37 +10:00
ha_rocksdb_proto.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
logger.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
myrocks_hotbackup.py Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
nosql_access.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
nosql_access.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
properties_collector.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
properties_collector.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_buff.h Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_cf_manager.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_cf_manager.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_cf_options.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_cf_options.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_compact_filter.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_comparator.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_converter.cc MDEV-22641: Provide SIMD optimized wrapper for zlib crc32() (#1558) 2020-06-01 11:34:06 +03:00
rdb_converter.h Copy of 2019-06-15 21:29:46 +03:00
rdb_datadic.cc MDEV-22434 UPDATE on RocksDB table with WITHOUT OVERLAPS fails 2020-06-05 20:04:37 +10:00
rdb_datadic.h MDEV-22434 UPDATE on RocksDB table with WITHOUT OVERLAPS fails 2020-06-05 20:04:37 +10:00
rdb_global.h MDEV-17171: RocksDB Tables do not have "Creation Date" 2019-10-31 19:45:25 +03:00
rdb_i_s.cc Merge 10.4 into 10.5 2019-08-13 18:57:00 +03:00
rdb_i_s.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_index_merge.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_index_merge.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_io_watchdog.cc Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_io_watchdog.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_mariadb_port.h
rdb_mariadb_server_port.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_mariadb_server_port.h
rdb_mutex_wrapper.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_mutex_wrapper.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_perf_context.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_perf_context.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_psi.cc Copy of 2019-06-15 21:29:46 +03:00
rdb_psi.h Copy of 2019-06-15 21:29:46 +03:00
rdb_source_revision.h.in
rdb_sst_info.cc Merge 10.2 into 10.3 2020-03-30 11:12:56 +03:00
rdb_sst_info.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_threads.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_threads.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
rdb_utils.cc Merge 10.2 into 10.3 2019-07-02 17:46:22 +03:00
rdb_utils.h Merge from MyRocks upstream: 2019-06-16 00:28:33 +03:00
README
rocksdb-range-access.txt
ut0counter.h MDEV-21930 RocksDB does not compile anymore, with Visual Studio 2020-03-23 11:25:01 +01:00

== Summary ==
This directory contains RocksDB-based Storage Engine (RDBSE) for MySQL,
also known as "MyRocks".

== Resources ==
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks
https://www.facebook.com/groups/MyRocks/

== Coding Conventions ==
The baseline for MyRocks coding conventions for the code in storage/rocksdb/
is based on the default clang format with a few minor changes.  The file
storage/rocksdb/.clang-format describes conventions and can be integrated
with Vim or Emacs as described here:
http://releases.llvm.org/3.6.0/tools/clang/docs/ClangFormat.html#vim-integration

All code outside of storage/rocksdb/ should conform to the MySQL coding
conventions:
http://dev.mysql.com/doc/internals/en/coding-guidelines.html.

Several refinements:
  0. There is an umbrella C++ namespace named "myrocks" for all MyRocks code.
  1. We introduced "RDB" as the super-short abbreviation for "RocksDB". We will
     use it as a name prefix, with different capitalization (see below), to ease
     up code navigation with ctags and grep.
     N.B. For ease of matching, we'll keep the variables and functions dealing
          with sysvars as close as possible to the outside visible names of
          sysvars, which start with "rocksdb_" prefix, the outward storage
          engine name.
  2. The names for classes, interfaces, and C++ structures (which act as
     classes), start with prefix "Rdb_".
     NB: For historical reasons, we'll keep the "ha_<storage_engine_name>" class
         name for ha_rocksdb class, which is an exception to the rule.
  3. The names for global objects and functions start with prefix "rdb_".
  4. The names for macros and constants start with prefix "RDB_".
  5. Regular class member names start with "m_".
  6. Static class member names start with "s_".
  7. Given the 80 character per line limit, we'll not always use full English
     words in names, when a well known or easily recognizable abbreviation
     exists (like "tx" for "transaction" or "param" for "parameter" etc).
  8. When needing to disambiguate, we use different suffixes for that, like
     "_arg" for a function argument/parameter, "_arr" for a C style array, and
     "_vect" for a std::vector etc.

== Running Tests ==
To run tests from rocksdb, rocksdb_rpl or other rocksdb_* packages, use the
following parameters:
  --default-storage-engine=rocksdb
  --skip-innodb
  --default-tmp-storage-engine=MyISAM
  --rocksdb