mirror of
https://github.com/MariaDB/server.git
synced 2025-01-19 13:32:33 +01:00
09c80e12c5
Major replication test framework cleanup. This does the following:
- Ensure that all tests clean up the replication state when they
finish, by making check-testcase check the output of SHOW SLAVE STATUS.
This implies:
- Slave must not be running after test finished. This is good
because it removes the risk for sporadic errors in subsequent
tests when a test forgets to sync correctly.
- Slave SQL and IO errors must be cleared when test ends. This is
good because we will notice if a test gets an unexpected error in
the slave threads near the end.
- We no longer have to clean up before a test starts.
- Ensure that all tests that wait for an error in one of the slave
threads waits for a specific error. It is no longer possible to
source wait_for_slave_[sql|io]_to_stop.inc when there is an error
in one of the slave threads. This is good because:
- If a test expects an error but there is a bug that causes
another error to happen, or if it stops the slave thread without
an error, then we will notice.
- When developing tests, wait_for_*_to_[start|stop].inc will fail
immediately if there is an error in the relevant slave thread.
Before this patch, we had to wait for the timeout.
- Remove duplicated and repeated code for setting up unusual replication
topologies. Now, there is a single file that is capable of setting
up arbitrary topologies (include/rpl_init.inc, but
include/master-slave.inc is still available for the most common
topology). Tests can now end with include/rpl_end.inc, which will clean
up correctly no matter what topology is used. The topology can be
changed with include/rpl_change_topology.inc.
- Improved debug information when tests fail. This includes:
- debug info is printed on all servers configured by include/rpl_init.inc
- User can set $rpl_debug=1, which makes auxiliary replication files
print relevant debug info.
- Improved documentation for all auxiliary replication files. Now they
describe purpose, usage, parameters, and side effects.
- Many small code cleanups:
- Made have_innodb.inc output a sensible error message.
- Moved contents of rpl000017-slave.sh into rpl000017.test
- Added mysqltest variables that expose the current state of
disable_warnings/enable_warnings and friends.
- Too many to list here: see per-file comments for details.
58 lines
1.5 KiB
PHP
58 lines
1.5 KiB
PHP
# ==== Purpose ====
|
|
#
|
|
# Create a connection to a given numbered server.
|
|
#
|
|
# This script is normally used internally by rpl_init.inc and
|
|
# master-slave.inc, but it can also be used in test cases that need to
|
|
# create more connections or re-create connections after disconnect.
|
|
#
|
|
#
|
|
# ==== Usage ====
|
|
#
|
|
# --let $rpl_connection_name= <connection_name>
|
|
# --let $rpl_server_number= <server_number>
|
|
# [--let $rpl_debug= 1]
|
|
# --source include/rpl_connect.inc
|
|
#
|
|
# Parameters:
|
|
# $rpl_connection_name
|
|
# The name of the connection to create.
|
|
#
|
|
# $rpl_server_number
|
|
# The number of the server to connect to.
|
|
#
|
|
# $rpl_debug
|
|
# See include/rpl_init.inc
|
|
|
|
|
|
--let $include_filename= rpl_connect.inc [creating $rpl_connection_name]
|
|
--source include/begin_include_file.inc
|
|
|
|
|
|
if (!$rpl_server_number)
|
|
{
|
|
--die ERROR IN TEST: You must set $rpl_server_number before sourcing include/rpl_connect.inc
|
|
}
|
|
if (`SELECT '$rpl_connection_name' = ''`)
|
|
{
|
|
--die ERROR IN TEST: You must set $rpl_connection_name before sourcing include/rpl_connect.inc
|
|
}
|
|
|
|
# Get port number
|
|
--let $_rpl_port= \$SERVER_MYPORT_$rpl_server_number
|
|
if (!$_rpl_port)
|
|
{
|
|
--echo Bug in test case: '\$SERVER_MYPORT_$rpl_server_number' not initialized. Check the test's .cfg file.
|
|
--die Not all SERVER_MYPORT_* environment variables are setup correctly.
|
|
}
|
|
|
|
# Create connection.
|
|
if ($rpl_debug)
|
|
{
|
|
--echo connect ($rpl_connection_name,127.0.0.1,root,,test,$_rpl_port,)
|
|
}
|
|
--connect ($rpl_connection_name,127.0.0.1,root,,test,$_rpl_port,)
|
|
|
|
|
|
--let $include_filename= rpl_connect.inc
|
|
--source include/end_include_file.inc
|