Georgi Kodinov 6d54b0443a Bug #32124: crash if prepared statements refer to variables in the where clause ... The code to get read the value of a system variable was extracting its value on PREPARE stage and was substituting the value (as a constant) into the parse tree. Note that this must be a reversible transformation, i.e. it must be reversed before each re-execution. Unfortunately this cannot be reliably done using the current code, because there are other non-reversible source tree transformations that can interfere with this reversible transformation. Fixed by not resolving the value at PREPARE, but at EXECUTE (as the rest of the functions operate). Added a cache of the value (so that it's constant throughout the execution of the query). Note that the cache also caches NULL values. Updated an obsolete related test suite (variables-big) and the code to test the result type of system variables (as per bug 74). mysql-test/extra/rpl_tests/rpl_insert_id.test: Bug #32124: removed ambiguous testcase mysql-test/r/innodb_data_home_dir_basic.result: Bug #32124: fixed wrong test case mysql-test/r/innodb_flush_method_basic.result: Bug #32124: fixed wrong test case mysql-test/r/ps_11bugs.result: Bug #32124: test case mysql-test/r/ssl_capath_basic.result: Bug #32124: fixed wrong test case mysql-test/r/ssl_cipher_basic.result: Bug #32124: fixed wrong test case mysql-test/r/variables.result: Bug #32124: system vars are shown as such in EXPLAIN EXTENDED, not as constants. mysql-test/suite/rpl/r/rpl_insert_id.result: Bug #32124: removed ambiguous testcase mysql-test/t/ps_11bugs.test: Bug #32124: test case sql/item.cc: Bug #32124: placed the code to convert string to longlong or double to a function (so that it can be reused) sql/item.h: Bug #32124: placed the code to convert string to longlong or double to a function (so that it can be reused) sql/item_func.cc: Bug #32124: moved the evaluation of system variables at runtime (val_xxx). sql/item_func.h: Bug #32124: moved the evaluation of system variables at runtime (val_xxx). sql/set_var.cc: Bug #32124: removed the code that calculated the system variable's value at PREPARE sql/set_var.h: Bug #32124: removed the code that calculated the system variable's value at PREPARE tests/mysql_client_test.c: Bug #32124 : removed the reading of the system variable, because its max length is depended on the system charset and client charset and can't be easily calculated.		2008-10-08 14:23:53 +03:00
..
.cvsignore
auto_increment.res
auto_increment.tst
big_record.pl
bug25714.c	Merge polly.(none):/home/kaa/src/opt/bug32221/my50-bug31445	2007-11-22 14:39:07 +03:00
CMakeLists.txt	Merge jbruehe@bk-internal.mysql.com:/home/bk/mysql-5.1-build	2007-08-02 21:18:24 +02:00
connect_test.c	Many files:	2006-12-23 20:17:15 +01:00
deadlock_test.c	my_strtoll10-x86.s:	2006-12-31 01:02:27 +01:00
drop_test.pl
export.pl
fork2_test.pl
fork_big.pl	This patch removes the remaining TYPE= code from MySQL. It cleans up a number of tests where it was being called still (and failing). Also I cleaned up all of the extra scripts so that they now work.	2006-02-12 13:26:30 -08:00
fork_big2.pl	This patch removes the remaining TYPE= code from MySQL. It cleans up a number of tests where it was being called still (and failing). Also I cleaned up all of the extra scripts so that they now work.	2006-02-12 13:26:30 -08:00
function.res
function.tst
grant.pl	Fixed two bugs in MySQL ACL.	2005-03-17 08:16:56 +02:00
grant.res
index_corrupt.pl	Fixed core dump bug when hot link list in key cache was empty. Bug #10167	2005-04-27 14:31:04 +03:00
insert_and_repair.pl
insert_test.c	Many files:	2006-12-23 20:17:15 +01:00
list_test.c	Many files:	2006-12-23 20:17:15 +01:00
lock_test.pl
lock_test.res
mail_to_db.pl	This patch removes the remaining TYPE= code from MySQL. It cleans up a number of tests where it was being called still (and failing). Also I cleaned up all of the extra scripts so that they now work.	2006-02-12 13:26:30 -08:00
Makefile.am	Merge xiphis.org:/anubis/antony/work/p2-bug25714.1	2007-07-24 00:03:01 -07:00
myisam-big-rows.tst
mysql_client_test.c	Bug #32124: crash if prepared statements refer to variables in the where clause	2008-10-08 14:23:53 +03:00
pmail.pl	New versions of mail_to_db.pl and pmail.pl.	2005-04-09 18:37:32 +03:00
rename_test.pl
restore-lock.smack
select_test.c	Many files:	2006-12-23 20:17:15 +01:00
showdb_test.c	Many files:	2006-12-23 20:17:15 +01:00
ssl_test.c	Bug #15327: configure: --with-tcp-port option being partially ignored	2007-09-13 16:19:46 +02:00
table_types.pl
test_delayed_insert.pl
thread_test.c	Merge mysql.com:/home/tnurnberg/15327/50-15327	2007-09-15 04:09:38 +02:00
truncate.pl