mirror of
https://github.com/MariaDB/server.git
synced 2026-05-08 16:14:30 +02:00
The easiest way to compile and test the server with UBSAN is to run: ./BUILD/compile-pentium64-ubsan and then run mysql-test-run. After this commit, one should be able to run this without any UBSAN warnings. There is still a few compiler warnings that should be fixed at some point, but these do not expose any real bugs. The 'special' cases where we disable, suppress or circumvent UBSAN are: - ref10 source (as here we intentionally do some shifts that UBSAN complains about. - x86 version of optimized int#korr() methods. UBSAN do not like unaligned memory access of integers. Fixed by using byte_order_generic.h when compiling with UBSAN - We use smaller thread stack with ASAN and UBSAN, which forced me to disable a few tests that prints the thread stack size. - Verifying class types does not work for shared libraries. I added suppression in mysql-test-run.pl for this case. - Added '#ifdef WITH_UBSAN' when using integer arithmetic where it is safe to have overflows (two cases, in item_func.cc). Things fixed: - Don't left shift signed values (byte_order_generic.h, mysqltest.c, item_sum.cc and many more) - Don't assign not non existing values to enum variables. - Ensure that bool and enum values are properly initialized in constructors. This was needed as UBSAN checks that these types has correct values when one copies an object. (gcalc_tools.h, ha_partition.cc, item_sum.cc, partition_element.h ...) - Ensure we do not called handler functions on unallocated objects or deleted objects. (events.cc, sql_acl.cc). - Fixed bugs in Item_sp::Item_sp() where we did not call constructor on Query_arena object. - Fixed several cast of objects to an incompatible class! (Item.cc, Item_buff.cc, item_timefunc.cc, opt_subselect.cc, sql_acl.cc, sql_select.cc ...) - Ensure we do not do integer arithmetic that causes over or underflows. This includes also ++ and -- of integers. (Item_func.cc, Item_strfunc.cc, item_timefunc.cc, sql_base.cc ...) - Added JSON_VALUE_UNITIALIZED to json_value_types and ensure that value_type is initialized to this instead of to -1, which is not a valid enum value for json_value_types. - Ensure we do not call memcpy() when second argument could be null. - Fixed that Item_func_str::make_empty_result() creates an empty string instead of a null string (safer as it ensures we do not do arithmetic on null strings). Other things: - Changed struct st_position to an OBJECT and added an initialization function to it to ensure that we do not copy or use uninitialized members. The change to a class was also motived that we used "struct st_position" and POSITION randomly trough the code which was confusing. - Notably big rewrite in sql_acl.cc to avoid using deleted objects. - Changed in sql_partition to use '^' instead of '-'. This is safe as the operator is either 0 or 0x8000000000000000ULL. - Added check for select_nr < INT_MAX in JOIN::build_explain() to avoid bug when get_select() could return NULL. - Reordered elements in POSITION for better alignment. - Changed sql_test.cc::print_plan() to use pointers instead of objects. - Fixed bug in find_set() where could could execute '1 << -1'. - Added variable have_sanitizer, used by mtr. (This variable was before only in 10.5 and up). It can now have one of two values: ASAN or UBSAN. - Moved ~Archive_share() from ha_archive.cc to ha_archive.h and marked it virtual. This was an effort to get UBSAN to work with loaded storage engines. I kept the change as the new place is better. - Added in CONNECT engine COLBLK::SetName(), to get around a wrong cast in tabutil.cpp. - Added HAVE_REPLICATION around usage of rgi_slave, to get embedded server to compile with UBSAN. (Patch from Marko). - Added #ifdef for powerpc64 to avoid a bug in old gcc versions related to integer arithmetic. Changes that should not be needed but had to be done to suppress warnings from UBSAN: - Added static_cast<<uint16_t>> around shift to get rid of a LOT of compiler warnings when using UBSAN. - Had to change some '/' of 2 base integers to shift to get rid of some compile time warnings. Reviewed by: - Json changes: Alexey Botchkov - Charset changes in ctype-uca.c: Alexander Barkov - InnoDB changes & Embedded server: Marko Mäkelä - sql_acl.cc changes: Vicențiu Ciorbaru - build_explain() changes: Sergey Petrunia
231 lines
8.7 KiB
C++
231 lines
8.7 KiB
C++
/*************** Colblk H Declares Source Code File (.H) ***************/
|
|
/* Name: COLBLK.H Version 1.7 */
|
|
/* */
|
|
/* (C) Copyright to the author Olivier BERTRAND 2005-2015 */
|
|
/* */
|
|
/* This file contains the COLBLK and derived classes declares. */
|
|
/***********************************************************************/
|
|
#ifndef __COLBLK__H
|
|
#define __COLBLK__H
|
|
|
|
/***********************************************************************/
|
|
/* Include required application header files */
|
|
/***********************************************************************/
|
|
#include "xobject.h"
|
|
#include "reldef.h"
|
|
|
|
/***********************************************************************/
|
|
/* Class COLBLK: Base class for table column descriptors. */
|
|
/***********************************************************************/
|
|
class DllExport COLBLK : public XOBJECT {
|
|
friend class TDBPIVOT;
|
|
protected:
|
|
// Default constructors used by derived classes
|
|
COLBLK(PCOLDEF cdp = NULL, PTDB tdbp = NULL, int i = 0);
|
|
COLBLK(PCOL colp, PTDB tdbp = NULL); // Used in copy process
|
|
COLBLK(int) {} // Used when changing a column class in TDBXML
|
|
|
|
public:
|
|
// Implementation
|
|
virtual int GetType(void) {return TYPE_COLBLK;}
|
|
virtual int GetResultType(void) {return Buf_Type;}
|
|
virtual int GetScale(void) {return Format.Prec;}
|
|
virtual int GetPrecision(void) {return Precision;}
|
|
virtual int GetLength(void) {return Long;}
|
|
virtual int GetLengthEx(void);
|
|
virtual int GetAmType() {return TYPE_AM_ERROR;}
|
|
virtual void SetOk(void) {Status |= BUF_EMPTY;}
|
|
virtual PTDB GetTo_Tdb(void) {return To_Tdb;}
|
|
virtual int GetClustered(void) {return 0;}
|
|
virtual int IsClustered(void) {return FALSE;}
|
|
virtual PSZ GetJpath(PGLOBAL g, bool proj) {return NULL;}
|
|
PCOL GetNext(void) {return Next;}
|
|
PSZ GetName(void) {return Name;}
|
|
int GetIndex(void) {return Index;}
|
|
ushort GetColUse(void) {return ColUse;}
|
|
int GetOpt(void) {return Opt;}
|
|
ushort GetColUse(ushort u) {return (ColUse & u);}
|
|
ushort GetStatus(void) {return Status;}
|
|
ushort GetStatus(ushort u) {return (Status & u);}
|
|
void SetColUse(ushort u) {ColUse = u;}
|
|
void SetStatus(ushort u) {Status = u;}
|
|
void AddColUse(ushort u) {ColUse |= u;}
|
|
void AddStatus(ushort u) {Status |= u;}
|
|
void SetNext(PCOL cp) {Next = cp;}
|
|
PXCOL GetKcol(void) {return To_Kcol;}
|
|
void SetKcol(PXCOL kcp) {To_Kcol = kcp;}
|
|
PCOLDEF GetCdp(void) {return Cdp;}
|
|
PSZ GetDomain(void) {return (Cdp) ? Cdp->Decode : NULL;}
|
|
PSZ GetDesc(void) {return (Cdp) ? Cdp->Desc : NULL;}
|
|
PSZ GetFmt(void) {return (Cdp) ? Cdp->Fmt : NULL;}
|
|
bool IsUnsigned(void) {return Unsigned;}
|
|
bool IsVirtual(void) {return Cdp->IsVirtual();}
|
|
bool IsNullable(void) {return Nullable;}
|
|
void SetNullable(bool b) {Nullable = b;}
|
|
void SetName(PSZ name_var) { Name= name_var; }
|
|
// Methods
|
|
virtual void Reset(void);
|
|
virtual bool Compare(PXOB xp);
|
|
virtual bool SetFormat(PGLOBAL, FORMAT&);
|
|
virtual bool IsSpecial(void) {return false;}
|
|
virtual bool Eval(PGLOBAL g);
|
|
virtual bool SetBuffer(PGLOBAL g, PVAL value, bool ok, bool check);
|
|
virtual void SetTo_Val(PVAL) {}
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
virtual void WriteColumn(PGLOBAL g);
|
|
virtual void Printf(PGLOBAL g, FILE *, uint);
|
|
virtual void Prints(PGLOBAL g, char *, uint);
|
|
virtual bool VarSize(void) {return false;}
|
|
bool InitValue(PGLOBAL g);
|
|
|
|
protected:
|
|
// Members
|
|
PCOL Next; // Next column in table
|
|
PSZ Name; // Column name
|
|
PCOLDEF Cdp; // To column definition block
|
|
PTDB To_Tdb; // Points to Table Descriptor Block
|
|
PXCOL To_Kcol; // Points to Xindex matching column
|
|
bool Nullable; // True if nullable
|
|
bool Unsigned; // True if unsigned
|
|
int Index; // Column number in table
|
|
int Opt; // Cluster/sort information
|
|
int Buf_Type; // Data type
|
|
int Long; // Internal length in table
|
|
int Precision; // Column length (as for ODBC)
|
|
int Freq; // Evaluated ceiling of distinct values
|
|
FORMAT Format; // Output format
|
|
ushort ColUse; // Column usage
|
|
ushort Status; // Column read status
|
|
}; // end of class COLBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class SPCBLK: Base class for special column descriptors. */
|
|
/***********************************************************************/
|
|
class DllExport SPCBLK : public COLBLK {
|
|
public:
|
|
// Constructor
|
|
SPCBLK(PCOLUMN cp);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) = 0;
|
|
virtual bool GetRnm(void) {return false;}
|
|
|
|
// Methods
|
|
virtual bool IsSpecial(void) {return true;}
|
|
virtual void ReadColumn(PGLOBAL g) = 0;
|
|
virtual void WriteColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
SPCBLK(void) : COLBLK(1) {}
|
|
}; // end of class SPCBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class RIDBLK: ROWID special column descriptor. */
|
|
/***********************************************************************/
|
|
class DllExport RIDBLK : public SPCBLK {
|
|
public:
|
|
// Constructor
|
|
RIDBLK(PCOLUMN cp, bool rnm);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_ROWID;}
|
|
virtual bool GetRnm(void) {return Rnm;}
|
|
|
|
// Methods
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
bool Rnm; // False for RowID, True for RowNum
|
|
}; // end of class RIDBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class FIDBLK: FILEID special column descriptor. */
|
|
/***********************************************************************/
|
|
class DllExport FIDBLK : public SPCBLK {
|
|
public:
|
|
// Constructor
|
|
FIDBLK(PCOLUMN cp, OPVAL op);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_FILID;}
|
|
|
|
// Methods
|
|
virtual void Reset(void) {} // This is a pseudo constant column
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
PCSZ Fn; // The current To_File of the table
|
|
OPVAL Op; // The file part operator
|
|
}; // end of class FIDBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class TIDBLK: TABID special column descriptor. */
|
|
/***********************************************************************/
|
|
class DllExport TIDBLK : public SPCBLK {
|
|
public:
|
|
// Constructor
|
|
TIDBLK(PCOLUMN cp);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_TABID;}
|
|
|
|
// Methods
|
|
virtual void Reset(void) {} // This is a pseudo constant column
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
TIDBLK(void) {}
|
|
|
|
// Members
|
|
PCSZ Tname; // The current table name
|
|
}; // end of class TIDBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class PRTBLK: PARTID special column descriptor. */
|
|
/***********************************************************************/
|
|
class DllExport PRTBLK : public SPCBLK {
|
|
public:
|
|
// Constructor
|
|
PRTBLK(PCOLUMN cp);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_PRTID;}
|
|
|
|
// Methods
|
|
virtual void Reset(void) {} // This is a pseudo constant column
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
PRTBLK(void) {}
|
|
|
|
// Members
|
|
PCSZ Pname; // The current partition name
|
|
}; // end of class PRTBLK
|
|
|
|
/***********************************************************************/
|
|
/* Class SIDBLK: SERVID special column descriptor. */
|
|
/***********************************************************************/
|
|
class DllExport SIDBLK : public SPCBLK {
|
|
public:
|
|
// Constructor
|
|
SIDBLK(PCOLUMN cp);
|
|
|
|
// Implementation
|
|
virtual int GetAmType(void) {return TYPE_AM_SRVID;}
|
|
|
|
// Methods
|
|
virtual void Reset(void) {} // This is a pseudo constant column
|
|
virtual void ReadColumn(PGLOBAL g);
|
|
|
|
protected:
|
|
// Default constructor not to be used
|
|
SIDBLK(void) {}
|
|
|
|
// Members
|
|
PCSZ Sname; // The current server name
|
|
}; // end of class SIDBLK
|
|
|
|
#endif // __COLBLK__H
|