mirror of
https://github.com/MariaDB/server.git
synced 2025-01-16 12:02:42 +01:00
def8d6b363
Aligned client library build and use with the Unix version when it comes to what source to include directly in the builds, and what libraries to link with (bug#30118). Also reviewed, corrected and made more clear when static or dynamic Thread Local Storage is to be used. Some code duplication was removed, and some redundant library usage were removed, reducing the risk of incorrect TLS usage. client/CMakeLists.txt: - Removed code duplication by moving build of "mysqlclient" to the "libmysql" directory - Link clients with the new "mysqlclient_notls", to protect for the case the clients use more than the client API, and access thread data directly. - Synced explicit target addition of sources with Unix. dbug/CMakeLists.txt: No need to set CXX flags, no C++ code libmysql/CMakeLists.txt: - Aligned more with Unix version when it comes to included source files - Build both DLL and static library in this directory - Produce separe static TLS version of the static client library, for use when building clients in this build that might access TLS storage directly. mysys/CMakeLists.txt: We only have to build the static TLS version, as no clients are linking directly with the "mysys" library. scripts/make_win_bin_dist: Ajusted paths to new "mysqlclient.lib" location in source tree sql/CMakeLists.txt: Removed duplicate "ha_blackhole.cc" in file listing Removed explicit link to "dbug.lib" not needed Link with the static TLS "mysqlclient_notls" tests/CMakeLists.txt: Removed explicit link to "dbug", "mysys", "yassl", "taocrypt" and "zlib" not needed. Added explicit source addition "../mysys/my_memmem.c". No need for setting CXX flags, no C++ code. Use the static TLS "mysqlclient_notls" for linkage. zlib/CMakeLists.txt: No need for a dynamic TLS version of this library, no access to thread storage is done from it. Also no need to define MYSQL_CLIENT, not used, or __WIN32__ that is handled by the library header without this define. |
||
---|---|---|
.. | ||
.cvsignore | ||
CMakeLists.txt | ||
dbug.c | ||
dbug_add_tags.pl | ||
dbug_analyze.c | ||
dbug_long.h | ||
doinstall.sh | ||
example1.c | ||
example2.c | ||
example3.c | ||
factorial.c | ||
install.sh | ||
main.c | ||
Makefile.am | ||
mklintlib.sh | ||
monty.doc | ||
my_main.c | ||
qmake.cmd | ||
readme.prof | ||
sanity.c | ||
user.r | ||
vargs.h |
Hi, I'm sending you the modifications I made to your Dbug routines to allow profiling in a (relatively) machine independent fashion. I use your Dbug routines fairly extensively. Unfortunately, it's a royal pain to have to keep profiled versions of various libraries around. The modifications allow profiling without the need for this. How it works. ------------ Basically, I just added code in the dbug routines to write out a file called dbugmon.out (by default). This is an ascii file containing lines of the form: <function-name> E <time-entered> <function-name> X <time-exited> A second program (analyze) reads this file, and produces a report on standard output. Profiling is enabled through the `g' flag. It can take a list of procedure names for which profiling is enabled. By default, it profiles all procedures. The code in ``dbug.c'' opens the profile file for appending. This is in order that one can run a program several times, and get the sum total of all the times, etc. The only system dependent part that I'm aware of is the routine Clock() at the end of dbug.c. This returns the elapsed user time in milliseconds. The version which I have is for 4.3 BSD. As I don't have access to other systems, I'm not certain how this would change. An example of the report generated follows: Profile of Execution Execution times are in milliseconds Calls Time ----- ---- Times Percentage Time Spent Percentage Function Called of total in Function of total Importance ======== ====== ========== =========== ========== ========== factorial 5 83.33 30 100.00 8333 main 1 16.67 0 0.00 0 ======== ====== ========== =========== ========== Totals 6 100.00 30 100.00 As you can see, it's quite self-evident. The ``Importance'' column is a metric obtained by multiplying the percentage of the calls and the percentage of the time. Functions with higher 'importance' benefit the most from being sped up. I'm really not certain how to add support for setjmp/longjmp, or for child processes, so I've ignored that for the time being. In most of the code that I write, it isn't necessary. If you have any good ideas, feel free to add them. This has been very useful to me. If you can use it as part of your dbug distribution, please feel free to do so. Regards, Binayak Banerjee {allegra | astrovax | bpa | burdvax}!sjuvax!bbanerje bbanerje%sjuvax.sju.edu@relay.cs.net July 9, 1987