mirror of
https://github.com/MariaDB/server.git
synced 2025-07-17 00:38:14 +02:00
603077642e
The purpose of this commit is to ensure that creation and changes of
temporary tables are properly and predicable logged to the binary
log. It also fixes some bugs where ROW logging was used in MIXED mode,
when STATEMENT would be a better (and expected) choice.
In this comment STATEMENT stands for logging to binary log in
STATEMENT format, MIXED stands for MIXED binlog format and ROW for ROW
binlog format.
New rules for logging of temporary tables
- CREATE of temporary tables are now by default binlogged only if
STATEMENT binlog format is used. If it is binlogged, 1 is stored in
TABLE_SHARE->table_creation_was_logged. The user can change this
behavior by setting create_temporary_table_binlog_formats to
MIXED,STATEMENT in which case the create is logged in statement
format also in MIXED mode (as before).
- Changes to temporary tables are only binlogged if and only if
the CREATE was logged. The logging happens under STATEMENT or MIXED.
If binlog_format=ROW, temporary table changes are not binlogged. A
temporary table that are changed under ROW are marked as 'not up to
date in binlog' and no future row changes are logged. Any usage of
this temporary table will force row logging of other tables in any
future statements using the temporary table to be row logged.
- DROP TEMPORARY is binlogged only of the CREATE was binlogged.
Changes done:
- Row logging is forced for any statement using temporary tables that
are not up to date in the binary log.
(Before the row logging was forced if the user has a temporary table)
- If there is any changes to the temporary table that is not binlogged,
the table is marked as not up to date.
- TABLE_SHARE->table_creation_was_logged has a new definition for
temporary tables:
0 Table creating was not logged to binary log
1 Table creating was logged to binary log and table is up to date.
2 Table creating was logged to binary log but some changes where
not logged to binary log.
Table is not up to date in binary log is defined as value 0 or 2.
- If a multi-table-update or multi-table-delete fails then
all updated temporary tables are marked as not up to date.
- Enforce row logging if the query is using temporary tables
that are not up to date.
Before row logging was enforced if the user had any
temporary tables.
- When dropping temporary tables use IF EXISTS. This ensures
that slave will not stop if it had crashed and lost the
temporary tables.
- Remove comment and version from DROP /*!4000 TEMPORARY.. generated when
a connection closes that has open temporary tables. Added 'generated by
server' at the end of the DROP.
Bugs fixed:
- When using temporary tables with commands that forced row based,
like INSERT INTO temporary_table VALUES (UUID()), this was never
logged which causes the temporary table to be inconsistent on
master and slave.
- Used binlog format is now clearly defined. It is now only depending
on the current binlog_format and the tables used.
Before it was depending on the user had ANY temporary tables and
the state of 'current_stmt_binlog_format' set by previous queries.
This also caused temporary tables to be logged to binary log in
some cases.
- CREATE TABLE t1 LIKE not_logged_temporary_table caused replication
to stop.
- Rename of not binlogged temporary tables where binlogged to binary log
which caused replication to stop.
Changes in behavior:
- By default create_temporary_table_binlog_formats=STATEMENT, which
means that CREATE TEMPORARY is not logged to binary log under MIXED
binary logging. This can be changed by setting
create_temporary_table_binlog_formats to MIXED,STATEMENT.
- Using temporary tables that was not logged to the binary log will
cause any query using them for updating other tables to be logged in
ROW format. Before all queries was logged in ROW format if the user had
any temporary tables, even if they were not used by the query.
- Generated DROP TEMPORARY TABLE is now always using IF EXISTS and
has a "generated by server" comment in the binary log.
The consequences of the above is that manipulations of a lot of rows
through temporary tables will by default be be slower in mixed mode.
For example:
BEGIN;
CREATE TEMPORARY TABLE tmp AS SELECT a, b, c FROM
large_table1 JOIN large_table2 ON ...;
INSERT INTO other_table SELECT b, c FROM tmp WHERE a <100;
DROP TEMPORARY TABLE tmp;
COMMIT;
By default this will create a huge entry in the binary log, compared
to just a few hundred bytes in statement mode. However the change in
this commit will make usage of temporary tables more reliable and
predicable and is thus worth it. Using statement mode or
create_temporary_table_binlog_formats can be used to avoid this issue.
294 lines
9.3 KiB
Text
294 lines
9.3 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
connection slave;
|
|
set sql_log_bin=0;
|
|
create database y;
|
|
set sql_log_bin=1;
|
|
connection master;
|
|
drop database if exists mysqltest1;
|
|
drop database if exists x;
|
|
create database mysqltest1;
|
|
set sql_log_bin=0;
|
|
create database x;
|
|
set sql_log_bin=1;
|
|
use mysqltest1;
|
|
create table t1 (a int);
|
|
insert into t1 values(9);
|
|
use x;
|
|
create table t1 (a int);
|
|
insert into t1 values(9);
|
|
select * from mysqltest1.t1;
|
|
a
|
|
9
|
|
select * from x.t1;
|
|
a
|
|
9
|
|
connection slave;
|
|
show databases like 'mysqltest1';
|
|
Database (mysqltest1)
|
|
mysqltest1
|
|
select * from test.t1;
|
|
a
|
|
9
|
|
select * from y.t1;
|
|
a
|
|
9
|
|
connection master;
|
|
use mysqltest1;
|
|
drop table t1;
|
|
drop database mysqltest1;
|
|
connection slave;
|
|
connection slave;
|
|
drop database if exists rewrite;
|
|
create database rewrite;
|
|
connection master;
|
|
use test;
|
|
create table t1 (a date, b date, c date not null, d date);
|
|
load data infile '../../std_data/loaddata1.dat' ignore into table t1 character set latin1 fields terminated by ',';
|
|
Warnings:
|
|
Warning 1265 Data truncated for column 'a' at row 1
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
Warning 1265 Data truncated for column 'd' at row 1
|
|
Warning 1265 Data truncated for column 'a' at row 2
|
|
Warning 1265 Data truncated for column 'b' at row 2
|
|
Warning 1265 Data truncated for column 'd' at row 2
|
|
load data infile '../../std_data/loaddata1.dat' into table t1 character set latin1 fields terminated by ',' IGNORE 2 LINES;
|
|
connection slave;
|
|
connection slave;
|
|
select * from rewrite.t1;
|
|
a b c d
|
|
0000-00-00 NULL 0000-00-00 0000-00-00
|
|
0000-00-00 0000-00-00 0000-00-00 0000-00-00
|
|
2003-03-03 2003-03-03 2003-03-03 NULL
|
|
2003-03-03 2003-03-03 2003-03-03 NULL
|
|
connection master;
|
|
truncate table t1;
|
|
load data infile '../../std_data/loaddata1.dat' ignore into table t1 character set latin1 fields terminated by ',' LINES STARTING BY ',' (b,c,d);
|
|
Warnings:
|
|
Warning 1265 Data truncated for column 'c' at row 1
|
|
Warning 1265 Data truncated for column 'd' at row 1
|
|
Warning 1265 Data truncated for column 'b' at row 2
|
|
Warning 1265 Data truncated for column 'd' at row 2
|
|
connection slave;
|
|
connection slave;
|
|
select * from rewrite.t1;
|
|
a b c d
|
|
NULL NULL 0000-00-00 0000-00-00
|
|
NULL 0000-00-00 0000-00-00 0000-00-00
|
|
NULL 2003-03-03 2003-03-03 NULL
|
|
connection master;
|
|
drop table t1;
|
|
create table t1 (a text, b text) character set latin1;
|
|
load data infile '../../std_data/loaddata2.dat' into table t1 character set latin1 fields terminated by ',' enclosed by '''';
|
|
Warnings:
|
|
Warning 1261 Row 3 doesn't contain data for all columns
|
|
connection slave;
|
|
connection slave;
|
|
select concat('|',a,'|'), concat('|',b,'|') from rewrite.t1;
|
|
concat('|',a,'|') concat('|',b,'|')
|
|
|Field A| |Field B|
|
|
|Field 1| |Field 2'
|
|
Field 3,'Field 4|
|
|
|Field 5' ,'Field 6| NULL
|
|
|Field 6| | 'Field 7'|
|
|
connection master;
|
|
drop table t1;
|
|
create table t1 (a int, b char(10)) character set latin1;
|
|
load data infile '../../std_data/loaddata3.dat' into table t1 character set latin1 fields terminated by '' enclosed by '' ignore 1 lines;
|
|
Warnings:
|
|
Note 1265 Data truncated for column 'a' at row 1
|
|
Note 1265 Data truncated for column 'a' at row 2
|
|
Warning 1366 Incorrect integer value: 'error ' for column `test`.`t1`.`a` at row 3
|
|
Warning 1262 Row 3 was truncated; it contained more data than there were input columns
|
|
Note 1265 Data truncated for column 'a' at row 4
|
|
Warning 1366 Incorrect integer value: 'wrong end ' for column `test`.`t1`.`a` at row 5
|
|
Warning 1262 Row 5 was truncated; it contained more data than there were input columns
|
|
connection slave;
|
|
connection slave;
|
|
select * from rewrite.t1;
|
|
a b
|
|
1 row 1
|
|
2 row 2
|
|
0 1234567890
|
|
3 row 3
|
|
0 1234567890
|
|
connection master;
|
|
truncate table t1;
|
|
load data infile '../../std_data/loaddata4.dat' into table t1 character set latin1 fields terminated by '' enclosed by '' lines terminated by '' ignore 1 lines;
|
|
Warnings:
|
|
Note 1265 Data truncated for column 'a' at row 1
|
|
Note 1265 Data truncated for column 'a' at row 2
|
|
Note 1265 Data truncated for column 'a' at row 3
|
|
Warning 1366 Incorrect integer value: '
|
|
' for column `test`.`t1`.`a` at row 4
|
|
Warning 1261 Row 4 doesn't contain data for all columns
|
|
connection slave;
|
|
connection slave;
|
|
select * from rewrite.t1;
|
|
a b
|
|
1 row 1
|
|
2 row 2
|
|
3 row 3
|
|
0
|
|
set sql_log_bin= 0;
|
|
drop database rewrite;
|
|
set sql_log_bin= 1;
|
|
connection master;
|
|
set sql_log_bin= 0;
|
|
drop table t1;
|
|
set sql_log_bin= 1;
|
|
|
|
****
|
|
**** Bug #46861 Auto-closing of temporary tables broken by replicate-rewrite-db
|
|
****
|
|
|
|
****
|
|
**** Preparing the environment
|
|
****
|
|
connection master;
|
|
connect con_temp_03,127.0.0.1,root,,test,$MASTER_MYPORT,;
|
|
connect con_temp_02,127.0.0.1,root,,test,$MASTER_MYPORT,;
|
|
connect con_temp_01,127.0.0.1,root,,test,$MASTER_MYPORT,;
|
|
connection master;
|
|
SET sql_log_bin= 0;
|
|
CREATE DATABASE database_master_temp_01;
|
|
CREATE DATABASE database_master_temp_02;
|
|
CREATE DATABASE database_master_temp_03;
|
|
SET sql_log_bin= 1;
|
|
connection slave;
|
|
SET sql_log_bin= 0;
|
|
CREATE DATABASE database_slave_temp_01;
|
|
CREATE DATABASE database_slave_temp_02;
|
|
CREATE DATABASE database_slave_temp_03;
|
|
SET sql_log_bin= 1;
|
|
|
|
****
|
|
**** Creating temporary tables on different databases with different connections
|
|
****
|
|
**** con_temp_01 --> creates
|
|
**** t_01_01_temp on database_master_temp_01
|
|
****
|
|
**** con_temp_02 --> creates
|
|
**** t_01_01_temp on database_master_temp_01
|
|
**** t_02_01_temp, t_02_02_temp on database_master_temp_02
|
|
****
|
|
**** con_temp_02 --> creates
|
|
**** t_01_01_temp on database_master_temp_01
|
|
**** t_02_01_temp, t_02_02_temp on database_master_temp_02
|
|
**** t_03_01_temp, t_03_02_temp, t_03_03_temp on database_master_temp_03
|
|
****
|
|
connection con_temp_01;
|
|
USE database_master_temp_01;
|
|
CREATE TEMPORARY TABLE t_01_01_temp(a int);
|
|
INSERT INTO t_01_01_temp VALUES(1);
|
|
connection con_temp_02;
|
|
USE database_master_temp_01;
|
|
CREATE TEMPORARY TABLE t_01_01_temp(a int);
|
|
INSERT INTO t_01_01_temp VALUES(1);
|
|
USE database_master_temp_02;
|
|
CREATE TEMPORARY TABLE t_02_01_temp(a int);
|
|
INSERT INTO t_02_01_temp VALUES(1);
|
|
CREATE TEMPORARY TABLE t_02_02_temp(a int);
|
|
INSERT INTO t_02_02_temp VALUES(1);
|
|
connection con_temp_03;
|
|
USE database_master_temp_01;
|
|
CREATE TEMPORARY TABLE t_01_01_temp(a int);
|
|
INSERT INTO t_01_01_temp VALUES(1);
|
|
USE database_master_temp_02;
|
|
CREATE TEMPORARY TABLE t_02_01_temp(a int);
|
|
INSERT INTO t_02_01_temp VALUES(1);
|
|
CREATE TEMPORARY TABLE t_02_02_temp(a int);
|
|
INSERT INTO t_02_02_temp VALUES(1);
|
|
USE database_master_temp_03;
|
|
CREATE TEMPORARY TABLE t_03_01_temp(a int);
|
|
INSERT INTO t_03_01_temp VALUES(1);
|
|
CREATE TEMPORARY TABLE t_03_02_temp(a int);
|
|
INSERT INTO t_03_02_temp VALUES(1);
|
|
CREATE TEMPORARY TABLE t_03_03_temp(a int);
|
|
INSERT INTO t_03_03_temp VALUES(1);
|
|
|
|
**** Dropping the connections
|
|
**** We want to SHOW BINLOG EVENTS, to know what was logged. But there is no
|
|
**** guarantee that logging of the terminated con1 has been done yet.a To be
|
|
**** sure that logging has been done, we use a user lock.
|
|
|
|
connection master;
|
|
connection slave;
|
|
connection slave;
|
|
show status like 'Slave_open_temp_tables';
|
|
Variable_name Value
|
|
Slave_open_temp_tables 10
|
|
connection master;
|
|
connection con_temp_01;
|
|
select get_lock("con_01",10);
|
|
get_lock("con_01",10)
|
|
1
|
|
connection master;
|
|
disconnect con_temp_01;
|
|
select get_lock("con_01",10);
|
|
get_lock("con_01",10)
|
|
1
|
|
connection con_temp_02;
|
|
select get_lock("con_02",10);
|
|
get_lock("con_02",10)
|
|
1
|
|
connection master;
|
|
disconnect con_temp_02;
|
|
select get_lock("con_02",10);
|
|
get_lock("con_02",10)
|
|
1
|
|
connection con_temp_03;
|
|
select get_lock("con_03",10);
|
|
get_lock("con_03",10)
|
|
1
|
|
connection master;
|
|
disconnect con_temp_03;
|
|
select get_lock("con_03",10);
|
|
get_lock("con_03",10)
|
|
1
|
|
|
|
**** Checking the binary log and temporary tables
|
|
|
|
connection master;
|
|
connection slave;
|
|
connection slave;
|
|
show status like 'Slave_open_temp_tables';
|
|
Variable_name Value
|
|
Slave_open_temp_tables 0
|
|
connection master;
|
|
include/show_binlog_events.inc
|
|
Log_name Pos Event_type Server_id End_log_pos Info
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_01`; DROP TEMPORARY TABLE IF EXISTS `t_01_01_temp` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_02`; DROP TEMPORARY TABLE IF EXISTS `t_02_02_temp`,`t_02_01_temp` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_01`; DROP TEMPORARY TABLE IF EXISTS `t_01_01_temp` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_03`; DROP TEMPORARY TABLE IF EXISTS `t_03_03_temp`,`t_03_02_temp`,`t_03_01_temp` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_02`; DROP TEMPORARY TABLE IF EXISTS `t_02_02_temp`,`t_02_01_temp` /* generated by server */
|
|
master-bin.000001 # Gtid # # GTID #-#-#
|
|
master-bin.000001 # Query # # use `database_master_temp_01`; DROP TEMPORARY TABLE IF EXISTS `t_01_01_temp` /* generated by server */
|
|
****
|
|
**** Cleaning up the test case
|
|
****
|
|
connection master;
|
|
SET sql_log_bin= 0;
|
|
DROP DATABASE database_master_temp_01;
|
|
DROP DATABASE database_master_temp_02;
|
|
DROP DATABASE database_master_temp_03;
|
|
DROP DATABASE x;
|
|
SET sql_log_bin= 1;
|
|
connection slave;
|
|
SET sql_log_bin= 0;
|
|
DROP DATABASE database_slave_temp_01;
|
|
DROP DATABASE database_slave_temp_02;
|
|
DROP DATABASE database_slave_temp_03;
|
|
DROP DATABASE y;
|
|
SET sql_log_bin= 1;
|
|
connection master;
|
|
connection slave;
|
|
connection default;
|
|
set @@global.create_temporary_table_binlog_formats=default;
|
|
include/rpl_end.inc
|