mirror of
https://github.com/MariaDB/server.git
synced 2025-07-19 01:38:13 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
41 lines
1.3 KiB
Text
41 lines
1.3 KiB
Text
#
|
|
# MDEV-12684 Show what config file a sysvar got a value from
|
|
#
|
|
|
|
source include/not_embedded.inc;
|
|
if (!$SQL_ERRLOG_SO) {
|
|
skip No sql_errlog plugin;
|
|
}
|
|
|
|
#system_versioning_alter_history
|
|
#binlog_format
|
|
set completion_type=CHAIN;
|
|
set global low_priority_updates=1;
|
|
|
|
install soname 'sql_errlog';
|
|
|
|
vertical_results;
|
|
replace_regex /(C:)?\/.*\//var\//;
|
|
select * from information_schema.system_variables
|
|
where variable_name in (
|
|
'completion_type', #session!=global, origin=compile-time
|
|
'low_priority_updates', #global!=default, origin=sql
|
|
'column_compression_threshold', #origin=command-line
|
|
'plugin_maturity', #origin=config
|
|
'sql_error_log_rate', #plugin, origin=command-line
|
|
'sql_error_log_rotations' #plugin, origin=config
|
|
)
|
|
order by variable_name;
|
|
|
|
create user foo@localhost;
|
|
|
|
connect foo,localhost,foo;
|
|
select global_value_path from information_schema.system_variables where variable_name='plugin_maturity';
|
|
connection default;
|
|
replace_regex /(C:)?\/.*\//var\//;
|
|
select global_value_path from information_schema.system_variables where variable_name='plugin_maturity';
|
|
disconnect foo;
|
|
drop user foo@localhost;
|
|
set global low_priority_updates=default;
|
|
disable_warnings;
|
|
uninstall soname 'sql_errlog';
|