mirror of
https://github.com/MariaDB/server.git
synced 2025-01-15 19:42:28 +01:00
47010ccffa
- Major rewrite of ddl_log.cc and ddl_log.h
- ddl_log.cc described in the beginning how the recovery works.
- ddl_log.log has unique signature and is dynamic. It's easy to
add more information to the header and other ddl blocks while still
being able to execute old ddl entries.
- IO_SIZE for ddl blocks is now dynamic. Can be changed without affecting
recovery of old logs.
- Code is more modular and is now usable outside of partition handling.
- Renamed log file to dll_recovery.log and added option --log-ddl-recovery
to allow one to specify the path & filename.
- Added ddl_log_entry_phase[], number of phases for each DDL action,
which allowed me to greatly simply set_global_from_ddl_log_entry()
- Changed how strings are stored in log entries, which allows us to
store much more information in a log entry.
- ddl log is now always created at start and deleted on normal shutdown.
This simplices things notable.
- Added probes debug_crash_here() and debug_simulate_error() to simply
crash testing and allow crash after a given number of times a probe
is executed. See comments in debug_sync.cc and rename_table.test for
how this can be used.
- Reverting failed table and view renames is done trough the ddl log.
This ensures that the ddl log is tested also outside of recovery.
- Added helper function 'handler::needs_lower_case_filenames()'
- Extend binary log with Q_XID events. ddl log handling is using this
to check if a ddl log entry was logged to the binary log (if yes,
it will be deleted from the log during ddl_log_close_binlogged_events()
- If a DDL entry fails 3 time, disable it. This is to ensure that if
we have a crash in ddl recovery code the server will not get stuck
in a forever crash-restart-crash loop.
mysqltest.cc changes:
- --die will now replace $variables with their values
- $error will contain the error of the last failed statement
storage engine changes:
- maria_rename() was changed to be more robust against crashes during
rename.
85 lines
2.2 KiB
Text
85 lines
2.2 KiB
Text
--source include/have_debug.inc
|
|
--source include/not_valgrind.inc
|
|
--source include/not_embedded.inc
|
|
|
|
#
|
|
# Testing of atomic rename with crashes in a lot of different places
|
|
#
|
|
|
|
let $crash_count=4;
|
|
let $crash_points='ddl_log_rename_before_rename_view','ddl_log_rename_after_rename_view','rename_view_after_rename_schema_file','definition_file_after_create';
|
|
|
|
# Number of renames in the tested statement
|
|
let $renames=5;
|
|
|
|
let $old_debug=`select @@debug_dbug`;
|
|
|
|
let $e=0;
|
|
|
|
--disable_query_log
|
|
create table t1 (a int not null);
|
|
create table t2 (b int not null);
|
|
create table t3 (c int not null);
|
|
create table t4 (d int not null);
|
|
insert into t1 values(1);
|
|
insert into t2 values(2);
|
|
insert into t3 values(3);
|
|
insert into t4 values(4);
|
|
create view v1 as select t1.a from t1;
|
|
create view v2 as select t2.b from t2;
|
|
create view v3 as select t3.c from t3;
|
|
create view v4 as select t4.d from t4;
|
|
flush tables;
|
|
|
|
let $c=0;
|
|
while ($c < $crash_count)
|
|
{
|
|
inc $c;
|
|
let $crash=`select ELT($c, $crash_points)`;
|
|
let $r=0;
|
|
while ($r < $renames)
|
|
{
|
|
inc $r;
|
|
echo "engine: crash point: $crash position: $r";
|
|
|
|
--exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
|
|
--disable_reconnect
|
|
--eval set @@debug_dbug="+d,$crash",@debug_crash_counter=$r
|
|
let $errno=0;
|
|
--error 0,2013
|
|
rename table v1 to v5, v2 to v1, v5 to v2, v4 to v5, v3 to v4;
|
|
let $error=$errno;
|
|
--enable_reconnect
|
|
--source include/wait_until_connected_again.inc
|
|
--disable_query_log
|
|
--eval set @@debug_dbug="$old_debug"
|
|
|
|
if ($error == 0)
|
|
{
|
|
echo "No crash!";
|
|
# No crash, rename things back
|
|
rename table v4 to v3, v5 to v4, v2 to v5, v1 to v2, v5 to v1;
|
|
}
|
|
|
|
# Ensure that the tables are back to original
|
|
let $res=`select v1.a+v2.b+v3.c+v4.d from v1,v2,v3,v4`;
|
|
if ($res != 10)
|
|
{
|
|
die "Got result $res when 10 was expected";
|
|
}
|
|
}
|
|
}
|
|
|
|
--echo #
|
|
--echo # At last check that rename works when there is no crash
|
|
--echo #
|
|
|
|
rename table v1 to v5, v2 to v1, v5 to v2, v4 to v5, v3 to v4;
|
|
let $res=`select (select sum(v1.b) from v1)+ (select sum(v2.a) from v2) + (select sum(v4.c) from v4)+ (select sum(v5.d) from v5)`;
|
|
if ($res != 10)
|
|
{
|
|
die "Got result $res when 10 was expected";
|
|
}
|
|
drop view v1,v2,v4,v5;
|
|
drop table t1,t2,t3,t4;
|
|
--enable_query_log
|