mirror of
https://github.com/MariaDB/server.git
synced 2025-01-15 19:42:28 +01:00
dd99780967
PURGE BINARY LOGS did not always purge binary logs. This commit fixes
some of the issues and adds notifications if a binary log cannot be
purged.
User visible changes:
- 'PURGE BINARY LOG TO log_name' and 'PURGE BINARY LOGS BEFORE date'
worked differently. 'TO' ignored 'slave_connections_needed_for_purge'
while 'BEFORE' did not. Now both versions ignores the
'slave_connections_needed_for_purge variable'.
- 'PURGE BINARY LOG..' commands now returns 'note' if a binary log cannot
be deleted like
Note 1375 Binary log 'master-bin.000004' is not purged because it is
the current active binlog
- Automatic binary log purges, based on date or size, will write a
note to the error log if a binary log matching the size or date
cannot yet be deleted.
- If 'slave_connections_needed_for_purge' is set from a config or
command line, it is set to 0 if Galera is enabled and 1 otherwise
(old default). This ensures that automatic binary log purge works
with Galera as before the addition of
'slave_connections_needed_for_purge'.
If the variable is changed to 0, a warning will be printed to the error
log.
Code changes:
- Added THD argument to several purge_logs related functions that needed
THD.
- Added 'interactive' options to purge_logs functions. This allowed
me to remove testing of sql_command == SQLCOM_PURGE.
- Changed purge_logs_before_date() to first check if log is applicable
before calling can_purge_logs(). This ensures we do not get a
notification for logs that does not match the remove criteria.
- MYSQL_BIN_LOG::can_purge_log() will write notifications to the user
or error log if a log cannot yet be removed.
- log_in_use() will return reason why a binary log cannot be removed.
Changes to keep code consistent:
- Moved checking of binlog_format for Galera to be after Galera is
initialized (The old check never worked). If Galera is enabled
we now change the binlog_format to ROW, with a warning, instead of
aborting the server. If this change happens a warning will be printed to
the error log.
- Print a warning if Galera or FLASHBACK changes the binlog_format
to ROW. Before it was done silently.
Reviewed by: Sergei Golubchik <serg@mariadb.com>,
Kristian Nielsen <knielsen@knielsen-hq.org>
56 lines
1.4 KiB
PHP
56 lines
1.4 KiB
PHP
# include/wait_for_purge.inc
|
|
#
|
|
# SUMMARY
|
|
#
|
|
# Repeatedly attempt to purge binlogs up to a specific point, until
|
|
# SHOW BINARY LOGS shows it has succeeded.
|
|
# This can be useful to avoid races where slaves are stopped but the
|
|
# corresponding binlog dump thread on the master has not yet terminated.
|
|
# Async binlog checkpoints can also delay purge.
|
|
#
|
|
# Note that it may be necessary to inject at least one event in the binlog
|
|
# after stopping slaves, or master may not detect stop of slave for a long
|
|
# time (or forever), depending on details of test case, if replication
|
|
# heartbeat is enabled, etc.
|
|
#
|
|
# USAGE:
|
|
#
|
|
# --let $purge_binlogs_to=master-bin.000003
|
|
# --source include/wait_for_purge.inc
|
|
#
|
|
# SIDE EFFECTS:
|
|
#
|
|
# Disables --query_log and warnings while running, enables them afterwards.
|
|
|
|
--echo include/wait_for_purge.inc "$purge_binlogs_to"
|
|
|
|
let $_wait_count= 300;
|
|
let $_done= 0;
|
|
|
|
--disable_query_log
|
|
--disable_warnings
|
|
|
|
while ($_wait_count)
|
|
{
|
|
dec $_wait_count;
|
|
eval PURGE BINARY LOGS TO "$purge_binlogs_to";
|
|
let $_cur_binlog= query_get_value(SHOW BINARY LOGS, Log_name, 1);
|
|
if (`SELECT "$_cur_binlog" = "$purge_binlogs_to"`)
|
|
{
|
|
let $_done= 1;
|
|
let $_wait_count= 0;
|
|
}
|
|
if ($_wait_count)
|
|
{
|
|
real_sleep 0.1;
|
|
}
|
|
}
|
|
|
|
if (!$_done)
|
|
{
|
|
SHOW FULL PROCESSLIST;
|
|
eval SHOW BINARY LOGS;
|
|
--die ERROR: failed while waiting for binlog purge to $purge_binlogs_to
|
|
}
|
|
--enable_warnings
|
|
--enable_query_log
|