mirror of
https://github.com/MariaDB/server.git
synced 2025-01-15 19:42:28 +01:00
061adae9a2
On Windows systems, occurrences of ERROR_SHARING_VIOLATION due to conflicting share modes between processes accessing the same file can result in CreateFile failures. mysys' my_open() already incorporates a workaround by implementing wait/retry logic on Windows. But this does not help if files are opened using shell redirection like mysqltest traditionally did it, i.e via --echo exec "some text" > output_file In such cases, it is cmd.exe, that opens the output_file, and it won't do any sharing-violation retries. This commit addresses the issue by introducing a new built-in command, 'write_line', in mysqltest. This new command serves as a brief alternative to 'write_file', with a single line output, that also resolves variables like "exec" would. Internally, this command will use my_open(), and therefore retry-on-error logic. Hopefully this will eliminate the very sporadic "can't open file because it is used by another process" error on CI.
51 lines
1.3 KiB
PHP
51 lines
1.3 KiB
PHP
# Include this script only after using shutdown_mysqld.inc
|
|
# where $_expect_file_name was initialized.
|
|
# Write file to make mysql-test-run.pl start up the server again
|
|
|
|
# restart_noprint defines how much is printed to the .result file
|
|
# if 0 (default) then '# result' and restart_parameters are printed
|
|
# if 1 then print #result but not the content of restart_parameters
|
|
# if 2 then nothing is printed
|
|
|
|
if (!$restart_noprint)
|
|
{
|
|
--let $restart_noprint=0
|
|
}
|
|
|
|
--let $restart_cmd= restart
|
|
|
|
if ($restart_bindir)
|
|
{
|
|
--let $restart_cmd= restart_bindir $restart_bindir
|
|
}
|
|
|
|
if ($restart_parameters)
|
|
{
|
|
--write_line "$restart_cmd: $restart_parameters" $_expect_file_name
|
|
if (!$restart_noprint)
|
|
{
|
|
--replace_result $MYSQL_TEST_DIR MYSQL_TEST_DIR $MYSQLTEST_VARDIR MYSQLTEST_VARDIR
|
|
--exec echo "# $restart_cmd: $restart_parameters"
|
|
}
|
|
if ($restart_noprint == 1)
|
|
{
|
|
--exec echo "# $restart_cmd: with restart_parameters"
|
|
}
|
|
}
|
|
if (!$restart_parameters)
|
|
{
|
|
--write_line "$restart_cmd" $_expect_file_name
|
|
if ($restart_noprint < 2)
|
|
{
|
|
--exec echo "# $restart_cmd"
|
|
}
|
|
}
|
|
|
|
# Turn on reconnect
|
|
--enable_reconnect
|
|
|
|
# Call script that will poll the server waiting for it to be back online again
|
|
--source include/wait_until_connected_again.inc
|
|
|
|
# Turn off reconnect again
|
|
--disable_reconnect
|