mirror of
https://github.com/MariaDB/server.git
synced 2025-02-19 03:45:35 +01:00
08c852026d
This patch is the result of running run-clang-tidy -fix -header-filter=.* -checks='-*,modernize-use-equals-default' . Code style changes have been done on top. The result of this change leads to the following improvements: 1. Binary size reduction. * For a -DBUILD_CONFIG=mysql_release build, the binary size is reduced by ~400kb. * A raw -DCMAKE_BUILD_TYPE=Release reduces the binary size by ~1.4kb. 2. Compiler can better understand the intent of the code, thus it leads to more optimization possibilities. Additionally it enabled detecting unused variables that had an empty default constructor but not marked so explicitly. Particular change required following this patch in sql/opt_range.cc result_keys, an unused template class Bitmap now correctly issues unused variable warnings. Setting Bitmap template class constructor to default allows the compiler to identify that there are no side-effects when instantiating the class. Previously the compiler could not issue the warning as it assumed Bitmap class (being a template) would not be performing a NO-OP for its default constructor. This prevented the "unused variable warning".
62 lines
1.6 KiB
C++
62 lines
1.6 KiB
C++
|
|
// vim:sw=2:ai
|
|
|
|
/*
|
|
* Copyright (C) 2010 DeNA Co.,Ltd.. All rights reserved.
|
|
* See COPYRIGHT.txt for details.
|
|
*/
|
|
|
|
#ifndef DENA_HSTCPCLI_HPP
|
|
#define DENA_HSTCPCLI_HPP
|
|
|
|
#include <sys/types.h>
|
|
#include <sys/socket.h>
|
|
#include <string>
|
|
#include <memory>
|
|
|
|
#include "config.hpp"
|
|
#include "socket.hpp"
|
|
#include "string_ref.hpp"
|
|
#include "string_buffer.hpp"
|
|
|
|
namespace dena {
|
|
|
|
struct hstcpcli_filter {
|
|
string_ref filter_type;
|
|
string_ref op;
|
|
size_t ff_offset;
|
|
string_ref val;
|
|
hstcpcli_filter() : ff_offset(0) { }
|
|
};
|
|
|
|
struct hstcpcli_i;
|
|
typedef std::auto_ptr<hstcpcli_i> hstcpcli_ptr;
|
|
|
|
struct hstcpcli_i {
|
|
virtual ~hstcpcli_i() = default;
|
|
virtual void close() = 0;
|
|
virtual int reconnect() = 0;
|
|
virtual bool stable_point() = 0;
|
|
virtual void request_buf_auth(const char *secret, const char *typ) = 0;
|
|
virtual void request_buf_open_index(size_t pst_id, const char *dbn,
|
|
const char *tbl, const char *idx, const char *retflds,
|
|
const char *filflds = 0) = 0;
|
|
virtual void request_buf_exec_generic(size_t pst_id, const string_ref& op,
|
|
const string_ref *kvs, size_t kvslen, uint32_t limit, uint32_t skip,
|
|
const string_ref& mod_op, const string_ref *mvs, size_t mvslen,
|
|
const hstcpcli_filter *fils = 0, size_t filslen = 0,
|
|
int invalues_keypart = -1, const string_ref *invalues = 0,
|
|
size_t invalueslen = 0) = 0; // FIXME: too long
|
|
virtual int request_send() = 0;
|
|
virtual int response_recv(size_t& num_flds_r) = 0;
|
|
virtual const string_ref *get_next_row() = 0;
|
|
virtual void response_buf_remove() = 0;
|
|
virtual int get_error_code() = 0;
|
|
virtual std::string get_error() = 0;
|
|
static hstcpcli_ptr create(const socket_args& args);
|
|
};
|
|
|
|
};
|
|
|
|
#endif
|
|
|