mirror of
https://github.com/MariaDB/server.git
synced 2025-07-14 15:28:15 +02:00
b03469a9cf
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
15 lines
375 B
Text
15 lines
375 B
Text
connection node_2;
|
|
connection node_1;
|
|
connect node_3, 127.0.0.1, root, , test, $NODE_MYPORT_3;
|
|
connection node_3;
|
|
CREATE TABLE t1 (f1 INTEGER PRIMARY KEY AUTO_INCREMENT) ENGINE=InnoDB;
|
|
connection node_2;
|
|
connection node_3;
|
|
DROP TABLE t1;
|
|
connection node_2;
|
|
connection node_2;
|
|
STOP SLAVE;
|
|
RESET SLAVE ALL;
|
|
connection node_3;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|