mirror of
https://github.com/MariaDB/server.git
synced 2025-02-07 06:12:18 +01:00
![Vladislav Vaintroub](/assets/img/avatar_default.png)
On Windows systems, occurrences of ERROR_SHARING_VIOLATION due to conflicting share modes between processes accessing the same file can result in CreateFile failures. mysys' my_open() already incorporates a workaround by implementing wait/retry logic on Windows. But this does not help if files are opened using shell redirection like mysqltest traditionally did it, i.e via --echo exec "some text" > output_file In such cases, it is cmd.exe, that opens the output_file, and it won't do any sharing-violation retries. This commit addresses the issue by introducing a new built-in command, 'write_line', in mysqltest. This new command serves as a brief alternative to 'write_file', with a single line output, that also resolves variables like "exec" would. Internally, this command will use my_open(), and therefore retry-on-error logic. Hopefully this will eliminate the very sporadic "can't open file because it is used by another process" error on CI.
47 lines
1.2 KiB
Text
47 lines
1.2 KiB
Text
--source include/have_innodb.inc
|
|
--source include/not_embedded.inc
|
|
|
|
#
|
|
# MDEV-9918: [ERROR] mysqld got signal 11 during ALTER TABLE `name` COLUMN ADD
|
|
#
|
|
|
|
call mtr.add_suppression("Table .* has a primary key in InnoDB data dictionary, but not in MariaDB");
|
|
call mtr.add_suppression("InnoDB: Table .* contains .* indexes inside InnoDB");
|
|
|
|
create table t1 (pk int, i int, key(i)) engine=InnoDB;
|
|
insert into t1 values (1,1),(2,2);
|
|
|
|
--let $datadir= `select @@datadir`
|
|
|
|
flush tables;
|
|
|
|
--echo # Save the .frm file without the PK
|
|
|
|
--copy_file $datadir/test/t1.frm $MYSQLTEST_VARDIR/tmp/t1.frm
|
|
|
|
alter table t1 add primary key (pk);
|
|
|
|
--echo # Stop the server, replace the frm with the old one and restart the server
|
|
|
|
--write_line wait $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
|
|
--shutdown_server
|
|
--source include/wait_until_disconnected.inc
|
|
|
|
--remove_file $datadir/test/t1.frm
|
|
--copy_file $MYSQLTEST_VARDIR/tmp/t1.frm $datadir/test/t1.frm
|
|
|
|
--write_line restart $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
|
|
--enable_reconnect
|
|
--source include/wait_until_connected_again.inc
|
|
|
|
--enable_prepare_warnings
|
|
show create table t1;
|
|
select * from t1;
|
|
alter table t1 add j int;
|
|
show warnings;
|
|
show create table t1;
|
|
alter table t1 add primary key (pk);
|
|
show warnings;
|
|
show create table t1;
|
|
# Cleanup
|
|
drop table t1;
|