mirror of
https://github.com/MariaDB/server.git
synced 2025-08-21 18:01:37 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc |
||
|---|---|---|
| .. | ||
| federated_gcol.result | ||
| gcol_archive.result | ||
| gcol_blackhole.result | ||
| gcol_blocked_sql_funcs_innodb.result | ||
| gcol_blocked_sql_funcs_myisam.result | ||
| gcol_bug20746926.result | ||
| gcol_bugfixes.result | ||
| gcol_column_def_options_innodb.result | ||
| gcol_column_def_options_myisam.result | ||
| gcol_csv.result | ||
| gcol_falcon.result | ||
| gcol_handler_innodb.result | ||
| gcol_handler_myisam.result | ||
| gcol_ins_upd_innodb.result | ||
| gcol_ins_upd_myisam.result | ||
| gcol_keys_innodb.result | ||
| gcol_keys_myisam.result | ||
| gcol_memory.result | ||
| gcol_merge.result | ||
| gcol_ndb.result | ||
| gcol_non_stored_columns_innodb.result | ||
| gcol_non_stored_columns_myisam.result | ||
| gcol_partition_innodb.result | ||
| gcol_partition_myisam.result | ||
| gcol_purge.result | ||
| gcol_rejected_innodb.result | ||
| gcol_rollback.result | ||
| gcol_select_innodb.result | ||
| gcol_select_myisam.result | ||
| gcol_supported_sql_funcs_innodb.result | ||
| gcol_supported_sql_funcs_myisam.result | ||
| gcol_trigger_sp_innodb.result | ||
| gcol_trigger_sp_myisam.result | ||
| gcol_update.result | ||
| gcol_view_innodb.result | ||
| gcol_view_myisam.result | ||
| innodb_partition.result | ||
| innodb_prefix_index_check.result | ||
| innodb_virtual_basic.result | ||
| innodb_virtual_blob.result | ||
| innodb_virtual_debug.result | ||
| innodb_virtual_debug_purge.result | ||
| innodb_virtual_fk.result | ||
| innodb_virtual_fk_restart.result | ||
| innodb_virtual_index.result | ||
| innodb_virtual_purge.result | ||
| innodb_virtual_rebuild.result | ||
| innodb_virtual_stats.result | ||
| innodb_wl8114.result | ||
| main_alter_table.result | ||
| main_mysqldump.result | ||
| rpl_gcol.result | ||
| virtual_index_drop.result | ||