mirror of
https://github.com/MariaDB/server.git
synced 2025-08-15 23:11:33 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
48 lines
1.2 KiB
Text
48 lines
1.2 KiB
Text
--source include/not_embedded.inc
|
|
|
|
--echo #
|
|
--echo # WL#5968: Implement START TRANSACTION READ (WRITE|ONLY);
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # Test9: The --transaction-read-only startup option.
|
|
|
|
--echo # Check that the option was set by the .opt file.
|
|
SELECT @@transaction_read_only;
|
|
|
|
--echo # Also for new connections.
|
|
connect (con1, localhost, root);
|
|
SELECT @@transaction_read_only;
|
|
SET SESSION TRANSACTION READ WRITE;
|
|
SELECT @@transaction_read_only;
|
|
disconnect con1;
|
|
|
|
connection default;
|
|
SELECT @@transaction_read_only;
|
|
|
|
|
|
--echo #
|
|
--echo # Test 10: SET TRANSACTION / START TRANSACTION + implicit commit.
|
|
|
|
SET SESSION TRANSACTION READ WRITE;
|
|
--disable_ps_protocol
|
|
SET TRANSACTION READ ONLY;
|
|
--echo # Since DDL does implicit commit before starting, SET TRANSACTION
|
|
--echo # will have no effect because the "next" transaction will already
|
|
--echo # be over before the DDL statement starts.
|
|
CREATE TABLE t1 (a INT);
|
|
|
|
START TRANSACTION READ ONLY;
|
|
--echo # The same happens with START TRANSACTION
|
|
DROP TABLE t1;
|
|
--enable_ps_protocol
|
|
|
|
--echo #
|
|
--echo # Test 11: INSERT DELAYED
|
|
|
|
CREATE TABLE t1(a INT);
|
|
START TRANSACTION READ ONLY;
|
|
--error ER_CANT_EXECUTE_IN_READ_ONLY_TRANSACTION
|
|
INSERT DELAYED INTO t1 VALUES (1);
|
|
COMMIT;
|
|
DROP TABLE t1;
|