mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:31:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
30 lines
954 B
Text
30 lines
954 B
Text
# Turn on compression between the client and server
|
|
# and run a number of tests
|
|
|
|
--source include/have_ssl_communication.inc
|
|
--source include/have_compress.inc
|
|
--source include/not_staging.inc
|
|
--source include/default_optimizer_switch.inc
|
|
|
|
connect (ssl_compress_con,localhost,root,,,,,SSL COMPRESS);
|
|
|
|
# Check ssl turned on
|
|
SELECT (VARIABLE_VALUE <> '') AS have_ssl FROM INFORMATION_SCHEMA.SESSION_STATUS WHERE VARIABLE_NAME='Ssl_cipher';
|
|
|
|
# Check compression turned on
|
|
SHOW STATUS LIKE 'Compression';
|
|
|
|
# Source select test case
|
|
-- source include/common-tests.inc
|
|
|
|
# Check ssl turned on
|
|
SELECT (VARIABLE_VALUE <> '') AS have_ssl FROM INFORMATION_SCHEMA.SESSION_STATUS WHERE VARIABLE_NAME='Ssl_cipher';
|
|
|
|
# Check compression turned on
|
|
SHOW STATUS LIKE 'Compression';
|
|
|
|
connection default;
|
|
disconnect ssl_compress_con;
|
|
|
|
## This test file is for testing encrypted communication only, not other
|
|
## encryption routines that the SSL library happens to provide!
|