mirror of
https://github.com/MariaDB/server.git
synced 2025-08-16 15:31:32 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
115 lines
2.5 KiB
Text
115 lines
2.5 KiB
Text
connect con1root,localhost,root,,;
|
|
connect con2root,localhost,root,,;
|
|
connect con3root,localhost,root,,;
|
|
connection con1root;
|
|
use test;
|
|
create table t1 (s1 int, s2 int, s3 int);
|
|
create procedure bug4934()
|
|
begin
|
|
insert into t1 values (1,0,1);
|
|
end//
|
|
connection con2root;
|
|
use test;
|
|
call bug4934();
|
|
select * from t1;
|
|
s1 s2 s3
|
|
1 0 1
|
|
connection con1root;
|
|
drop table t1;
|
|
create table t1 (s1 int, s2 int, s3 int);
|
|
drop procedure bug4934;
|
|
create procedure bug4934()
|
|
begin
|
|
end//
|
|
connection con2root;
|
|
select * from t1;
|
|
s1 s2 s3
|
|
call bug4934();
|
|
select * from t1;
|
|
s1 s2 s3
|
|
connection con1root;
|
|
drop table t1;
|
|
drop procedure bug4934;
|
|
drop procedure if exists bug9486;
|
|
drop table if exists t1, t2;
|
|
create table t1 (id1 int, val int);
|
|
create table t2 (id2 int);
|
|
create procedure bug9486()
|
|
update t1, t2 set val= 1 where id1=id2;
|
|
call bug9486();
|
|
connection con2root;
|
|
lock tables t2 write;
|
|
connection con1root;
|
|
call bug9486();
|
|
connection con2root;
|
|
SELECT state,info FROM information_schema.processlist WHERE id=con1root_id;
|
|
state info
|
|
Waiting for table metadata lock update t1, t2 set val= 1 where id1=id2
|
|
unlock tables;
|
|
connection con1root;
|
|
drop procedure bug9486;
|
|
drop table t1, t2;
|
|
drop procedure if exists bug11158;
|
|
create procedure bug11158() delete t1 from t1, t2 where t1.id = t2.id;
|
|
create table t1 (id int, j int);
|
|
insert into t1 values (1, 1), (2, 2);
|
|
create table t2 (id int);
|
|
insert into t2 values (1);
|
|
call bug11158();
|
|
select * from t1;
|
|
id j
|
|
2 2
|
|
connection con2root;
|
|
lock tables t2 read;
|
|
connection con1root;
|
|
call bug11158();
|
|
connection con2root;
|
|
unlock tables;
|
|
connection con1root;
|
|
drop procedure bug11158;
|
|
drop table t1, t2;
|
|
drop function if exists bug11554;
|
|
drop view if exists v1;
|
|
create table t1 (i int);
|
|
create function bug11554 () returns int return 1;
|
|
create view v1 as select bug11554() as f;
|
|
connection con2root;
|
|
insert into t1 (select f from v1);
|
|
connection con1root;
|
|
drop function bug11554;
|
|
drop table t1;
|
|
drop view v1;
|
|
drop procedure if exists p1;
|
|
drop procedure if exists p2;
|
|
connection con1root;
|
|
create table t1 (s1 int)|
|
|
create procedure p1() select * from t1|
|
|
create procedure p2()
|
|
begin
|
|
insert into t1 values (1);
|
|
call p1();
|
|
select * from t1;
|
|
end|
|
|
connection con2root;
|
|
use test;
|
|
lock table t1 write;
|
|
connection con1root;
|
|
call p2();
|
|
connection con3root;
|
|
use test;
|
|
drop procedure p1;
|
|
create procedure p1() select * from t1;
|
|
connection con2root;
|
|
unlock tables;
|
|
connection con1root;
|
|
s1
|
|
1
|
|
s1
|
|
1
|
|
drop procedure p1;
|
|
drop procedure p2;
|
|
drop table t1;
|
|
connection default;
|
|
disconnect con1root;
|
|
disconnect con2root;
|
|
disconnect con3root;
|