mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:31:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
57 lines
1.3 KiB
Text
57 lines
1.3 KiB
Text
source include/have_debug_sync.inc;
|
|
source include/not_embedded.inc;
|
|
|
|
--echo #
|
|
--echo # MDEV-20466: SHOW PROCESSLIST truncates query text on \0 bytes
|
|
--echo #
|
|
|
|
connect con1,localhost,root;
|
|
|
|
connection con1;
|
|
|
|
let $q= `select CONCAT("SELECT user FROM mysql.user WHERE user ='some", CHAR(0), "sleep'")`;
|
|
|
|
SET DEBUG_SYNC= 'before_join_optimize SIGNAL in_sync WAIT_FOR go';
|
|
--disable_query_log
|
|
--send_eval $q;
|
|
--enable_query_log
|
|
connection default;
|
|
|
|
SET DEBUG_SYNC= 'now WAIT_FOR in_sync';
|
|
|
|
exec $MYSQL test -e "SHOW PROCESSLIST" > $MYSQLTEST_VARDIR/tmp/MDEV-20466.text;
|
|
|
|
let SEARCH_FILE=$MYSQLTEST_VARDIR/tmp/MDEV-20466.text;
|
|
let SEARCH_PATTERN=sleep;
|
|
source include/search_pattern_in_file.inc;
|
|
remove_file $MYSQLTEST_VARDIR/tmp/MDEV-20466.text;
|
|
|
|
SET DEBUG_SYNC= 'now SIGNAL go';
|
|
|
|
connection con1;
|
|
reap;
|
|
disconnect con1;
|
|
connection default;
|
|
|
|
SET DEBUG_SYNC = 'RESET';
|
|
|
|
--echo #
|
|
--echo # End of 5.5 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # MDEV-23752: SHOW EXPLAIN FOR thd waits for sleep
|
|
--echo #
|
|
|
|
--connect con1,localhost,root
|
|
--let $con_id = `SELECT CONNECTION_ID()`
|
|
--send select sleep(100000)
|
|
|
|
--connection default
|
|
let $wait_condition= SELECT COUNT(*)=1 FROM information_schema.processlist where state='User sleep';
|
|
source include/wait_condition.inc;
|
|
evalp SHOW EXPLAIN FOR $con_id;
|
|
evalp KILL QUERY $con_id;
|
|
disconnect con1;
|
|
|
|
--echo # End of 10.2 tests
|