mirror of
https://github.com/MariaDB/server.git
synced 2025-08-08 11:31:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
95 lines
3.4 KiB
Text
95 lines
3.4 KiB
Text
#--disable_abort_on_error
|
|
#
|
|
# Test for the partition storage engine which require DEBUG_SYNC feature to
|
|
# Created by Mattias Jonsson
|
|
#
|
|
--source include/have_partition.inc
|
|
--source include/have_debug_sync.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_innodb.inc
|
|
|
|
SET DEBUG_SYNC= 'RESET';
|
|
|
|
--echo #
|
|
--echo # Bug#42438: Crash ha_partition::change_table_ptr
|
|
--echo # Test when remove partitioning is done while drop table is waiting
|
|
--echo # for the table.
|
|
--echo # After MDL was introduced, there is no longer any race, so test is done
|
|
--echo # by adding a small sleep to verify that the delete waits. This happens
|
|
--echo # only until ALTER tries to upgrade its MDL lock, which ends up in MDL
|
|
--echo # deadlock which is correctly reported.
|
|
connect(con1, localhost, root,,);
|
|
SET DEBUG_SYNC= 'RESET';
|
|
CREATE TABLE t1
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
/*!50100 PARTITION BY RANGE (a)
|
|
(PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE ) */;
|
|
SET DEBUG_SYNC= 'alter_table_before_create_table_no_lock SIGNAL removing_partitioning WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'mdl_acquire_lock_wait SIGNAL waiting_for_upgrade';
|
|
--send ALTER TABLE t1 REMOVE PARTITIONING
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitioning';
|
|
SET DEBUG_SYNC= 'mdl_acquire_lock_wait SIGNAL waiting_for_alter';
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table WAIT_FOR waiting_for_upgrade';
|
|
DROP TABLE IF EXISTS t1;
|
|
connection con1;
|
|
--error ER_LOCK_DEADLOCK
|
|
--reap
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
|
|
--echo #
|
|
--echo # Bug#42438: Crash ha_partition::change_table_ptr
|
|
--echo # Test when remove partitioning is failing due to drop table is already
|
|
--echo # in progress.
|
|
--echo # After MDL was introduced, there is no longer any race, so test is done
|
|
--echo # by adding a small sleep to verify that the alter waits.
|
|
CREATE TABLE t2
|
|
(a INTEGER,
|
|
b INTEGER NOT NULL,
|
|
KEY (b))
|
|
ENGINE = MYISAM
|
|
PARTITION BY RANGE (a) (PARTITION p0 VALUES LESS THAN (2),
|
|
PARTITION p1 VALUES LESS THAN (20),
|
|
PARTITION p2 VALUES LESS THAN (100),
|
|
PARTITION p3 VALUES LESS THAN MAXVALUE);
|
|
SET DEBUG_SYNC= 'alter_table_before_open_tables SIGNAL removing_partitions WAIT_FOR waiting_for_alter';
|
|
SET DEBUG_SYNC= 'alter_table_before_rename_result_table WAIT_FOR delete_done';
|
|
--send ALTER TABLE t2 REMOVE PARTITIONING
|
|
connection default;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR removing_partitions';
|
|
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_delete_table SIGNAL waiting_for_alter WAIT_FOR mtr_continue';
|
|
SET DEBUG_SYNC= 'rm_table_no_locks_before_binlog SIGNAL delete_done';
|
|
--send DROP TABLE IF EXISTS t2
|
|
|
|
--echo # Create a new connection thread to orchestrate the ALTER and DROP
|
|
--echo # threads' DEBUG_SYNC points to avoid lost signals
|
|
connect(con2,localhost,root,,);
|
|
let $wait_condition= select count(*)=0 from information_schema.processlist where state like "debug sync point: alter_table_before_open_tables";
|
|
source include/wait_condition.inc;
|
|
SET DEBUG_SYNC= 'now SIGNAL mtr_continue';
|
|
|
|
# Return execution for DROP TABLE
|
|
connection default;
|
|
--reap
|
|
|
|
# Return execution for ALTER TABLE
|
|
connection con1;
|
|
--error ER_NO_SUCH_TABLE
|
|
--reap
|
|
|
|
SET DEBUG_SYNC= 'RESET';
|
|
disconnect con1;
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
|
|
--echo # End of 5.1 tests
|