mirror of
https://github.com/MariaDB/server.git
synced 2025-08-09 03:51:36 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
112 lines
3.3 KiB
Text
112 lines
3.3 KiB
Text
--source include/not_embedded.inc
|
|
|
|
#
|
|
# test of into outfile|dumpfile
|
|
#
|
|
|
|
create table t1 (`a` blob);
|
|
insert into t1 values("hello world"),("Hello mars"),(NULL);
|
|
select * into outfile "../../tmp/outfile-test.1" from t1;
|
|
select load_file('../../tmp/outfile-test.1');
|
|
select * into dumpfile "../../tmp/outfile-test.2" from t1 limit 1;
|
|
select load_file('../../tmp/outfile-test.2');
|
|
select * into dumpfile "../../tmp/outfile-test.3" from t1 where a is null;
|
|
select load_file('../../tmp/outfile-test.3');
|
|
|
|
# the following should give errors
|
|
|
|
--error ER_FILE_EXISTS_ERROR
|
|
eval select * into outfile "../../tmp/outfile-test.1" from t1;
|
|
|
|
--error ER_FILE_EXISTS_ERROR
|
|
eval select * into dumpfile "../../tmp/outfile-test.2" from t1;
|
|
|
|
--error ER_FILE_EXISTS_ERROR
|
|
eval select * into dumpfile "../../tmp/outfile-test.3" from t1;
|
|
select load_file('../../tmp/outfile-test.not-exist');
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.1
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.2
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.3
|
|
drop table t1;
|
|
|
|
# Bug#8191 SELECT INTO OUTFILE insists on FROM clause
|
|
select 1 into outfile "../../tmp/outfile-test.4";
|
|
select load_file('../../tmp/outfile-test.4');
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.4
|
|
|
|
#
|
|
# Bug#5382 'explain select into outfile' crashes the server
|
|
#
|
|
|
|
CREATE TABLE t1 (a INT);
|
|
EXPLAIN
|
|
SELECT *
|
|
INTO OUTFILE '/tmp/t1.txt'
|
|
FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"' LINES TERMINATED BY '\r\n'
|
|
FROM t1;
|
|
DROP TABLE t1;
|
|
|
|
# End of 4.1 tests
|
|
|
|
#
|
|
# Bug#13202 SELECT * INTO OUTFILE ... FROM information_schema.schemata now fails
|
|
#
|
|
SELECT * INTO OUTFILE "../../tmp/outfile-test.4"
|
|
FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"'
|
|
FROM information_schema.schemata LIMIT 0, 5;
|
|
# enable_query_log;
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.4
|
|
|
|
use information_schema;
|
|
SELECT * INTO OUTFILE "../../tmp/outfile-test.4"
|
|
FIELDS TERMINATED BY ',' OPTIONALLY ENCLOSED BY '"'
|
|
FROM schemata LIMIT 0, 5;
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.4
|
|
use test;
|
|
|
|
#
|
|
# Bug#18628 mysql-test-run: security problem
|
|
#
|
|
# It should not be possible to write to a file outside of vardir
|
|
create table t1(a int);
|
|
--replace_result $MYSQL_TEST_DIR MYSQL_TEST_DIR
|
|
--error ER_OPTION_PREVENTS_STATEMENT
|
|
eval select * into outfile "$MYSQL_TEST_DIR/outfile-test1" from t1;
|
|
drop table t1;
|
|
|
|
#
|
|
# Bug#28181 Access denied to 'information_schema when
|
|
# select into out file (regression)
|
|
#
|
|
create database mysqltest;
|
|
create user user_1@localhost;
|
|
grant all on mysqltest.* to user_1@localhost;
|
|
connect (con28181_1,localhost,user_1,,mysqltest);
|
|
|
|
--error ER_ACCESS_DENIED_ERROR
|
|
select schema_name
|
|
into outfile "../../tmp/outfile-test.4"
|
|
fields terminated by ',' optionally enclosed by '"'
|
|
lines terminated by '\n'
|
|
from information_schema.schemata
|
|
where schema_name like 'mysqltest';
|
|
|
|
connection default;
|
|
disconnect con28181_1;
|
|
grant file on *.* to user_1@localhost;
|
|
|
|
connect (con28181_2,localhost,user_1,,mysqltest);
|
|
select schema_name
|
|
into outfile "../../tmp/outfile-test.4"
|
|
fields terminated by ',' optionally enclosed by '"'
|
|
lines terminated by '\n'
|
|
from information_schema.schemata
|
|
where schema_name like 'mysqltest';
|
|
|
|
connection default;
|
|
disconnect con28181_2;
|
|
--remove_file $MYSQLTEST_VARDIR/tmp/outfile-test.4
|
|
use test;
|
|
revoke all privileges on *.* from user_1@localhost;
|
|
drop user user_1@localhost;
|
|
drop database mysqltest;
|