mirror of
https://github.com/MariaDB/server.git
synced 2025-08-24 19:31:36 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
46 lines
1.5 KiB
Text
46 lines
1.5 KiB
Text
#
|
|
# Bug#41486 extra character appears in BLOB for every ~40Mb after
|
|
# mysqldump/import
|
|
#
|
|
# This test consumes a significant amount of resources.
|
|
# Therefore it should be kept separated from other tests.
|
|
# Otherwise we might suffer from problems like
|
|
# Bug#43801 mysql.test takes too long, fails due to expired timeout
|
|
# on debx86-b in PB
|
|
#
|
|
|
|
-- source include/not_embedded.inc
|
|
|
|
# Have to change the global variable as the session variable is
|
|
# read-only.
|
|
SET @old_max_allowed_packet= @@global.max_allowed_packet;
|
|
# 2 MB blob length + some space for the rest of INSERT query
|
|
SET @@global.max_allowed_packet = 2 * 1024 * 1024 + 1024;
|
|
|
|
# Create a new connection since the global max_allowed_packet
|
|
# has no effect for the current connection
|
|
connect (con1, localhost, root,,);
|
|
|
|
CREATE TABLE t1(data LONGBLOB);
|
|
INSERT INTO t1 SELECT REPEAT('1', 2*1024*1024);
|
|
# The following is to remove the race between end of insert and start of MYSQL_DUMP:
|
|
SELECT COUNT(*) FROM t1;
|
|
let $outfile= $MYSQLTEST_VARDIR/tmp/bug41486.sql;
|
|
--error 0,1
|
|
remove_file $outfile;
|
|
--exec $MYSQL_DUMP test t1 > $outfile
|
|
SET @old_general_log = @@global.general_log;
|
|
SET @@global.general_log = 0;
|
|
# Check that the mysql client does not insert extra newlines when loading
|
|
# strings longer than client's max_allowed_packet
|
|
--exec $MYSQL --max_allowed_packet=1M test < $outfile 2>&1
|
|
SET @@global.general_log = @old_general_log;
|
|
SELECT LENGTH(data) FROM t1;
|
|
|
|
DROP TABLE t1;
|
|
|
|
# Cleanup
|
|
disconnect con1;
|
|
remove_file $outfile;
|
|
connection default;
|
|
SET @@global.max_allowed_packet = @old_max_allowed_packet;
|