mirror of
https://github.com/MariaDB/server.git
synced 2025-08-14 14:31:32 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
141 lines
2.8 KiB
Text
141 lines
2.8 KiB
Text
#
|
|
# Bug#38691 segfault/abort in ``UPDATE ...JOIN'' while
|
|
# ``FLUSH TABLES WITH READ LOCK''
|
|
# MySQL >= 5.0
|
|
#
|
|
|
|
# The test can take hours with valgrind
|
|
--source include/not_valgrind.inc
|
|
|
|
SET @odl_sync_frm = @@global.sync_frm;
|
|
SET @@global.sync_frm = OFF;
|
|
|
|
# Test to see if select will get the lock ahead of low priority update
|
|
|
|
connect (locker,localhost,root,,);
|
|
connect (writer,localhost,root,,);
|
|
|
|
--connection default
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1,t2,t3;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1 (
|
|
a int(11) unsigned default NULL,
|
|
b varchar(250) default NULL,
|
|
UNIQUE KEY a (a),
|
|
KEY b (b)
|
|
);
|
|
|
|
INSERT INTO t1 VALUES (1, 1), (2, 2), (3, 3);
|
|
CREATE TABLE t2 SELECT * FROM t1;
|
|
CREATE TABLE t3 SELECT * FROM t1;
|
|
|
|
--echo # test altering of columns that multiupdate doesn't use
|
|
|
|
--echo # normal mode
|
|
|
|
--disable_query_log
|
|
let $i = 100;
|
|
while ($i) {
|
|
--dec $i
|
|
|
|
--connection writer
|
|
send UPDATE t2 INNER JOIN (t1 JOIN t3 USING(a)) USING(a)
|
|
SET a = NULL WHERE t1.b <> t2.b;
|
|
|
|
--connection locker
|
|
ALTER TABLE t2 ADD COLUMN (c INT), LOCK=SHARED;
|
|
ALTER TABLE t2 DROP COLUMN c, LOCK=SHARED;
|
|
|
|
--connection writer
|
|
--reap
|
|
}
|
|
|
|
--echo # PS mode
|
|
|
|
--connection writer
|
|
PREPARE stmt FROM 'UPDATE t2 INNER JOIN (t1 JOIN t3 USING(a)) USING(a)
|
|
SET a = NULL WHERE t1.b <> t2.b';
|
|
|
|
let $i = 100;
|
|
while ($i) {
|
|
--dec $i
|
|
|
|
--connection writer
|
|
--send EXECUTE stmt
|
|
|
|
--connection locker
|
|
ALTER TABLE t2 ADD COLUMN (c INT), LOCK=SHARED;
|
|
ALTER TABLE t2 DROP COLUMN c, LOCK=SHARED;
|
|
|
|
--connection writer
|
|
--reap
|
|
}
|
|
--enable_query_log
|
|
|
|
|
|
--echo # test altering of columns that multiupdate uses
|
|
|
|
--echo # normal mode
|
|
|
|
--connection default
|
|
|
|
--disable_query_log
|
|
let $i = 100;
|
|
while ($i) {
|
|
dec $i;
|
|
|
|
--connection locker
|
|
--error 0,ER_DUP_FIELDNAME
|
|
ALTER TABLE t2 ADD COLUMN a int(11) unsigned default NULL, LOCK=SHARED;
|
|
UPDATE t2 SET a=b;
|
|
|
|
--connection writer
|
|
--send UPDATE t2 INNER JOIN (t1 JOIN t3 USING(a)) USING(a) SET a = NULL WHERE t1.b <> t2.b
|
|
|
|
--connection locker
|
|
--error 0,ER_CANT_DROP_FIELD_OR_KEY
|
|
ALTER TABLE t2 DROP COLUMN a, LOCK=SHARED;
|
|
|
|
--connection writer
|
|
--error 0,ER_BAD_FIELD_ERROR
|
|
--reap
|
|
}
|
|
--enable_query_log
|
|
|
|
--echo # PS mode
|
|
|
|
--disable_query_log
|
|
let $i = 100;
|
|
while ($i) {
|
|
dec $i;
|
|
|
|
--connection locker
|
|
--error 0,ER_DUP_FIELDNAME
|
|
ALTER TABLE t2 ADD COLUMN a int(11) unsigned default NULL, LOCK=SHARED;
|
|
UPDATE t2 SET a=b;
|
|
|
|
--connection writer
|
|
PREPARE stmt FROM 'UPDATE t2 INNER JOIN (t1 JOIN t3 USING(a)) USING(a) SET a = NULL WHERE t1.b <> t2.b';
|
|
--send EXECUTE stmt
|
|
|
|
--connection locker
|
|
--error 0,ER_CANT_DROP_FIELD_OR_KEY
|
|
ALTER TABLE t2 DROP COLUMN a, LOCK=SHARED;
|
|
|
|
--connection writer
|
|
--error 0,ER_BAD_FIELD_ERROR
|
|
--reap
|
|
|
|
}
|
|
--enable_query_log
|
|
--connection default
|
|
DROP TABLE t1, t2, t3;
|
|
|
|
|
|
# Close connections
|
|
--disconnect locker
|
|
--disconnect writer
|
|
|
|
SET @@global.sync_frm = @odl_sync_frm;
|