mirror of
https://github.com/MariaDB/server.git
synced 2025-08-11 04:51:37 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
171 lines
4.4 KiB
Text
171 lines
4.4 KiB
Text
set @old_innodb_lock_wait_timeout=@@global.innodb_lock_wait_timeout;
|
|
set global innodb_lock_wait_timeout=300;
|
|
set session innodb_lock_wait_timeout=300;
|
|
call mtr.add_suppression("Deadlock found when trying to get lock; try restarting transaction");
|
|
#
|
|
# Bug #22876 Four-way deadlock
|
|
#
|
|
connect con1,localhost,root,,;
|
|
connect con2,localhost,root,,;
|
|
connect con3,localhost,root,,;
|
|
connection con1;
|
|
set @@autocommit=0;
|
|
CREATE TABLE t1(s1 INT UNIQUE) ENGINE=innodb;
|
|
INSERT INTO t1 VALUES (100);
|
|
COMMIT;
|
|
INSERT INTO t1 VALUES (1);
|
|
connection con2;
|
|
set @@autocommit=0;
|
|
INSERT INTO t1 VALUES (2);
|
|
INSERT INTO t1 VALUES (1);
|
|
connection con3;
|
|
set @@autocommit=0;
|
|
DROP TABLE t1;
|
|
connection con1;
|
|
# Waiting for until transaction will be locked inside innodb subsystem
|
|
# Connection 1 is now holding the lock.
|
|
# Issuing insert from connection 1 while connection 2&3
|
|
# is waiting for the lock should give a deadlock error.
|
|
INSERT INTO t1 VALUES (2);
|
|
ERROR 40001: Deadlock found when trying to get lock; try restarting transaction
|
|
# Cleanup
|
|
connection con2;
|
|
commit;
|
|
set @@autocommit=1;
|
|
connection con1;
|
|
commit;
|
|
set @@autocommit=1;
|
|
connection con3;
|
|
set @@autocommit=1;
|
|
connection default;
|
|
disconnect con1;
|
|
disconnect con2;
|
|
disconnect con3;
|
|
#
|
|
# Test for bug #37346 "innodb does not detect deadlock between update
|
|
# and alter table".
|
|
#
|
|
drop table if exists t1;
|
|
create table t1 (c1 int primary key, c2 int, c3 int) engine=InnoDB;
|
|
insert into t1 values (1,1,0),(2,2,0),(3,3,0),(4,4,0),(5,5,0);
|
|
begin;
|
|
# Run statement which acquires X-lock on one of table's rows.
|
|
update t1 set c3=c3+1 where c2=3;
|
|
#
|
|
connect con37346,localhost,root,,test,,;
|
|
connection con37346;
|
|
# The below ALTER TABLE statement should wait till transaction
|
|
# in connection 'default' is complete and then succeed.
|
|
# It should not deadlock or fail with ER_LOCK_DEADLOCK error.
|
|
# Sending:
|
|
alter table t1 add column c4 int;;
|
|
#
|
|
connection default;
|
|
# Wait until the above ALTER TABLE gets blocked because this
|
|
# connection holds SW metadata lock on table to be altered.
|
|
# The below statement should succeed. It should not
|
|
# deadlock or end with ER_LOCK_DEADLOCK error.
|
|
update t1 set c3=c3+1 where c2=4;
|
|
# Unblock ALTER TABLE by committing transaction.
|
|
commit;
|
|
#
|
|
connection con37346;
|
|
# Reaping ALTER TABLE.
|
|
#
|
|
connection default;
|
|
disconnect con37346;
|
|
drop table t1;
|
|
#
|
|
# Bug#53798 OPTIMIZE TABLE breaks repeatable read
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
CREATE TABLE t1 (a INT) engine=innodb;
|
|
INSERT INTO t1 VALUES (1), (2), (3);
|
|
connect con1, localhost, root;
|
|
START TRANSACTION WITH CONSISTENT SNAPSHOT;
|
|
SELECT * FROM t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
connection default;
|
|
# This should block
|
|
# Sending:
|
|
OPTIMIZE TABLE t1;
|
|
connection con1;
|
|
SELECT * FROM t1;
|
|
a
|
|
1
|
|
2
|
|
3
|
|
COMMIT;
|
|
connection default;
|
|
# Reaping OPTIMIZE TABLE t1
|
|
Table Op Msg_type Msg_text
|
|
test.t1 optimize note Table does not support optimize, doing recreate + analyze instead
|
|
test.t1 optimize status OK
|
|
disconnect con1;
|
|
DROP TABLE t1;
|
|
#
|
|
# Bug#49891 View DDL breaks REPEATABLE READ
|
|
#
|
|
DROP TABLE IF EXISTS t1, t2;
|
|
DROP VIEW IF EXISTS v2;
|
|
CREATE TABLE t1 ( f1 INTEGER ) ENGINE = innodb;
|
|
CREATE TABLE t2 ( f1 INTEGER );
|
|
CREATE VIEW v1 AS SELECT 1 FROM t1;
|
|
connect con2, localhost, root;
|
|
connect con3, localhost, root;
|
|
connection con3;
|
|
LOCK TABLE t1 WRITE;
|
|
connection default;
|
|
START TRANSACTION;
|
|
# Sending:
|
|
SELECT * FROM v1;
|
|
connection con2;
|
|
# Waiting for 'SELECT * FROM v1' to sync in.
|
|
# Sending:
|
|
ALTER VIEW v1 AS SELECT 2 FROM t2;
|
|
connection con3;
|
|
# Waiting for 'ALTER VIEW v1 AS SELECT 2 FROM t2' to sync in.
|
|
UNLOCK TABLES;
|
|
connection default;
|
|
# Reaping: SELECT * FROM v1
|
|
1
|
|
SELECT * FROM v1;
|
|
1
|
|
COMMIT;
|
|
connection con2;
|
|
# Reaping: ALTER VIEW v1 AS SELECT 2 FROM t2
|
|
connection default;
|
|
DROP TABLE t1, t2;
|
|
DROP VIEW v1;
|
|
disconnect con2;
|
|
disconnect con3;
|
|
#
|
|
# Bug#11815600 [ERROR] INNODB COULD NOT FIND INDEX PRIMARY
|
|
# KEY NO 0 FOR TABLE IN ERROR LOG
|
|
#
|
|
DROP TABLE IF EXISTS t1;
|
|
connect con1,localhost,root;
|
|
connection default;
|
|
CREATE TABLE t1 (id INT PRIMARY KEY, value INT) ENGINE = InnoDB;
|
|
INSERT INTO t1 VALUES (1, 12345);
|
|
START TRANSACTION;
|
|
SELECT * FROM t1;
|
|
id value
|
|
1 12345
|
|
connection con1;
|
|
SET lock_wait_timeout=1;
|
|
ALTER TABLE t1 ADD INDEX idx(value);
|
|
ERROR HY000: Lock wait timeout exceeded; try restarting transaction
|
|
ALTER TABLE t1 ADD INDEX idx(value);
|
|
ERROR HY000: Lock wait timeout exceeded; try restarting transaction
|
|
connection default;
|
|
SELECT * FROM t1;
|
|
id value
|
|
1 12345
|
|
COMMIT;
|
|
DROP TABLE t1;
|
|
disconnect con1;
|
|
set global innodb_lock_wait_timeout=@old_innodb_lock_wait_timeout;
|