mariadb/sql/datadict.cc
Aleksey Midenkov a518e1dd42 MDEV-20865 Store foreign key info in TABLE_SHARE
1. Access foreign keys via TABLE_SHARE::foreign_keys and
   TABLE_SHARE::referenced_keys;

   foreign_keys and referenced_keys are lists in TABLE_SHARE.

2. Remove handler FK interface:

   - get_foreign_key_list()
   - get_parent_foreign_key_list()
   - referenced_by_foreign_key()

3. Invalidate referenced shares on:

   - RENAME TABLE
   - DROP TABLE
   - RENAME COLUMN
   - ADD FOREIGN KEY

   When foreign table is created or altered by the above operations
   all referenced shares are closed. This blocks the operation while
   any referenced shares are used (when at least one its TABLE
   instance is locked).

4. Update referenced shares on:

   - CREATE TABLE

   On CREATE TABLE add items to referenced_keys of referenced
   shares. States of referenced shares are restored in case of errors.

5. Invalidate foreign shares on:

   - RENAME TABLE
   - RENAME COLUMN

   The above-mentioned blocking takes effect.

6. Check foreign/referenced shares consistency on:

   - CHECK TABLE

7. Temporary change until MDEV-21051:

   InnoDB fill foreign key info at handler open().

FOREIGN_KEY_INFO is refactored to FK_info holding Lex_cstring.

On first TABLE open FK_info is loaded from storage engine into
TABLE_SHARE. All referenced shares (if any exists) are closed. This
leads to blocking of first time foreign table open while referenced
tables are used.

MDEV-21311 Converge Foreign_key and supplemental generated Key together

mysql_prepare_create_table() does data validation and such utilities
as automatic name generation. But it does that only for indexes and
ignores Foreign_key objects. Now as Foreign_key data needs to be
stored in FRM files as well this processing must be done for it like
for any other Key objects.

Replace Key::FOREIGN_KEY type with Key::foreign flag of type
Key::MULTIPLE and Key::generated set to true. Construct one object
with Key::foreign == true instead of two objects of type
Key::FOREIGN_KEY and Key::MULTIPLE.

MDEV-21051 datadict refactorings

- Move read_extra2() to datadict.cc
- Refactored extra2_fields to Extra2_info
- build_frm_image() readability

MDEV-21051 build_table_shadow_filename() refactoring

mysql_prepare_alter_table() leaks fixes

MDEV-21051 amend system tables locking restriction

Table mysql.help_relation has foreign key to mysql.help_keyword. On
bootstrap when help_relation is opened, it preopens help_keyword for
READ and fails in lock_tables_check().

If system table is opened for write then fk references are opened for
write.

Related to: Bug#25422, WL#3984
Tests: main.lock

MDEV-21051 Store and read foreign key info into/from FRM files

1. Introduce Foreign_key_io class which creates/parses binary stream
containing foreign key structures. Referenced tables store there only
hints about foreign tables (their db and name), they restore full info
from the corresponding tables.

Foreign_key_io is stored under new EXTRA2_FOREIGN_KEY_INFO field in
extra2 section of FRM file.

2. Modify mysql_prepare_create_table() to generate names for foreign
keys. Until InnoDB storage of foreign keys is removed, FK names must
be unique across the database: the FK name must be based on table
name.

3. Keep stored data in sync on DDL changes. Referenced tables update
their foreign hints after following operations on foreign tables:

  - RENAME TABLE
  - DROP TABLE
  - CREATE TABLE
  - ADD FOREIGN KEY
  - DROP FOREIGN KEY

Foreign tables update their foreign info after following operations on
referenced tables:

  - RENAME TABLE
  - RENAME COLUMN

4. To achieve 3. there must be ability to rewrite extra2 section of
FRM file without full reparse. FRM binary is built from primary
structures like HA_CREATE_INFO and cannot be built from TABLE_SHARE.

Use shadow write and rename like fast_alter_partition_table()
does. Shadow FRM is new FRM file that replaces the old one.

CREATE TABLE workflow:

  1. Foreign_key is constructed in parser, placed into
     alter_info->key_list;

  2. mysql_prepare_create_table() translates them to FK_info, assigns
     foreign_id if needed;

  3. build_frm_image() writes two FK_info lists into FRM's extra2
     section, for referenced keys it stores only table names (hints);

  4. init_from_binary_frm_image() parses extra2 section and fills
     foreign_keys and referenced_keys of TABLE_SHARE.

     It restores referenced_keys by reading hint list of table names,
     opening corresponding shares and restoring FK_info from their
     foreign_keys. Hints resolution is done only when initializing
     non-temporary shares. Usually temporary share has different
     (temporary) name and it is impossible to resolve foreign keys by
     that name (as we identify them by both foreign and referenced
     table names). Another not unimportant reason is performance: this
     saves spare share acquisitions.

ALTER TABLE workflow:

  1. Foreign_key is constructed in parser, placed into
     alter_info->key_list;

  2. mysql_prepare_alter_table() prepares action lists and share list
     of foreigns/references;

  3. mysql_prepare_alter_table() locks list of foreigns/references by
     MDL_INTENTION_EXCLUSIVE, acquires shares;

  4. prepare_create_table() converts key_list into FK_list, assigns
     foreign_id;

  5. shadow FRM of altered table is created;

  6. data is copied;

  7. altered table is locked by MDL_EXCLUSIVE;

  8. fk_handle_alter() processes action lists, creates FK backups,
     modifies shares, writes shadow FRMs;

  9. altered table is closed;

  10. shadow FRMs are installed;

  11. altered table is renamed, FRM backup deleted;

  12. (TBD in MDEV-21053) shadow FRMs installation log closed, backups
      deleted;

On FK backup system:

In case of failed DDL operation all shares that was modified must be
restored into original state. This is done by FK_ddl_backup (CREATE,
DROP), FK_rename_backup (RENAME), FK_alter_backup (ALTER).

On STL usage:

STL is used for utility not performance-critical algorithms, core
structures hold native List. A wrapper was made to convert STL
exception into bool error status or NULL value.

MDEV-20865 fk_check_consistency() in CHECK TABLE

Self-refs fix

Test table_flags fix: "debug" deviation is now gone.

FIXMEs: +16 -1
2025-09-02 13:24:36 +03:00

503 lines
15 KiB
C++

/* Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2017, 2022, MariaDB corporation.
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1335 USA */
#include "mariadb.h"
#include "datadict.h"
#include "sql_priv.h"
#include "sql_class.h"
#include "sql_table.h"
#include "ha_sequence.h"
#include "discover.h"
static int read_string(File file, uchar**to, size_t length)
{
DBUG_ENTER("read_string");
/* This can't use MY_THREAD_SPECIFIC as it's used on server start */
if (!(*to= (uchar*) my_malloc(PSI_INSTRUMENT_ME, length+1,MYF(MY_WME))) ||
mysql_file_read(file, *to, length, MYF(MY_NABP)))
{
my_free(*to);
*to= 0;
DBUG_RETURN(1);
}
*((char*) *to+length)= '\0'; // C-style safety
DBUG_RETURN (0);
}
/**
Check type of .frm if we are not going to parse it.
@param[in] thd The current session.
@param[in] path path to FRM file.
@param[in/out] engine_name table engine name (length < NAME_CHAR_LEN)
engine_name is a LEX_CSTRING, where engine_name->str must point to
a buffer of at least NAME_CHAR_LEN+1 bytes.
If engine_name is 0, then the function will only test if the file is a
view or not
@retval TABLE_TYPE_UNKNOWN error - file can't be opened
@retval TABLE_TYPE_NORMAL table
@retval TABLE_TYPE_SEQUENCE sequence table
@retval TABLE_TYPE_VIEW view
*/
Table_type dd_frm_type(THD *thd, char *path, LEX_CSTRING *engine_name,
LEX_CUSTRING *table_version)
{
File file;
uchar header[64+ MY_UUID_SIZE + 2]; // Header and uuid
size_t error;
Table_type type= TABLE_TYPE_UNKNOWN;
uchar dbt;
DBUG_ENTER("dd_frm_type");
file= mysql_file_open(key_file_frm, path, O_RDONLY | O_SHARE, MYF(0));
if (file < 0)
DBUG_RETURN(TABLE_TYPE_UNKNOWN);
/*
We return TABLE_TYPE_NORMAL if we can open the .frm file. This allows us
to drop a bad .frm file with DROP TABLE
*/
type= TABLE_TYPE_NORMAL;
/*
Initialize engine name in case we are not able to find it out
The cast is safe, as engine_name->str points to a usable buffer.
*/
if (engine_name)
{
engine_name->length= 0;
((char*) (engine_name->str))[0]= 0;
}
if (table_version)
{
table_version->length= 0;
table_version->str= 0; // Allocated if needed
}
if (unlikely((error= mysql_file_read(file, (uchar*) header, sizeof(header),
MYF(MY_NABP)))))
goto err;
if (unlikely((!strncmp((char*) header, "TYPE=VIEW\n", 10))))
{
type= TABLE_TYPE_VIEW;
goto err;
}
if (!is_binary_frm_header(header))
goto err;
dbt= header[3];
if ((header[39] & 0x30) == (HA_CHOICE_YES << 4))
{
DBUG_PRINT("info", ("Sequence found"));
type= TABLE_TYPE_SEQUENCE;
}
if (table_version)
{
/* Read the table version (if it is a 'new' frm file) */
if (header[64] == EXTRA2_TABLEDEF_VERSION && header[65] == MY_UUID_SIZE)
if ((table_version->str= (uchar*) thd->memdup(header + 66, MY_UUID_SIZE)))
table_version->length= MY_UUID_SIZE;
}
/* cannot use ha_resolve_by_legacy_type without a THD */
if (thd && dbt < DB_TYPE_FIRST_DYNAMIC)
{
handlerton *ht= ha_resolve_by_legacy_type(thd, (legacy_db_type) dbt);
if (ht)
{
if (engine_name)
*engine_name= hton2plugin[ht->slot]->name;
goto err;
}
}
/* read the true engine name */
if (engine_name)
{
MY_STAT state;
uchar *frm_image= 0;
uint n_length;
if (mysql_file_fstat(file, &state, MYF(MY_WME)))
goto err;
if (mysql_file_seek(file, 0, SEEK_SET, MYF(MY_WME)))
goto err;
if (read_string(file, &frm_image, (size_t)state.st_size))
goto err;
/* The test for !engine_name->length is only true for partition engine */
if (!engine_name->length && (n_length= uint4korr(frm_image+55)))
{
uint record_offset= uint2korr(frm_image+6)+
((uint2korr(frm_image+14) == 0xffff ?
uint4korr(frm_image+47) : uint2korr(frm_image+14)));
uint reclength= uint2korr(frm_image+16);
uchar *next_chunk= frm_image + record_offset + reclength;
uchar *buff_end= next_chunk + n_length;
uint connect_string_length= uint2korr(next_chunk);
next_chunk+= connect_string_length + 2;
if (next_chunk + 2 < buff_end)
{
uint len= uint2korr(next_chunk);
if (len <= NAME_CHAR_LEN)
{
/*
The following cast is safe as the caller has allocated buffer
and it's up to this function to generate the name.
*/
strmake((char*) engine_name->str, (char*)next_chunk + 2,
engine_name->length= len);
}
}
}
my_free(frm_image);
}
/* Probably a table. */
err:
mysql_file_close(file, MYF(MY_WME));
DBUG_RETURN(type);
}
/*
Regenerate a metadata locked table.
@param thd Thread context.
@param db Name of the database to which the table belongs to.
@param name Table name.
@retval FALSE Success.
@retval TRUE Error.
*/
bool dd_recreate_table(THD *thd, const char *db, const char *table_name)
{
HA_CREATE_INFO create_info;
char path_buf[FN_REFLEN + 1];
DBUG_ENTER("dd_recreate_table");
/* There should be a exclusive metadata lock on the table. */
DBUG_ASSERT(thd->mdl_context.is_lock_owner(MDL_key::TABLE, db, table_name,
MDL_EXCLUSIVE));
create_info.init();
build_table_filename(path_buf, sizeof(path_buf) - 1,
db, table_name, "", 0);
/* Attempt to reconstruct the table. */
DBUG_RETURN(ha_create_table(thd, path_buf, db, table_name, &create_info, NULL,
false, false));
}
bool Extra2_info::read(const uchar *frm_image, size_t frm_size)
{
read_size= uint2korr(frm_image + 4);
if (frm_size < FRM_HEADER_SIZE + read_size)
return true;
const uchar *pos= frm_image + 64;
DBUG_ENTER("Extra2_info::read");
if (*pos == '/') // old frm had '/' there
DBUG_RETURN(false);
const uchar *e2end= pos + read_size;
while (pos + 3 <= e2end)
{
extra2_frm_value_type type= (extra2_frm_value_type)*pos++;
size_t length= extra2_read_len(&pos, e2end);
if (!length)
DBUG_RETURN(true);
bool fail= false;
switch (type) {
case EXTRA2_TABLEDEF_VERSION:
if (version.str) // see init_from_sql_statement_string()
{
if (length != version.length)
DBUG_RETURN(true);
}
else
{
version.str= pos;
version.length= length;
}
break;
case EXTRA2_ENGINE_TABLEOPTS:
fail= read_once(&options, pos, length);
break;
case EXTRA2_DEFAULT_PART_ENGINE:
engine.set((const char*)pos, length);
break;
case EXTRA2_GIS:
fail= read_once(&gis, pos, length);
break;
case EXTRA2_PERIOD_FOR_SYSTEM_TIME:
fail= read_once(&system_period, pos, length)
|| length != 2 * frm_fieldno_size;
break;
case EXTRA2_FIELD_FLAGS:
fail= read_once(&field_flags, pos, length);
break;
case EXTRA2_APPLICATION_TIME_PERIOD:
fail= read_once(&application_period, pos, length);
break;
case EXTRA2_FIELD_DATA_TYPE_INFO:
fail= read_once(&field_data_type_info, pos, length);
break;
case EXTRA2_PERIOD_WITHOUT_OVERLAPS:
fail= read_once(&without_overlaps, pos, length);
break;
case EXTRA2_INDEX_FLAGS:
fail= read_once(&index_flags, pos, length);
break;
case EXTRA2_FOREIGN_KEY_INFO:
fail= read_once(&foreign_key_info, pos, length);
break;
default:
/* abort frm parsing if it's an unknown but important extra2 value */
if (type >= EXTRA2_ENGINE_IMPORTANT)
DBUG_RETURN(true);
}
if (fail)
DBUG_RETURN(true);
pos+= length;
}
if (pos != e2end)
DBUG_RETURN(true);
DBUG_ASSERT(store_size() == read_size);
DBUG_RETURN(false);
}
uchar *
Extra2_info::write(uchar *frm_image)
{
uchar *pos;
/* write the extra2 segment */
pos = frm_image + FRM_HEADER_SIZE;
compile_time_assert(EXTRA2_TABLEDEF_VERSION != '/');
if (version.str)
pos= extra2_write(pos, EXTRA2_TABLEDEF_VERSION, version);
if (engine.str)
pos= extra2_write(pos, EXTRA2_DEFAULT_PART_ENGINE, engine);
if (options.str)
pos= extra2_write(pos, EXTRA2_ENGINE_TABLEOPTS, options);
if (gis.str)
pos= extra2_write(pos, EXTRA2_GIS, gis);
if (field_data_type_info.str)
pos= extra2_write(pos, EXTRA2_FIELD_DATA_TYPE_INFO, field_data_type_info);
if (index_flags.str)
pos= extra2_write(pos, EXTRA2_INDEX_FLAGS, index_flags);
if (foreign_key_info.str)
pos= extra2_write(pos, EXTRA2_FOREIGN_KEY_INFO, foreign_key_info);
if (system_period.str)
pos= extra2_write(pos, EXTRA2_PERIOD_FOR_SYSTEM_TIME, system_period);
if (application_period.str)
pos= extra2_write(pos, EXTRA2_APPLICATION_TIME_PERIOD, application_period);
if (without_overlaps.str)
pos= extra2_write(pos, EXTRA2_PERIOD_WITHOUT_OVERLAPS, without_overlaps);
if (field_flags.str)
pos= extra2_write(pos, EXTRA2_FIELD_FLAGS, field_flags);
write_size= pos - frm_image - FRM_HEADER_SIZE;
DBUG_ASSERT(write_size == store_size());
DBUG_ASSERT(write_size <= 0xffff - FRM_HEADER_SIZE - 4);
return pos;
}
int TABLE_SHARE::fk_write_shadow_frm(THD *thd)
{
const uchar * frm_src;
uchar * frm_dst;
uchar * pos;
size_t frm_size;
Extra2_info extra2;
Foreign_key_io foreign_key_io(this);
int err= read_frm_image(&frm_src, &frm_size);
if (err)
{
char path[FN_REFLEN + 1];
strxmov(path, normalized_path.str, reg_ext, NullS);
switch (err)
{
case 1:
my_error(ER_CANT_OPEN_FILE, MYF(0), path, my_errno);
break;
case 2:
my_error(ER_FILE_NOT_FOUND, MYF(0), path, my_errno);
break;
default:
my_error(ER_OUT_OF_RESOURCES, MYF(0));
break;
}
return err;
}
Scope_malloc frm_src_freer(frm_src); // read_frm_image() passed ownership to us
if (frm_size < FRM_HEADER_SIZE + FRM_FORMINFO_SIZE)
{
frm_err:
char path[FN_REFLEN + 1];
strxmov(path, normalized_path.str, reg_ext, NullS);
my_error(ER_NOT_FORM_FILE, MYF(0), path);
return 10;
}
if (!is_binary_frm_header(frm_src))
goto frm_err;
if (extra2.read(frm_src, frm_size))
{
my_printf_error(ER_CANT_CREATE_TABLE,
"Cannot create table %sQ: "
"Read of extra2 section failed.",
MYF(0), table_name.str);
return 10;
}
const uchar * const rest_src= frm_src + FRM_HEADER_SIZE + extra2.read_size;
const size_t rest_size= frm_size - FRM_HEADER_SIZE - extra2.read_size;
size_t forminfo_off= uint4korr(rest_src);
foreign_key_io.store(thd, foreign_keys, referenced_keys);
extra2.foreign_key_info= foreign_key_io.lex_custring();
if (!extra2.foreign_key_info.length)
extra2.foreign_key_info.str= NULL;
else if (extra2.foreign_key_info.length > 0xffff - FRM_HEADER_SIZE - 8)
{
my_printf_error(ER_CANT_CREATE_TABLE,
"Cannot create table %sQ: "
"Building the foreign key info image failed.",
MYF(0), table_name.str);
return 10;
}
const longlong extra2_delta= extra2.store_size() - extra2.read_size;
frm_size+= extra2_delta;
if (frm_size > FRM_MAX_SIZE)
{
my_error(ER_TABLE_DEFINITION_TOO_BIG, MYF(0), table_name.str);
return 10;
}
Scope_malloc frm_dst_freer(frm_dst, frm_size, MY_WME);
if (!frm_dst)
return 10;
memcpy((void *)frm_dst, (void *)frm_src, FRM_HEADER_SIZE);
if (!(pos= extra2.write(frm_dst)))
{
my_printf_error(ER_CANT_CREATE_TABLE,
"Cannot create table %sQ: "
"Write of extra2 section failed.",
MYF(0), table_name.str);
return 10;
}
forminfo_off+= extra2_delta;
int4store(pos, forminfo_off);
pos+= 4;
int2store(frm_dst + 4, extra2.write_size);
int2store(frm_dst + 6, FRM_HEADER_SIZE + extra2.write_size + 4); // Position to key information
int4store(frm_dst + 10, frm_size);
memcpy((void *)pos, rest_src + 4, rest_size - 4);
char shadow_path[FN_REFLEN + 1];
char shadow_frm_name[FN_REFLEN + 1];
build_table_shadow_filename(thd, shadow_path, sizeof(shadow_path) - 1,
db.str, table_name.str);
strxnmov(shadow_frm_name, sizeof(shadow_frm_name), shadow_path, reg_ext, NullS);
if (writefile(shadow_frm_name, db.str, table_name.str, false, frm_dst, frm_size))
return 10;
return 0;
}
bool fk_install_shadow_frm(THD *thd, Table_name old_name, Table_name new_name)
{
char shadow_path[FN_REFLEN + 1];
char path[FN_REFLEN];
char shadow_frm_name[FN_REFLEN + 1];
char frm_name[FN_REFLEN + 1];
MY_STAT stat_info;
build_table_shadow_filename(thd, shadow_path, sizeof(shadow_path) - 1,
old_name.db.str, old_name.name.str);
build_table_filename(path, sizeof(path), new_name.db.str,
new_name.name.str, "", 0);
strxnmov(shadow_frm_name, sizeof(shadow_frm_name), shadow_path, reg_ext, NullS);
strxnmov(frm_name, sizeof(frm_name), path, reg_ext, NullS);
if (!mysql_file_stat(key_file_frm, shadow_frm_name, &stat_info, MYF(MY_WME)))
return true;
if (mysql_file_delete(key_file_frm, frm_name, MYF(MY_WME)))
return true;
if (mysql_file_rename(key_file_frm, shadow_frm_name, frm_name, MYF(MY_WME)))
return true;
return false;
}
bool TABLE_SHARE::fk_install_shadow_frm(THD *thd)
{
return ::fk_install_shadow_frm(thd, {db, table_name}, {db, table_name});
}
void fk_drop_shadow_frm(THD *thd, Table_name table)
{
char shadow_path[FN_REFLEN+1];
char shadow_frm_name[FN_REFLEN+1];
build_table_shadow_filename(thd, shadow_path, sizeof(shadow_path) - 1,
table.db.str, table.name.str);
strxnmov(shadow_frm_name, sizeof(shadow_frm_name), shadow_path, reg_ext, NullS);
mysql_file_delete(key_file_frm, shadow_frm_name, MYF(0));
}
void TABLE_SHARE::fk_drop_shadow_frm(THD *thd)
{
::fk_drop_shadow_frm(thd, {db, table_name});
}