mirror of
https://github.com/MariaDB/server.git
synced 2025-10-24 16:38:14 +02:00
PURGE BINARY LOGS did not always purge binary logs. This commit fixes
some of the issues and adds notifications if a binary log cannot be
purged.
User visible changes:
- 'PURGE BINARY LOG TO log_name' and 'PURGE BINARY LOGS BEFORE date'
worked differently. 'TO' ignored 'slave_connections_needed_for_purge'
while 'BEFORE' did not. Now both versions ignores the
'slave_connections_needed_for_purge variable'.
- 'PURGE BINARY LOG..' commands now returns 'note' if a binary log cannot
be deleted like
Note 1375 Binary log 'master-bin.000004' is not purged because it is
the current active binlog
- Automatic binary log purges, based on date or size, will write a
note to the error log if a binary log matching the size or date
cannot yet be deleted.
- If 'slave_connections_needed_for_purge' is set from a config or
command line, it is set to 0 if Galera is enabled and 1 otherwise
(old default). This ensures that automatic binary log purge works
with Galera as before the addition of
'slave_connections_needed_for_purge'.
If the variable is changed to 0, a warning will be printed to the error
log.
Code changes:
- Added THD argument to several purge_logs related functions that needed
THD.
- Added 'interactive' options to purge_logs functions. This allowed
me to remove testing of sql_command == SQLCOM_PURGE.
- Changed purge_logs_before_date() to first check if log is applicable
before calling can_purge_logs(). This ensures we do not get a
notification for logs that does not match the remove criteria.
- MYSQL_BIN_LOG::can_purge_log() will write notifications to the user
or error log if a log cannot yet be removed.
- log_in_use() will return reason why a binary log cannot be removed.
Changes to keep code consistent:
- Moved checking of binlog_format for Galera to be after Galera is
initialized (The old check never worked). If Galera is enabled
we now change the binlog_format to ROW, with a warning, instead of
aborting the server. If this change happens a warning will be printed to
the error log.
- Print a warning if Galera or FLASHBACK changes the binlog_format
to ROW. Before it was done silently.
Reviewed by: Sergei Golubchik <serg@mariadb.com>,
Kristian Nielsen <knielsen@knielsen-hq.org>
191 lines
5.5 KiB
Text
191 lines
5.5 KiB
Text
call mtr.add_suppression('Attempting backtrace');
|
|
call mtr.add_suppression('MYSQL_BIN_LOG::purge_logs failed to process registered files that would be purged.');
|
|
call mtr.add_suppression('MYSQL_BIN_LOG::open failed to sync the index file');
|
|
call mtr.add_suppression('Turning logging off for the whole duration of the MariaDB server process.');
|
|
call mtr.add_suppression('Could not use .*');
|
|
call mtr.add_suppression('MYSQL_BIN_LOG::purge_logs failed to clean registers before purging logs.');
|
|
flush tables;
|
|
SET @saved_dbug = @@SESSION.debug_dbug;
|
|
RESET MASTER;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000001 #
|
|
master-bin.000002 #
|
|
master-bin.000003 #
|
|
master-bin.000004 #
|
|
flush tables;
|
|
purge binary logs TO 'master-bin.000004';
|
|
Warnings:
|
|
Warning 1612 Being purged log master-bin.000001 was not found
|
|
*** must show a list starting from the 'TO' argument of PURGE ***
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000004 #
|
|
reset master;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
*** must be a warning master-bin.000001 was not found ***
|
|
Warnings:
|
|
Note 1375 Binary log 'master-bin.000004' is not purged because it is the current active binlog
|
|
Warning 1612 Being purged log master-bin.000001 was not found
|
|
*** must show one record, of the active binlog, left in the index file after PURGE ***
|
|
show binary logs;
|
|
Log_name File_size
|
|
master-bin.000004 #
|
|
reset master;
|
|
flush logs;
|
|
flush logs;
|
|
flush logs;
|
|
purge binary logs TO 'master-bin.000002';
|
|
ERROR HY000: Fatal error during log purge
|
|
show warnings;
|
|
Level Code Message
|
|
Warning 1377 a problem with deleting master-bin.000001; consider examining correspondence of your binlog index file to the actual binlog files
|
|
Error 1377 Fatal error during log purge
|
|
reset master;
|
|
# crash_purge_before_update_index
|
|
flush logs;
|
|
SET SESSION debug_dbug="+d,crash_purge_before_update_index";
|
|
purge binary logs TO 'master-bin.000002';
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000001
|
|
master-bin.000002
|
|
master-bin.000003
|
|
|
|
# crash_purge_non_critical_after_update_index
|
|
flush logs;
|
|
SET SESSION debug_dbug="+d,crash_purge_non_critical_after_update_index";
|
|
purge binary logs TO 'master-bin.000004';
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000004
|
|
master-bin.000005
|
|
|
|
# crash_purge_critical_after_update_index
|
|
flush logs;
|
|
SET SESSION debug_dbug="+d,crash_purge_critical_after_update_index";
|
|
purge binary logs TO 'master-bin.000006';
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
|
|
# crash_create_non_critical_before_update_index
|
|
SET SESSION debug_dbug="+d,crash_create_non_critical_before_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
|
|
# crash_create_critical_before_update_index
|
|
SET SESSION debug_dbug="+d,crash_create_critical_before_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
|
|
# crash_create_after_update_index
|
|
SET SESSION debug_dbug="+d,crash_create_after_update_index";
|
|
flush logs;
|
|
ERROR HY000: Lost connection to server during query
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
#
|
|
# This should put the server in unsafe state and stop
|
|
# accepting any command. If we inject a fault at this
|
|
# point and continue the execution the server crashes.
|
|
#
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
# fault_injection_registering_index
|
|
SET SESSION debug_dbug="+d,fault_injection_registering_index";
|
|
flush logs;
|
|
ERROR HY000: Can't open file: 'master-bin.000012' (errno: 1 "Operation not permitted")
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
|
|
# restart
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
|
|
# fault_injection_updating_index
|
|
SET SESSION debug_dbug="+d,fault_injection_updating_index";
|
|
flush logs;
|
|
ERROR HY000: Can't open file: 'master-bin.000013' (errno: 1 "Operation not permitted")
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
|
|
# restart
|
|
SET @index=LOAD_FILE('MYSQLTEST_VARDIR/mysqld.1/data//master-bin.index');
|
|
SELECT @index;
|
|
@index
|
|
master-bin.000006
|
|
master-bin.000007
|
|
master-bin.000008
|
|
master-bin.000009
|
|
master-bin.000010
|
|
master-bin.000011
|
|
master-bin.000012
|
|
master-bin.000013
|
|
|
|
SET @@SESSION.debug_dbug = @saved_dbug;
|
|
End of tests
|