mirror of
https://github.com/MariaDB/server.git
synced 2025-10-31 10:56:12 +01:00
5a8e6230d7
normalize_cond() translated `WHERE col` into `WHERE col<>0`
But the opetator "not equal to 0" does not necessarily exists
for all data types.
For example, the query:
SELECT * FROM t1 WHERE inet6col;
was translated to:
SELECT * FROM t1 WHERE inet6col<>0;
which further failed with this error:
ERROR : Illegal parameter data types inet6 and bigint for operation '<>'
This patch changes the translation from `col<>0` to `col IS TRUE`.
So now
SELECT * FROM t1 WHERE inet6col;
gets translated to:
SELECT * FROM t1 WHERE inet6col IS TRUE;
Details:
1. Implementing methods:
- Field_longstr::val_bool()
- Field_string::val_bool()
- Item::val_int_from_val_str()
If the input contains bad data,
these methods raise a better error message:
Truncated incorrect BOOLEAN value
Before the change, the error was:
Truncated incorrect DOUBLE value
2. Fixing normalize_cond() to generate Item_func_istrue/Item_func_isfalse
instances instead of Item_func_ne/Item_func_eq
3. Making Item_func_truth sargable, so it uses the range optimizer.
Implementing the following methods:
- get_mm_tree(), get_mm_leaf(), add_key_fields() in Item_func_truth.
- get_func_mm_tree(), for all Item_func_truth descendants.
4. Implementing the method negated_item() for all Item_func_truth
descendants, so the negated item has a chance to be sargable:
For example,
WHERE NOT col IS NOT FALSE -- this notation is not sargable
is now translated to:
WHERE col IS FALSE -- this notation is sargable
39 lines
987 B
SQL
39 lines
987 B
SQL
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE a;
|
|
SELECT id, a FROM t1 WHERE a;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE NOT a;
|
|
SELECT id, a FROM t1 WHERE NOT a;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE a IS TRUE;
|
|
SELECT id, a FROM t1 WHERE a IS TRUE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE NOT a IS TRUE;
|
|
SELECT id, a FROM t1 WHERE NOT a IS TRUE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE a IS NOT TRUE;
|
|
SELECT id, a FROM t1 WHERE a IS NOT TRUE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE NOT a IS NOT TRUE;
|
|
SELECT id, a FROM t1 WHERE NOT a IS NOT TRUE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE a IS FALSE;
|
|
SELECT id, a FROM t1 WHERE a IS FALSE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE NOT a IS FALSE;
|
|
SELECT id, a FROM t1 WHERE NOT a IS FALSE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE a IS NOT FALSE;
|
|
SELECT id, a FROM t1 WHERE a IS NOT FALSE;
|
|
|
|
EXPLAIN EXTENDED
|
|
SELECT id, a FROM t1 WHERE NOT a IS NOT FALSE;
|
|
SELECT id, a FROM t1 WHERE NOT a IS NOT FALSE;
|