mirror of
https://github.com/MariaDB/server.git
synced 2025-11-03 20:36:16 +01:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
261 lines
7 KiB
Text
261 lines
7 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_debug_sync.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_partition.inc
|
|
|
|
set default_storage_engine=innodb;
|
|
set @old_dbug=@@global.debug_dbug;
|
|
# Ensure that the history list length will actually be decremented by purge.
|
|
SET @saved_stats_persistent = @@GLOBAL.innodb_stats_persistent;
|
|
SET GLOBAL innodb_stats_persistent = OFF;
|
|
|
|
CREATE TABLE `t` (
|
|
`a` BLOB,
|
|
`b` BLOB,
|
|
`c` BLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
|
`h` VARCHAR(10) DEFAULT NULL,
|
|
`i` int
|
|
) ENGINE=InnoDB;
|
|
|
|
INSERT INTO t VALUES (REPEAT('g', 16000), REPEAT('x', 16000), DEFAULT, "kk", 1);
|
|
INSERT INTO t VALUES (REPEAT('a', 16000), REPEAT('b', 16000), DEFAULT, "mm", 2);
|
|
|
|
CREATE INDEX idx ON t(c(100));
|
|
|
|
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
|
UPDATE t SET a = REPEAT('m', 16000) WHERE a like "aaa%";
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t;
|
|
|
|
CREATE TABLE t (
|
|
a TINYBLOB,
|
|
b TINYBLOB,
|
|
c TINYBLOB GENERATED ALWAYS AS (CONCAT(a,b)) VIRTUAL,
|
|
h VARCHAR(10) DEFAULT NULL,
|
|
i INT
|
|
) ROW_FORMAT=COMPACT ENGINE=InnoDB;
|
|
|
|
INSERT INTO t VALUES (REPEAT('g', 100), REPEAT('x', 100), DEFAULT, "kk", 1);
|
|
INSERT INTO t VALUES (REPEAT('a', 100), REPEAT('b', 100), DEFAULT, "mm", 2);
|
|
|
|
CREATE INDEX idx ON t(c(100));
|
|
|
|
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
|
UPDATE t SET a = REPEAT('m', 100) WHERE a like "aaa%";
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t;
|
|
|
|
|
|
CREATE TABLE t1 (
|
|
id INT NOT NULL,
|
|
store_id INT NOT NULL,
|
|
x INT GENERATED ALWAYS AS (id + store_id)
|
|
)
|
|
PARTITION BY RANGE (store_id) (
|
|
PARTITION p0 VALUES LESS THAN (6),
|
|
PARTITION p1 VALUES LESS THAN (11),
|
|
PARTITION p2 VALUES LESS THAN (16),
|
|
PARTITION p3 VALUES LESS THAN (21)
|
|
);
|
|
|
|
insert into t1 values(1, 2, default);
|
|
insert into t1 values(3, 4, default);
|
|
|
|
insert into t1 values(3, 12, default);
|
|
insert into t1 values(4, 18, default);
|
|
|
|
CREATE INDEX idx ON t1(x);
|
|
|
|
SET global debug_dbug="d,ib_purge_virtual_index_callback";
|
|
UPDATE t1 SET id = 10 WHERE id = 1;
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
SET global debug_dbug=@old_dbug;
|
|
DROP TABLE t1;
|
|
|
|
#
|
|
# BUG#22082762 RE-ENABLE SUPPORT FOR ADDING VIRTUAL INDEX WHILE DROPPING VIRTUAL COLUMN
|
|
#
|
|
connect (con1,localhost,root,,);
|
|
connection default;
|
|
|
|
# Test adding virtual index on newly added virtual column
|
|
CREATE TABLE t1 (a INT, b INT);
|
|
|
|
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3);
|
|
|
|
connection con1;
|
|
--echo # disable purge
|
|
CREATE TABLE t0 (a INT) ENGINE=InnoDB;
|
|
BEGIN; SELECT * FROM t0;
|
|
|
|
connection default;
|
|
DELETE FROM t1 WHERE a = 1;
|
|
|
|
UPDATE t1 SET a = 4, b = 4 WHERE a = 3;
|
|
|
|
INSERT INTO t1(a, b) VALUES (5, 5);
|
|
|
|
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
|
--error ER_ALTER_OPERATION_NOT_SUPPORTED_REASON
|
|
ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
send ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
|
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
|
|
|
--echo # enable purge
|
|
COMMIT;
|
|
|
|
--echo # wait for purge to process the deleted records.
|
|
let $wait_all_purged = 1;
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
let $wait_all_purged = 0;
|
|
|
|
SET DEBUG_SYNC= 'now SIGNAL purged';
|
|
|
|
connection default;
|
|
--echo /* connection default */ ALTER TABLE t1 ADD COLUMN c INT GENERATED ALWAYS AS(a+b), ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=SHARED;
|
|
--reap
|
|
SHOW CREATE TABLE t1;
|
|
|
|
SELECT * FROM t1;
|
|
|
|
DROP TABLE t1;
|
|
|
|
# Test adding index on existing virtual column
|
|
CREATE TABLE t1 (a INT, b INT, c INT GENERATED ALWAYS AS(a+b));
|
|
|
|
INSERT INTO t1(a, b) VALUES (1, 1), (2, 2), (3, 3), (4, 4);
|
|
|
|
connect (stop_purge,localhost,root,,);
|
|
START TRANSACTION WITH CONSISTENT SNAPSHOT;
|
|
|
|
connection default;
|
|
DELETE FROM t1 WHERE a = 1;
|
|
|
|
UPDATE t1 SET a = 2, b = 2 WHERE a = 5;
|
|
|
|
INSERT INTO t1(a, b) VALUES (6, 6);
|
|
|
|
SET DEBUG_SYNC= 'inplace_after_index_build SIGNAL uncommitted WAIT_FOR purged';
|
|
send ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
|
|
connection con1;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR uncommitted';
|
|
|
|
BEGIN;
|
|
DELETE FROM t1 WHERE a = 3;
|
|
|
|
UPDATE t1 SET a = 7, b = 7 WHERE a = 4;
|
|
|
|
INSERT INTO t1(a, b) VALUES (8, 8);
|
|
|
|
disconnect stop_purge;
|
|
COMMIT;
|
|
|
|
--echo # wait for purge to process the deleted/updated records.
|
|
let $wait_all_purged=2;
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
let $wait_all_purged=0;
|
|
|
|
SET DEBUG_SYNC= 'now SIGNAL purged';
|
|
|
|
disconnect con1;
|
|
|
|
connection default;
|
|
--echo /* connection default */ ALTER TABLE t1 ADD INDEX idx (c), ALGORITHM=INPLACE, LOCK=NONE;
|
|
--reap
|
|
SHOW CREATE TABLE t1;
|
|
|
|
SELECT * FROM t1;
|
|
|
|
DROP TABLE t0, t1;
|
|
|
|
#
|
|
# test MDLs with purge
|
|
#
|
|
create table t (a blob, b blob, c blob as (concat(a,b)), h varchar(10), index (c(100)));
|
|
insert t(a,b,h) values (repeat('g', 16000), repeat('x', 16000), "kk");
|
|
insert t(a,b,h) values (repeat('a', 16000), repeat('b', 16000), "mm");
|
|
set global debug_dbug="d,ib_purge_virtual_index_callback";
|
|
connect(prevent_purge, localhost, root);
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
update t set a = repeat('m', 16000) where a like "aaa%";
|
|
connect(lock_table, localhost, root);
|
|
lock table t write;
|
|
connection prevent_purge;
|
|
commit;
|
|
connection default;
|
|
disconnect lock_table;
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
set global debug_dbug=@old_dbug;
|
|
drop table t;
|
|
|
|
--echo #
|
|
--echo # MDEV-15165 InnoDB purge for index on virtual column
|
|
--echo # is trying to access an incomplete record
|
|
--echo #
|
|
CREATE TABLE t1(
|
|
u INT PRIMARY KEY, b BLOB, ug INT GENERATED ALWAYS AS (u) VIRTUAL,
|
|
INDEX bug(b(100),ug)
|
|
) ENGINE=InnoDB;
|
|
INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
|
connection prevent_purge;
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
DELETE FROM t1;
|
|
SET DEBUG_SYNC='blob_write_middle SIGNAL halfway WAIT_FOR purged';
|
|
send INSERT INTO t1 (u,b) VALUES(1,REPEAT('a',16384));
|
|
connection prevent_purge;
|
|
SET DEBUG_SYNC='now WAIT_FOR halfway';
|
|
COMMIT;
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
SET DEBUG_SYNC='now SIGNAL purged';
|
|
|
|
connection default;
|
|
reap;
|
|
DROP TABLE t1;
|
|
|
|
CREATE TABLE t1 (y YEAR, vy YEAR AS (y) VIRTUAL UNIQUE, pk INT PRIMARY KEY)
|
|
ENGINE=InnoDB;
|
|
|
|
INSERT INTO t1 (pk,y) VALUES (1,2022);
|
|
CREATE TABLE t2(f1 INT NOT NULL, PRIMARY KEY(f1))ENGINE=InnoDB;
|
|
|
|
SET GLOBAL debug_dbug = 'd,ib_purge_virtual_index_callback';
|
|
|
|
BEGIN;
|
|
INSERT INTO t2(f1) VALUES(1);
|
|
connection prevent_purge;
|
|
SET DEBUG_SYNC=RESET;
|
|
start transaction with consistent snapshot;
|
|
connection default;
|
|
COMMIT;
|
|
|
|
connect(truncate,localhost,root,,);
|
|
REPLACE INTO t1(pk, y) SELECT pk,y FROM t1;
|
|
send TRUNCATE TABLE t1;
|
|
|
|
connection prevent_purge;
|
|
COMMIT;
|
|
SET DEBUG_SYNC='now SIGNAL purge_start';
|
|
disconnect prevent_purge;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC='now WAIT_FOR purge_start';
|
|
--source ../../innodb/include/wait_all_purged.inc
|
|
SET GLOBAL debug_dbug=@old_dbug;
|
|
|
|
connection truncate;
|
|
reap;
|
|
disconnect truncate;
|
|
|
|
connection default;
|
|
DROP TABLE t1, t2;
|
|
|
|
set debug_sync=reset;
|
|
|
|
SET GLOBAL innodb_stats_persistent = @saved_stats_persistent;
|