mirror of
https://github.com/MariaDB/server.git
synced 2025-08-23 10:51:36 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
44 lines
1.4 KiB
Text
44 lines
1.4 KiB
Text
# This test requires that --log-output includes 'table', and the general
|
|
# log is on
|
|
|
|
# embedded server causes different stat
|
|
-- source include/not_embedded.inc
|
|
|
|
# Disable concurrent inserts to avoid sporadic test failures as it might
|
|
# affect the the value of variables used throughout the test case.
|
|
set @old_concurrent_insert= @@global.concurrent_insert;
|
|
set @@global.concurrent_insert= 0;
|
|
|
|
# Disable logging to table, since this will also cause table locking and unlocking, which will
|
|
# show up in SHOW STATUS and may cause sporadic failures
|
|
|
|
SET @old_log_output = @@global.log_output;
|
|
SET GLOBAL LOG_OUTPUT = 'FILE';
|
|
|
|
# PS causes different statistics
|
|
--disable_ps_protocol
|
|
|
|
flush status;
|
|
|
|
#
|
|
# Bug#17954 Threads_connected > Threads_created
|
|
#
|
|
|
|
--disable_warnings
|
|
DROP VIEW IF EXISTS v1;
|
|
--enable_warnings
|
|
|
|
CREATE VIEW v1 AS SELECT VARIABLE_NAME AS NAME, CONVERT(VARIABLE_VALUE, UNSIGNED) AS VALUE FROM INFORMATION_SCHEMA.GLOBAL_STATUS;
|
|
|
|
SELECT VALUE INTO @tc FROM v1 WHERE NAME = 'Threads_connected';
|
|
SELECT NAME FROM v1 WHERE NAME = 'Threads_created' AND VALUE < @tc;
|
|
#SELECT * FROM INFORMATION_SCHEMA.GLOBAL_STATUS where variable_name like '%thread%';
|
|
#SELECT * FROM INFORMATION_SCHEMA.GLOBAL_STATUS;
|
|
#SELECT * FROM INFORMATION_SCHEMA.GLOBAL_VARIABLES;
|
|
|
|
DROP VIEW v1;
|
|
|
|
# Restore global concurrent_insert value. Keep in the end of the test file.
|
|
--connection default
|
|
set @@global.concurrent_insert= @old_concurrent_insert;
|
|
SET GLOBAL log_output = @old_log_output;
|