mirror of
https://github.com/MariaDB/server.git
synced 2025-08-17 16:01:35 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
106 lines
2.6 KiB
Text
106 lines
2.6 KiB
Text
#
|
|
# Code coverage testing of TRUNCATE TABLE.
|
|
#
|
|
# Ingo Struewing, 2009-07-20
|
|
#
|
|
|
|
--source include/have_debug_sync.inc
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
--let $MYSQLD_DATADIR= `SELECT @@datadir`
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1;
|
|
--enable_warnings
|
|
|
|
--echo #
|
|
--echo # Bug#20667 - Truncate table fails for a write locked table
|
|
--echo #
|
|
########
|
|
# Attack acquire_exclusive_locks(). Hold a global read lock.
|
|
# Non-LOCK TABLE case.
|
|
#
|
|
CREATE TABLE t1 (c1 INT);
|
|
INSERT INTO t1 VALUES (1);
|
|
#
|
|
# Start a transaction and execute a DML in it. Since 5.4.4 this leaves
|
|
# a shared meta data lock (MDL) behind. TRUNCATE shall block on it.
|
|
#
|
|
--connect (con1, localhost, root,,)
|
|
START TRANSACTION;
|
|
INSERT INTO t1 VALUES (2);
|
|
#
|
|
# Get connection id of default connection.
|
|
# Start TRUNCATE, which will block on acquire_exclusive_locks().
|
|
#
|
|
--connection default
|
|
let $ID= `SELECT @id := CONNECTION_ID()`;
|
|
SET DEBUG_SYNC='mdl_acquire_lock_wait SIGNAL waiting';
|
|
send TRUNCATE TABLE t1;
|
|
#
|
|
# Get the default connection ID into a variable in an invisible statement.
|
|
# Kill the TRUNCATE query. This shall result in an error return
|
|
# from wait_while_table_is_used().
|
|
#
|
|
--connection con1
|
|
SET DEBUG_SYNC='now WAIT_FOR waiting';
|
|
let $invisible_assignment_in_select = `SELECT @id := $ID`;
|
|
KILL QUERY @id;
|
|
--connection default
|
|
--error ER_QUERY_INTERRUPTED
|
|
reap;
|
|
--connection con1
|
|
--echo # Release SW lock by committing transaction.
|
|
COMMIT;
|
|
--disconnect con1
|
|
--connection default
|
|
UNLOCK TABLES;
|
|
DROP TABLE t1;
|
|
SET DEBUG_SYNC='RESET';
|
|
|
|
--echo #
|
|
--echo # Bug#57659 Segfault in Query_cache::invalidate_data for TRUNCATE TABLE
|
|
--echo #
|
|
|
|
--echo # Note that this test case only reproduces the problem
|
|
--echo # when it is run with valgrind.
|
|
|
|
--disable_warnings
|
|
DROP TABLE IF EXISTS t1, m1;
|
|
--enable_warnings
|
|
|
|
CREATE TABLE t1(a INT) engine=memory;
|
|
CREATE TABLE m1(a INT) engine=merge UNION(t1);
|
|
connect(con2, localhost, root);
|
|
|
|
connect(con1, localhost, root);
|
|
SET DEBUG_SYNC= 'open_tables_after_open_and_process_table SIGNAL opened WAIT_FOR dropped';
|
|
--echo # Sending:
|
|
--send TRUNCATE TABLE m1
|
|
|
|
connection con2;
|
|
SET DEBUG_SYNC= 'now WAIT_FOR opened';
|
|
--echo # Sending:
|
|
--send FLUSH TABLES m1
|
|
|
|
connection default;
|
|
--echo # Waiting for FLUSH TABLES to be blocked.
|
|
let $wait_condition= SELECT COUNT(*)=1 FROM information_schema.processlist
|
|
WHERE state= 'Waiting for table metadata lock' AND info= 'FLUSH TABLES m1';
|
|
--source include/wait_condition.inc
|
|
SET DEBUG_SYNC= 'now SIGNAL dropped';
|
|
|
|
connection con1;
|
|
--echo # Reaping: TRUNCATE TABLE m1
|
|
--error ER_WRONG_MRG_TABLE
|
|
--reap
|
|
disconnect con1;
|
|
|
|
connection con2;
|
|
--echo # Reaping: FLUSH TABLES
|
|
--reap
|
|
disconnect con2;
|
|
|
|
connection default;
|
|
SET DEBUG_SYNC= 'RESET';
|
|
DROP TABLE m1, t1;
|