mirror of
https://github.com/MariaDB/server.git
synced 2025-08-18 00:11:34 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
71 lines
1.8 KiB
Text
71 lines
1.8 KiB
Text
# Can't be tested with embedded server
|
|
--source include/not_embedded.inc
|
|
|
|
# Bug#8471 IP address with mask fail when skip-name-resolve is on
|
|
CREATE USER mysqltest_1@'127.0.0.1/255.255.255.255';
|
|
GRANT ALL ON test.* TO mysqltest_1@'127.0.0.1/255.255.255.255';
|
|
SHOW GRANTS FOR mysqltest_1@'127.0.0.1/255.255.255.255';
|
|
REVOKE ALL ON test.* FROM mysqltest_1@'127.0.0.1/255.255.255.255';
|
|
DROP USER mysqltest_1@'127.0.0.1/255.255.255.255';
|
|
|
|
# End of 4.1 tests
|
|
|
|
# Bug#13407 Remote connecting crashes server
|
|
# Server crashed when one used USER() function in connection for which
|
|
# was impossible to obtain peer hostname.
|
|
connect (con1, localhost, root, , test, $MASTER_MYPORT, );
|
|
--replace_column 1 #
|
|
SELECT USER();
|
|
# We are only interested in the fact that statement below doesn't
|
|
# crash server.
|
|
--disable_result_log
|
|
SHOW PROCESSLIST;
|
|
--enable_result_log
|
|
connection default;
|
|
disconnect con1;
|
|
|
|
--echo #
|
|
--echo # Bug #37168: Missing variable - skip_name_resolve
|
|
--echo #
|
|
|
|
SHOW VARIABLES LIKE 'skip_name_resolve';
|
|
SHOW GLOBAL VARIABLES LIKE 'skip_name_resolve';
|
|
SHOW SESSION VARIABLES LIKE 'skip_name_resolve';
|
|
|
|
SELECT @@skip_name_resolve;
|
|
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
|
|
SELECT @@LOCAL.skip_name_resolve;
|
|
SELECT @@GLOBAL.skip_name_resolve;
|
|
|
|
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
|
|
SET @@skip_name_resolve=0;
|
|
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
|
|
SET @@LOCAL.skip_name_resolve=0;
|
|
--error ER_INCORRECT_GLOBAL_LOCAL_VAR
|
|
SET @@GLOBAL.skip_name_resolve=0;
|
|
|
|
--echo #
|
|
--echo # End of 5.1 tests
|
|
--echo #
|
|
|
|
--echo #
|
|
--echo # MDEV-26081 set role crashes when a hostname cannot be resolved
|
|
--echo #
|
|
|
|
create user u1@`%`;
|
|
create role r1;
|
|
create role r2;
|
|
grant r2 to r1;
|
|
grant r1 to u1@`%`;
|
|
|
|
connect u1,127.0.0.1,u1,,,$MASTER_MYPORT;
|
|
error ER_INVALID_ROLE;
|
|
set role r2;
|
|
disconnect u1;
|
|
connection default;
|
|
drop user u1@`%`;
|
|
drop role r1, r2;
|
|
|
|
--echo #
|
|
--echo # End of 10.2 tests
|
|
--echo #
|