mirror of
https://github.com/MariaDB/server.git
synced 2025-08-15 23:11:33 +02:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
156 lines
3.6 KiB
Text
156 lines
3.6 KiB
Text
#
|
|
# Just a couple of tests to make sure that schema works.
|
|
#
|
|
# Drop mysqltest1 database, as it can left from the previous tests.
|
|
#
|
|
|
|
--source include/default_charset.inc
|
|
|
|
create schema foo;
|
|
show create schema foo;
|
|
show schemas;
|
|
drop schema foo;
|
|
|
|
|
|
--echo #
|
|
--echo # Bug #48940 MDL deadlocks against mysql_rm_db
|
|
--echo #
|
|
|
|
connect(con2, localhost, root);
|
|
|
|
connection default;
|
|
|
|
CREATE SCHEMA schema1;
|
|
CREATE TABLE schema1.t1 (a INT);
|
|
|
|
START TRANSACTION;
|
|
INSERT INTO schema1.t1 VALUES (1);
|
|
|
|
connection con2;
|
|
--send DROP SCHEMA schema1
|
|
|
|
connection default;
|
|
let $wait_condition= SELECT COUNT(*)= 1 FROM information_schema.processlist
|
|
WHERE state= 'Waiting for table metadata lock'
|
|
AND info='DROP SCHEMA schema1';
|
|
--source include/wait_condition.inc
|
|
# Error 1 is from ALTER DATABASE when the database does not exist.
|
|
# Listing the error twice to prevent result diffences based on filename.
|
|
--error 1,1
|
|
ALTER SCHEMA schema1 DEFAULT CHARACTER SET utf8;
|
|
COMMIT;
|
|
|
|
connection con2;
|
|
--reap
|
|
|
|
connection default;
|
|
disconnect con2;
|
|
|
|
|
|
--echo #
|
|
--echo # Bug #49988 MDL deadlocks with mysql_create_db, reload_acl_and_cache
|
|
--echo #
|
|
|
|
connect (con2, localhost, root);
|
|
|
|
connection default;
|
|
CREATE SCHEMA schema1;
|
|
CREATE TABLE schema1.t1 (id INT);
|
|
LOCK TABLE schema1.t1 WRITE;
|
|
|
|
connection con2;
|
|
--send DROP SCHEMA schema1
|
|
|
|
connection default;
|
|
let $wait_condition=SELECT COUNT(*)=1 FROM information_schema.processlist
|
|
WHERE state='Waiting for schema metadata lock' and info='DROP SCHEMA schema1';
|
|
--source include/wait_condition.inc
|
|
|
|
--echo # CREATE SCHEMA used to give a deadlock.
|
|
--echo # Now we prohibit CREATE SCHEMA in LOCK TABLES mode.
|
|
--error ER_LOCK_OR_ACTIVE_TRANSACTION
|
|
CREATE SCHEMA IF NOT EXISTS schema1;
|
|
|
|
--echo # UNLOCK TABLES so DROP SCHEMA can continue.
|
|
UNLOCK TABLES;
|
|
|
|
connection con2;
|
|
--reap
|
|
|
|
connection default;
|
|
disconnect con2;
|
|
|
|
|
|
--echo #
|
|
--echo # Bug#54360 Deadlock DROP/ALTER/CREATE DATABASE with open HANDLER
|
|
--echo #
|
|
|
|
CREATE DATABASE db1;
|
|
CREATE TABLE db1.t1 (a INT);
|
|
INSERT INTO db1.t1 VALUES (1), (2);
|
|
|
|
connect (con1, localhost, root);
|
|
HANDLER db1.t1 OPEN;
|
|
|
|
connection default;
|
|
--echo # Sending:
|
|
--send DROP DATABASE db1
|
|
|
|
connect (con2, localhost, root);
|
|
let $wait_condition=SELECT COUNT(*)=1 FROM information_schema.processlist
|
|
WHERE state='Waiting for table metadata lock' AND info='DROP DATABASE db1';
|
|
--source include/wait_condition.inc
|
|
|
|
connection con1;
|
|
# All these statements before resulted in deadlock.
|
|
CREATE DATABASE db2;
|
|
ALTER DATABASE db2 DEFAULT CHARACTER SET utf8;
|
|
DROP DATABASE db2;
|
|
HANDLER t1 CLOSE;
|
|
|
|
connection default;
|
|
--echo # Reaping: DROP DATABASE db1
|
|
--reap
|
|
disconnect con1;
|
|
disconnect con2;
|
|
|
|
|
|
--echo #
|
|
--echo # Tests for increased CREATE/ALTER/DROP DATABASE concurrency with
|
|
--echo # database name locks.
|
|
--echo #
|
|
|
|
connect (con2, localhost, root);
|
|
connect (con3, localhost, root);
|
|
|
|
connection default;
|
|
CREATE DATABASE db1;
|
|
CREATE TABLE db1.t1 (id INT);
|
|
START TRANSACTION;
|
|
INSERT INTO db1.t1 VALUES (1);
|
|
|
|
connection con2;
|
|
--echo # DROP DATABASE should block due to the active transaction
|
|
--echo # Sending:
|
|
--send DROP DATABASE db1
|
|
|
|
connection con3;
|
|
let $wait_condition=SELECT COUNT(*)=1 FROM information_schema.processlist
|
|
WHERE state='Waiting for table metadata lock' and info='DROP DATABASE db1';
|
|
--source include/wait_condition.inc
|
|
--echo # But it should still be possible to CREATE/ALTER/DROP other databases.
|
|
CREATE DATABASE db2;
|
|
ALTER DATABASE db2 DEFAULT CHARACTER SET utf8;
|
|
DROP DATABASE db2;
|
|
|
|
connection default;
|
|
--echo # End the transaction so DROP DATABASE db1 can continue
|
|
COMMIT;
|
|
|
|
connection con2;
|
|
--echo # Reaping: DROP DATABASE db1
|
|
--reap
|
|
|
|
connection default;
|
|
disconnect con2;
|
|
disconnect con3;
|