mirror of
https://github.com/MariaDB/server.git
synced 2025-10-31 10:56:12 +01:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
53 lines
1.3 KiB
Text
53 lines
1.3 KiB
Text
--source include/have_innodb.inc
|
|
--source include/not_embedded.inc
|
|
--source include/have_metadata_lock_info.inc
|
|
|
|
--echo #
|
|
--echo # Test privileges for BACKUP STAGES
|
|
--echo #
|
|
--disable_service_connection
|
|
|
|
set sql_mode="";
|
|
|
|
GRANT RELOAD ON *.* TO user1@localhost;
|
|
GRANT CREATE, DROP ON *.* TO user2@localhost;
|
|
|
|
--connect(con1, localhost, user1)
|
|
BACKUP STAGE START;
|
|
BACKUP STAGE END;
|
|
--echo # change_user must release backup lock
|
|
BACKUP STAGE START;
|
|
BACKUP STAGE FLUSH;
|
|
SELECT lock_mode FROM information_schema.metadata_lock_info WHERE lock_type='Backup lock';
|
|
change_user user2;
|
|
SELECT lock_mode FROM information_schema.metadata_lock_info WHERE lock_type='Backup lock';
|
|
--disconnect con1
|
|
--connection default
|
|
|
|
--echo # A very low privileged user (-> con4) cannot acquire the backup lock
|
|
|
|
--connect(con1, localhost, user2)
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
BACKUP STAGE START;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
BACKUP STAGE FLUSH;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
BACKUP STAGE BLOCK_DDL;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
BACKUP STAGE BLOCK_COMMIT;
|
|
--error ER_SPECIFIC_ACCESS_DENIED_ERROR
|
|
BACKUP STAGE END;
|
|
--disconnect con1
|
|
|
|
--connection default
|
|
DROP USER user1@localhost, user2@localhost;
|
|
|
|
--echo #
|
|
--echo # Test using BACKUP STAGES in a SP
|
|
--echo #
|
|
|
|
--error ER_SP_BADSTATEMENT
|
|
create procedure foo42()
|
|
BACKUP STAGE START;
|
|
|
|
--enable_service_connection
|