mirror of
https://github.com/MariaDB/server.git
synced 2025-10-27 08:58:13 +01:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc |
||
|---|---|---|
| .. | ||
| 0.test | ||
| 1.test | ||
| alter_spatial_index.test | ||
| bug16236208.test | ||
| bug16266012.test | ||
| bug17057168.test | ||
| check_rtree.test | ||
| create_spatial_index.test | ||
| geometry.test | ||
| gis.test | ||
| gis_split_inf.test | ||
| gis_split_nan.test | ||
| innodb_gis_rtree.test | ||
| kill_server.test | ||
| multi_pk.test | ||
| point_basic.test | ||
| point_big.test | ||
| precise.test | ||
| repeatable_spatial.test | ||
| rollback.test | ||
| rt_precise.test | ||
| rtree.test | ||
| rtree_add_index.test | ||
| rtree_compress.test | ||
| rtree_compress2.test | ||
| rtree_concurrent_srch.test | ||
| rtree_create_inplace.opt | ||
| rtree_create_inplace.test | ||
| rtree_debug.test | ||
| rtree_drop_index.test | ||
| rtree_estimate.test | ||
| rtree_multi_pk.test | ||
| rtree_optimize.test | ||
| rtree_purge.test | ||
| rtree_recovery.test | ||
| rtree_rollback1.test | ||
| rtree_rollback2.test | ||
| rtree_search.test | ||
| rtree_split.test | ||
| rtree_temporary.test | ||
| rtree_undo.test | ||
| types.test | ||
| update_root.test | ||