mirror of
				https://github.com/MariaDB/server.git
				synced 2025-10-30 18:36:12 +01:00 
			
		
		
		
	 bead24b7f3
			
		
	
	
	bead24b7f3
	
	
	
		
			
			Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
		
			
				
	
	
		
			26 lines
		
	
	
	
		
			867 B
		
	
	
	
		
			Text
		
	
	
	
	
	
			
		
		
	
	
			26 lines
		
	
	
	
		
			867 B
		
	
	
	
		
			Text
		
	
	
	
	
	
| # Test of ipv6 format
 | |
| # Options: --skip-name-resolve, --bind-address=:: (see corresponding opt file).
 | |
| #
 | |
| --source include/check_ipv6.inc
 | |
| # Can't be tested with embedded server
 | |
| --source include/not_embedded.inc
 | |
| 
 | |
| echo =============Test of '::1' ========================================;
 | |
| let $IPv6= ::1;
 | |
| --source include/ipv6_clients.inc
 | |
| --source include/ipv6.inc
 | |
| 
 | |
| echo =============Test of '::1/128' ====================================;
 | |
| let $IPv6= ::1/128;
 | |
| #--source include/ipv6_clients.inc
 | |
| #--source include/ipv6.inc
 | |
| 
 | |
| echo =============Test of '0000:0000:0000:0000:0000:0000:0000:0001' ====;
 | |
| let $IPv6= 0000:0000:0000:0000:0000:0000:0000:0001;
 | |
| --source include/ipv6_clients.inc
 | |
| --source include/ipv6.inc
 | |
| 
 | |
| echo =============Test of '0:0:0:0:0:0:0:1' ============================;
 | |
| let $IPv6= 0:0:0:0:0:0:0:1;
 | |
| --source include/ipv6_clients.inc
 | |
| --source include/ipv6.inc
 |