mirror of
https://github.com/MariaDB/server.git
synced 2025-10-26 16:38:11 +01:00
bead24b7f3
Remove one of the major sources of race condiitons in mariadb-test. Normally, mariadb_close() sends COM_QUIT to the server and immediately disconnects. In mariadb-test it means the test can switch to another connection and sends queries to the server before the server even started parsing the COM_QUIT packet and these queries can see the connection as fully active, as it didn't reach dispatch_command yet. This is a major source of instability in tests and many - but not all, still less than a half - tests employ workarounds. The correct one is a pair count_sessions.inc/wait_until_count_sessions.inc. Also very popular was wait_until_disconnected.inc, which was completely useless, because it verifies that the connection is closed, and after disconnect it always is, it didn't verify whether the server processed COM_QUIT. Sadly the placebo was as widely used as the real thing. Let's fix this by making mariadb-test `disconnect` command _to wait_ for the server to confirm. This makes almost all workarounds redundant. In some cases count_sessions.inc/wait_until_count_sessions.inc is still needed, though, as only `disconnect` command is changed: * after external tools, like `exec $MYSQL` * after failed `connect` command * replication, after `STOP SLAVE` * Federated/CONNECT/SPIDER/etc after `DROP TABLE` and also in some XA tests, because an XA transaction is dissociated from the THD very late, after the server has closed the client connection. Collateral cleanups: fix comments, remove some redundant statements: * DROP IF EXISTS if nothing is known to exist * DROP table/view before DROP DATABASE * REVOKE privileges before DROP USER etc
55 lines
1.3 KiB
Text
55 lines
1.3 KiB
Text
# Grant tests not performed with embedded server
|
|
-- source include/not_embedded.inc
|
|
|
|
--source include/have_debug.inc
|
|
##TEST for invisible coloumn level 3
|
|
set @old_debug= @@debug_dbug;
|
|
create user user_1;
|
|
show grants for user_1;
|
|
--echo # create user
|
|
create database d;
|
|
use d;
|
|
|
|
--echo
|
|
--echo #Completely Invisible
|
|
set debug_dbug= "+d,test_completely_invisible";
|
|
create table t1(a int);
|
|
insert into t1 values(1);
|
|
select a,invisible from t1;
|
|
set debug_dbug=@old_debug;
|
|
grant insert(a) on t1 to user_1;
|
|
grant update(a) on t1 to user_1;
|
|
grant select(a) on t1 to user_1;
|
|
grant delete on t1 to user_1;
|
|
connect (con1, localhost, user_1,,d);
|
|
connection con1;
|
|
select user();
|
|
select * from t1;
|
|
insert into t1 values(2);
|
|
select * from t1;
|
|
insert into t1(a) values(3);
|
|
select * from t1;
|
|
--error ER_BAD_FIELD_ERROR
|
|
select invisible,a from t1;
|
|
delete from t1 where a =1;
|
|
update t1 set a=1 where a=3;
|
|
select * from t1;
|
|
|
|
connection default;
|
|
REVOKE ALL PRIVILEGES, GRANT OPTION FROM user_1;
|
|
|
|
connection con1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
select * from t1;
|
|
--error ER_TABLEACCESS_DENIED_ERROR
|
|
select invisible from t1;
|
|
|
|
disconnect con1;
|
|
--echo
|
|
--echo #Final Cleanup
|
|
connection default;
|
|
set debug_dbug= "+d,test_completely_invisible";
|
|
select a,invisible from t1;
|
|
drop user user_1;
|
|
drop database d;
|
|
set @old_debug= @@debug_dbug;
|