mirror of
https://github.com/MariaDB/server.git
synced 2025-08-26 04:11:36 +02:00
c5d8b9963a
The patch for SYS_REFCURSOR (MDEV-20034) overrode these methods:
- Item_func_case_searched::check_arguments()
- Item_func_if::check_arguments()
to validate WHEN-style arguments (e.g. args[0] in case of IF) for being
able to return a boolean result.
However, this unintentionally removed the test for the THEN-style arguments
that they are not expressions of the ROW data type.
This led to a crash inside Type_handler_hybrid_field_type::aggregate_for_result
on a DBUG_ASSERT that arguments are not of the ROW data type.
Fix:
The fix restores blocking ROW expressions in the not supported cases,
to avoid the DBUG_ASSERT and to raise an SQL error instead.
Blocking ROW_RESULT expressions is done per Item_func_case_expression
descendant individually, instead of blocking any ROW_RESULT arguments
at the Item_func_case_expression level.
The fix is done taking into account the upcoming patch for associative arrays
(MDEV-34319). It should be possible to pass associative array expressions into
some hybrid type functions, where ROW type expressions are not possible.
As a side effect, some lecagy ER_OPERAND_COLUMNS changed to
a newer ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION
Changes in the top affected class Item_func_case_expression:
- item_func.h:
Overriding Item_func_case_expression::check_arguments() to return false,
without checking any arguments. Descendant validate arguments
in a various different ways. No needs to block all non-scalar data type at
this level, to prevent disallowing associative arrays.
Changes in descendants:
- item_cmpfunc.cc:
Adding a test in Item_func_case_simple::aggregate_switch_and_when_arguments()
preventing passing ROW_RESULT expression in predicant and WHEN in a
simple CASE:
CASE predicant WHEN when1 THEN .. WHEN when2 THEN .. END;
This is not supported yet. Should be preferrably fixed before MDEV-34319.
- item_cmpfunc.cc:
Calling args[0]->type_handler()->Item_hybrid_func_fix_attributes()
from Item_func_nullif::fix_length_and_dec().
This prevents a ROW expression to be passed to args[0] of NULLIF().
But will allow to pass associative arrays.
args[1] is still only checked to be comparable with args[0].
No needs to add additional tests for it.
- item_cmpfunc.h:
Adding a call for Item_hybrid_func_fix_attributes() in
Item_func_case_abbreviation2::cache_type_info().
This prevents calling the descendant functions with
a ROW expression in combination with an explicit NULL
in the THEN-style arguments (but will allow to pass associative arrays):
IFNULL(row_expression, NULL)
IFNULL(NULL, row_expression)
IF(switch, row_expression, NULL)
IF(switch, NULL, row_expression)
NVL2(switch, row_expression, NULL)
NVL2(switch, NULL, row_expression)
Adding a THD* argument into involved methods.
- item_cmpfunc.h:
Overriding Item_func_case_abbreviation2_switch::check_arguments() to
check that the first argument in IF() and NVL2() can return bool.
Removing Item_func_if::check_arguments(), as it become redundant.
- sql_type.cc:
Fixing sql_type.cc not to disallow items[0] with ROW_RESULT.
This makes it call Item_hybrid_func_fix_attributes() at the end,
which block ROW arguments into THEN-style arguments of hybrid functions.
But this will allow to pass Type_handler_assoc_array expressions.
- sql_type.cc:
Changing Type_handler_row::Item_hybrid_func_fix_attributes to raise the
ER_ILLEGAL_PARAMETER_DATA_TYPE_FOR_OPERATION error instead of the DBUG_ASSERT.
|
||
|---|---|---|
| .. | ||
| anonymous_derived.result | ||
| binlog_ptr_mysqlbinlog.result | ||
| binlog_stm_ps.result | ||
| binlog_stm_sp.result | ||
| binlog_stm_sp_package.result | ||
| column_compression.result | ||
| custom_aggregate_functions.result | ||
| empty_string_literal.result | ||
| events.result | ||
| exception.result | ||
| func_add_months.result | ||
| func_case.result | ||
| func_concat.result | ||
| func_decode.result | ||
| func_length.result | ||
| func_misc.result | ||
| func_pad.result | ||
| func_qualified.result | ||
| func_regexp_replace.result | ||
| func_replace.result | ||
| func_substr.result | ||
| func_time.result | ||
| func_to_char.result | ||
| func_trim.result | ||
| gis-debug.result | ||
| gis.result | ||
| information_schema_parameters.result | ||
| keywords.result | ||
| lower_case_table_names.result | ||
| minus.result | ||
| misc.result | ||
| mysqldump_restore.result | ||
| mysqldump_restore_func_qualified.result | ||
| parser.result | ||
| plugin.result | ||
| ps.result | ||
| rpl_mariadb_date.result | ||
| rpl_sp_package.result | ||
| rpl_sp_package_variables.result | ||
| sequence.result | ||
| sp-anchor-row-type-table.result | ||
| sp-anchor-type.result | ||
| sp-anonymous.result | ||
| sp-code.result | ||
| sp-cursor-decl.result | ||
| sp-cursor-rowtype.result | ||
| sp-cursor.result | ||
| sp-default-param.result | ||
| sp-expr.result | ||
| sp-goto-debug.result | ||
| sp-goto.result | ||
| sp-inout.result | ||
| sp-memory-leak.result | ||
| sp-package-code.result | ||
| sp-package-concurrent-dml-db.result | ||
| sp-package-concurrent-dml-package.result | ||
| sp-package-concurrent-dml-trigger.result | ||
| sp-package-concurrent-dml-view.result | ||
| sp-package-i_s.result | ||
| sp-package-innodb.result | ||
| sp-package-mdl.result | ||
| sp-package-mysqldump.result | ||
| sp-package-security.result | ||
| sp-package.result | ||
| sp-param.result | ||
| sp-record.result | ||
| sp-row.result | ||
| sp-security.result | ||
| sp-sys_refcursor-alias.result | ||
| sp-sys_refcursor-func_hybrid.result | ||
| sp-sys_refcursor.result | ||
| sp.result | ||
| statement-expr.result | ||
| table_value_constr.result | ||
| trigger.result | ||
| truncate.result | ||
| type_blob.result | ||
| type_clob.result | ||
| type_date.result | ||
| type_number.result | ||
| type_raw.result | ||
| type_varchar.result | ||
| type_varchar2.result | ||
| update.result | ||
| update_innodb.result | ||
| variables.result | ||
| vcol.result | ||
| vcol_innodb.result | ||
| versioning.result | ||
| win.result | ||