mirror of
https://github.com/MariaDB/server.git
synced 2026-01-14 23:44:49 +01:00
4de3d55db3
Allow limited ALTER TABLE on explicit system columns ROW START/ROW
END. That includes two CHANGE COLUMN (or MODIFY COLUMN) operations:
1. change INVISIBLE property;
2. rename system field.*
That required a number of reworks. Vers_parse_info::fix_alter_info()
now better detects errors. It takes into account whether system
versioning is implicit (system hidden row_start/row_end) or
explicit, and case of explicit it allows the above two operations.
For changing invisible property it was required to add it into
Alter_column and take from there in mysql_prepare_alter_table().
Also the number of semantics are made more clear:
- ALTER_VERS_IMPLICIT/ALTER_VERS_EXPLICIT flags represent
corresponding operations for implicit<->explicit switch;
- ALTER_VERS_CHANGE is (ALTER_ADD_SYSTEM_VERSIONING |
ALTER_VERS_EXPLICIT | ALTER_VERS_IMPLICIT), so it is whether we
add system versioning or switch implicit<->explicit. It is used to
determine whether parser data check is required (check_parser_data()).
- check_parser_data() is new better name for check_conditions(), it
better reflects what it does.
- There is clear distinction between parser data and processed
data. Now we do not change as_row property, but add new sys_fields
property instead. We do not change period property as well, so it
is clear if PERIOD was specified in command or not at any
stage. Same with as_row, as it is now sole representation of AS
ROW clauses.
- The main point of updating sys_fields is check_sys_fields(), but
it is not the only point as check_sys_fields() not always needed.
When creating FRM we take processed data from sys_fields, i.e. the
data passed validation stage of check_parser_data()/check_sys_fields().
* Note that before the patch RENAME COLUMN worked but CHANGE COLUMN
alternative syntax produced ER_VERS_DUPLICATE_ROW_START_END.
|
||
|---|---|---|
| .. | ||
| collections | ||
| include | ||
| lib | ||
| main | ||
| std_data | ||
| suite | ||
| asan.supp | ||
| CMakeLists.txt | ||
| dgcov.pl | ||
| lsan.supp | ||
| mariadb-stress-test.pl | ||
| mariadb-test-run.pl | ||
| mtr.out-of-source | ||
| purify.supp | ||
| README | ||
| README-gcov | ||
| README.stress | ||
| suite.pm | ||
| valgrind.supp | ||
This directory contains test suites for the MariaDB server. To run currently existing test cases, execute ./mysql-test-run in this directory. Some tests are known to fail on some platforms or be otherwise unreliable. In the file collections/smoke_test there is a list of tests that are expected to be stable. In general you do not have to do "make install", and you can have a co-existing MariaDB installation, the tests will not conflict with it. To run the tests in a source directory, you must do "make" first. In Red Hat distributions, you should run the script as user "mysql". The user is created with nologin shell, so the best bet is something like # su - # cd /usr/share/mariadb-test # su -s /bin/bash mysql -c ./mysql-test-run This will use the installed MariaDB executables, but will run a private copy of the server process (using data files within /usr/share/mariadb-test), so you need not start the mysqld service beforehand. You can omit --skip-test-list option if you want to check whether the listed failures occur for you. To clean up afterwards, remove the created "var" subdirectory, e.g. # su -s /bin/bash - mysql -c "rm -rf /usr/share/mariadb-test/var" If tests fail on your system, please read the following manual section for instructions on how to report the problem: https://mariadb.com/kb/en/reporting-bugs If you want to use an already running MySQL server for specific tests, use the --extern option to mysql-test-run. Please note that in this mode, you are expected to provide names of the tests to run. For example, here is the command to run the "alias" and "analyze" tests with an external server: # mariadb-test-run --extern socket=/tmp/mysql.sock alias analyze To match your setup, you might need to provide other relevant options. With no test names on the command line, mysql-test-run will attempt to execute the default set of tests, which will certainly fail, because many tests cannot run with an external server (they need to control the options with which the server is started, restart the server during execution, etc.) You can create your own test cases. To create a test case, create a new file in the main subdirectory using a text editor. The file should have a .test extension. For example: # xemacs t/test_case_name.test In the file, put a set of SQL statements that create some tables, load test data, and run some queries to manipulate it. Your test should begin by dropping the tables you are going to create and end by dropping them again. This ensures that you can run the test over and over again. If you are using mysqltest commands in your test case, you should create the result file as follows: # mariadb-test-run --record test_case_name or # mariadb-test --record < t/test_case_name.test If you only have a simple test case consisting of SQL statements and comments, you can create the result file in one of the following ways: # mariadb-test-run --record test_case_name # mariadb test < t/test_case_name.test > r/test_case_name.result # mariadb-test --record --database test --result-file=r/test_case_name.result < t/test_case_name.test When this is done, take a look at r/test_case_name.result. If the result is incorrect, you have found a bug. In this case, you should edit the test result to the correct results so that we can verify that the bug is corrected in future releases. If you want to submit your test case you can send it to developers@lists.mariadb.org or attach it to a bug report on http://mariadb.org/jira/. If the test case is really big or if it contains 'not public' data, then put your .test file and .result file(s) into a tar.gz archive, add a README that explains the problem, ftp the archive to ftp://ftp.mariadb.org/private and submit a report to https://mariadb.org/jira about it. The latest information about mysql-test-run can be found at: https://mariadb.com/kb/en/mariadb/mysqltest/ If you want to create .rdiff files, check https://mariadb.com/kb/en/mariadb/mysql-test-auxiliary-files/