mariadb/storage/rocksdb
Sergei Golubchik 1a85ae444a MDEV-36050 DATA/INDEX DIRECTORY handling is inconsistent
consistently issue a

Note 1618 DATA DIRECTORY option ignored
Note 1618 INDEX DIRECTORY option ignored

in archive/csv/innodb/rocksdb whenever an option is ignored.

Note that csv doesn't say "INDEX DIRECTORY option ignored"
because it does not create index files at all anywhere.

Other engines don't say "INDEX DIRECTORY option ignored"
if the table has no indexes.

additionally InnoDB doesn't say that if INDEX DIRECTORY is
the same as DATA DIRECTORY, because in that case indexes are
technically stored in INDEX DIRECTORY.

collateral fix: use strmake to zero-terminate the string
2025-04-18 09:41:23 +02:00
..
mysql-test MDEV-36050 DATA/INDEX DIRECTORY handling is inconsistent 2025-04-18 09:41:23 +02:00
rocksdb@bba5e7bc21 Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
tools Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
unittest
.clang-format
.gitignore
atomic_stat.h
build_rocksdb.cmake Merge branch '10.6' into 10.11 2024-05-10 20:02:18 +02:00
CMakeLists.txt Merge 10.11 into 11.4 2024-12-02 11:35:34 +02:00
event_listener.cc
event_listener.h
get_rocksdb_files.sh Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
ha_rocksdb.cc MDEV-36050 DATA/INDEX DIRECTORY handling is inconsistent 2025-04-18 09:41:23 +02:00
ha_rocksdb.h Tag the sql/log.h family with ATTRIBUTE_FORMAT 2025-02-12 10:17:44 +01:00
ha_rocksdb_proto.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
logger.h
mariadb-ldb.1 Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
myrocks_hotbackup.1 Merge 10.11 into 11.0 2023-07-26 15:13:06 +03:00
myrocks_hotbackup.py
nosql_access.cc Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
nosql_access.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
properties_collector.cc
properties_collector.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_buff.h
rdb_cf_manager.cc cleanup: remove unconditional #ifdef's 2024-11-05 14:00:47 -08:00
rdb_cf_manager.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_cf_options.cc cleanup: remove unconditional #ifdef's 2024-11-05 14:00:47 -08:00
rdb_cf_options.h
rdb_compact_filter.h cleanup: remove unconditional #ifdef's 2024-11-05 14:00:47 -08:00
rdb_comparator.h
rdb_converter.cc Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_converter.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_datadic.cc cleanup: unused function argument 2024-11-05 14:00:48 -08:00
rdb_datadic.h Merge 10.6 into 10.11 2024-06-27 10:26:09 +03:00
rdb_global.h Provide a safe range for RocksDB errors 2024-11-26 19:21:12 +01:00
rdb_i_s.cc Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_i_s.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_index_merge.cc MDEV-9101 Limit size of created disk temporary files and tables 2024-05-27 12:39:04 +02:00
rdb_index_merge.h
rdb_io_watchdog.cc
rdb_io_watchdog.h
rdb_mariadb_port.h
rdb_mariadb_server_port.cc
rdb_mariadb_server_port.h
rdb_mutex_wrapper.cc
rdb_mutex_wrapper.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_perf_context.cc
rdb_perf_context.h
rdb_psi.cc cleanup: remove unconditional #ifdef's 2024-11-05 14:00:47 -08:00
rdb_psi.h Revert "MDEV-30610 Update RocksDB to v8.1.1" 2023-09-30 14:12:55 +02:00
rdb_source_revision.h.in
rdb_sst_info.cc MDEV-26221: DYNAMIC_ARRAY use size_t for sizes 2021-10-19 16:00:26 +03:00
rdb_sst_info.h
rdb_threads.cc cleanup: remove unconditional #ifdef's 2024-11-05 14:00:47 -08:00
rdb_threads.h MDEV-33746 Supply missing override markings 2024-06-20 11:32:13 -04:00
rdb_utils.cc This commit is a fixup for MDEV-22189. 2021-07-26 22:59:10 +05:30
rdb_utils.h
README
rocksdb-range-access.txt
ut0counter.h Merge branch '10.5' into 10.6 2023-05-03 09:51:25 +02:00

== Summary ==
This directory contains RocksDB-based Storage Engine (RDBSE) for MySQL,
also known as "MyRocks".

== Resources ==
https://github.com/facebook/mysql-5.6/wiki/Getting-Started-with-MyRocks
https://www.facebook.com/groups/MyRocks/

== Coding Conventions ==
The baseline for MyRocks coding conventions for the code in storage/rocksdb/
is based on the default clang format with a few minor changes.  The file
storage/rocksdb/.clang-format describes conventions and can be integrated
with Vim or Emacs as described here:
http://releases.llvm.org/3.6.0/tools/clang/docs/ClangFormat.html#vim-integration

All code outside of storage/rocksdb/ should conform to the MySQL coding
conventions:
http://dev.mysql.com/doc/internals/en/coding-guidelines.html.

Several refinements:
  0. There is an umbrella C++ namespace named "myrocks" for all MyRocks code.
  1. We introduced "RDB" as the super-short abbreviation for "RocksDB". We will
     use it as a name prefix, with different capitalization (see below), to ease
     up code navigation with ctags and grep.
     N.B. For ease of matching, we'll keep the variables and functions dealing
          with sysvars as close as possible to the outside visible names of
          sysvars, which start with "rocksdb_" prefix, the outward storage
          engine name.
  2. The names for classes, interfaces, and C++ structures (which act as
     classes), start with prefix "Rdb_".
     NB: For historical reasons, we'll keep the "ha_<storage_engine_name>" class
         name for ha_rocksdb class, which is an exception to the rule.
  3. The names for global objects and functions start with prefix "rdb_".
  4. The names for macros and constants start with prefix "RDB_".
  5. Regular class member names start with "m_".
  6. Static class member names start with "s_".
  7. Given the 80 character per line limit, we'll not always use full English
     words in names, when a well known or easily recognizable abbreviation
     exists (like "tx" for "transaction" or "param" for "parameter" etc).
  8. When needing to disambiguate, we use different suffixes for that, like
     "_arg" for a function argument/parameter, "_arr" for a C style array, and
     "_vect" for a std::vector etc.

== Running Tests ==
To run tests from rocksdb, rocksdb_rpl or other rocksdb_* packages, use the
following parameters:
  --default-storage-engine=rocksdb
  --skip-innodb
  --default-tmp-storage-engine=MyISAM
  --rocksdb