mirror of
https://github.com/MariaDB/server.git
synced 2025-09-12 20:32:20 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
118 lines
3.7 KiB
Text
118 lines
3.7 KiB
Text
#
|
|
# Start Alter with Parallel Replication, With 2 sources
|
|
# 2 domain id (From 2 sources)
|
|
# |Concurrent alters| >= |Parallel workers on slave|
|
|
# |x| denotes number of entities it encloses
|
|
#
|
|
--source include/have_log_bin.inc
|
|
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--connect (server_1,127.0.0.1,root,,,$SERVER_MYPORT_1)
|
|
--connect (server_2,127.0.0.1,root,,,$SERVER_MYPORT_2)
|
|
--connect (server_3,127.0.0.1,root,,,$SERVER_MYPORT_3)
|
|
|
|
--connection server_1
|
|
--let $binlog_alter_two_phase= `select @@binlog_alter_two_phase`
|
|
set global binlog_alter_two_phase = ON;
|
|
set binlog_alter_two_phase = ON;
|
|
|
|
--connection server_2
|
|
stop slave;
|
|
set global binlog_alter_two_phase=true;
|
|
|
|
--connection server_3
|
|
SET STATEMENT sql_log_bin=0 FOR
|
|
CALL mtr.add_suppression("The table mysql.gtid_slave_pos was removed. This change will not take full effect until all SQL threads have been restarted");
|
|
SET STATEMENT sql_log_bin=0 FOR
|
|
ALTER TABLE mysql.gtid_slave_pos ENGINE=InnoDB;
|
|
--let $gtid_strict_mode= `select @@gtid_strict_mode`
|
|
--let $slave_parallel_threads= `select @@slave_parallel_threads`
|
|
--let $slave_parallel_mode= `select @@slave_parallel_mode`
|
|
SET GLOBAL slave_parallel_threads=8;
|
|
set global slave_parallel_mode=optimistic;
|
|
set global gtid_strict_mode=1;
|
|
|
|
|
|
--disable_warnings
|
|
--disable_query_log
|
|
--replace_result $SERVER_MYPORT_1 MYPORT_1
|
|
eval change master 'm1' to master_port=$SERVER_MYPORT_1 , master_host='127.0.0.1', master_user='root', master_ssl_verify_server_cert=0, master_use_gtid=slave_pos;
|
|
--replace_result $SERVER_MYPORT_2 MYPORT_2
|
|
eval change master 'm2' to master_port=$SERVER_MYPORT_2 , master_host='127.0.0.1', master_user='root', master_ssl_verify_server_cert=0, master_use_gtid=slave_pos;
|
|
--enable_query_log
|
|
--enable_warnings
|
|
|
|
--connection server_1
|
|
set gtid_domain_id= 11;
|
|
create database s1;
|
|
use s1;
|
|
--let $domain_1=11
|
|
--let $domain_2=11
|
|
--let $M_port= $SERVER_MYPORT_1
|
|
--let $S_port= $SERVER_MYPORT_3
|
|
--let $sync_slave=0
|
|
--let $db_name=s1
|
|
--source include/start_alter_include.inc
|
|
--connection server_1
|
|
drop database s1;
|
|
select @@gtid_binlog_pos;
|
|
--let $master_pos_1= `SELECT @@gtid_binlog_pos`
|
|
|
|
--connection server_2
|
|
set gtid_domain_id= 12;
|
|
create database s2;
|
|
use s2;
|
|
--let $domain_1=12
|
|
--let $domain_2=12
|
|
--let $M_port= $SERVER_MYPORT_2
|
|
--let $S_port= $SERVER_MYPORT_3
|
|
--let $sync_slave=0
|
|
--let $db_name=s2
|
|
--source include/start_alter_include.inc
|
|
--connection server_2
|
|
drop database s2;
|
|
select @@gtid_binlog_pos;
|
|
--let $master_pos_2= `SELECT @@gtid_binlog_pos`
|
|
|
|
--connection server_3
|
|
start all slaves;
|
|
set default_master_connection = 'm1';
|
|
--source include/wait_for_slave_to_start.inc
|
|
set default_master_connection = 'm2';
|
|
--source include/wait_for_slave_to_start.inc
|
|
|
|
set default_master_connection = 'm1';
|
|
--let $master_pos= $master_pos_1
|
|
--source include/sync_with_master_gtid.inc
|
|
set default_master_connection = 'm2';
|
|
--let $master_pos= $master_pos_2
|
|
--source include/sync_with_master_gtid.inc
|
|
|
|
--echo # cleanup
|
|
--connection server_3
|
|
set default_master_connection = 'm1';
|
|
--source include/stop_slave.inc
|
|
set default_master_connection = 'm2';
|
|
--source include/stop_slave.inc
|
|
--eval set global slave_parallel_threads = $slave_parallel_threads;
|
|
--eval set global slave_parallel_mode = $slave_parallel_mode;
|
|
--eval set global gtid_strict_mode = $gtid_strict_mode;
|
|
set global gtid_domain_id= 0;
|
|
reset master;
|
|
RESET SLAVE ALL;
|
|
SET GLOBAL gtid_slave_pos= '';
|
|
|
|
--connection server_1
|
|
--eval set global binlog_alter_two_phase=$binlog_alter_two_phase;
|
|
set global gtid_domain_id= 0;
|
|
--source include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
--connection server_2
|
|
set global gtid_domain_id= 0;
|
|
--eval set global binlog_alter_two_phase=$binlog_alter_two_phase
|
|
--source include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
|
|
--disconnect server_1
|
|
--disconnect server_2
|
|
--disconnect server_3
|