mariadb/mysql-test/suite/rpl/t/rpl_server_id2.test
Kristian Nielsen 0a68328673 MDEV-34705: Binlog-in-engine: Protect against concurrent RESET MASTER and dump threads
This is actually an existing problem in the old binlog implementation, and
this patch is applicable to old binlog also. The problem is that RESET
MASTER can run concurrently with binlog dump threads / connected slaves.
This will remove the binlog from under the feet of the reader, which can
cause all sorts of strange behaviour.

This patch fixes the problem by disallowing to run RESET MASTER when dump
threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is
thrown in this case, user must stop slaves and/or kill dump threads to make
the RESET MASTER go through. A slave that connects in the middle of RESET
MASTER will wait for it to complete.

Fix a lot of test cases to kill any lingering dump threads before doing
RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc.

Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
2025-06-11 11:32:10 +02:00

73 lines
2 KiB
Text

# This test checks that a slave DOES execute queries originating
# from itself, if running with --replicate-same-server-id.
source include/master-slave.inc;
connection slave;
--source include/stop_slave.inc
CHANGE MASTER TO MASTER_USE_GTID=NO;
--source include/start_slave.inc
create table t1 (n int);
reset master;
# replicate ourselves
stop slave;
--source include/wait_for_slave_to_stop.inc
--replace_result $SLAVE_MYPORT SLAVE_PORT
eval change master to master_port=$SLAVE_MYPORT;
start slave;
--source include/wait_for_slave_to_start.inc
insert into t1 values (1);
save_master_pos;
sync_with_master;
select * from t1; # check that indeed 2 were inserted
# We stop the slave before cleaning up otherwise we'll get
# 'drop table t1' executed twice, so an error in the slave.err
# (not critical).
stop slave;
--source include/wait_for_slave_to_stop.inc
drop table t1;
#
# Bug#38934 slave slave until does not work with --replicate-same-server-id
#
# Verifying that slave performs all events until the master_log_pos
# in presense of --replicate-same-server-id the slave is started with.
connection master;
--source include/kill_binlog_dump_threads.inc
reset master;
# setting the until position to correspond to the last position of
# create table which will make the event executed and the slave sql
# thread stopped right after that.
create table t1(n int);
let $until_pos= query_get_value(SHOW MASTER STATUS, Position, 1);
dec $until_pos;
create table t2(n int);
connection slave;
--replace_result $MASTER_MYPORT MASTER_PORT
eval change master to master_port=$MASTER_MYPORT;
--replace_result $until_pos UNTIL_POS
eval start slave until master_log_file='master-bin.000001', master_log_pos=$until_pos;
--source include/wait_for_slave_io_to_start.inc
--source include/wait_for_slave_sql_to_stop.inc
--echo *** checking until position execution: must be only t1 in the list ***
show tables;
# cleanup
connection slave;
start slave sql_thread;
connection master;
drop table t1;
drop table t2;
sync_slave_with_master;
# End of tests
--source include/rpl_end.inc