mirror of
https://github.com/MariaDB/server.git
synced 2025-09-13 12:52:18 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
52 lines
1.2 KiB
Text
52 lines
1.2 KiB
Text
########################################################
|
|
# By JBM 2005-02-15 Wrapped to allow reuse of test code#
|
|
########################################################
|
|
-- source include/have_binlog_format_row.inc
|
|
-- source include/master-slave.inc
|
|
|
|
# Test if the slave SQL thread can be more than 16K behind the slave
|
|
# I/O thread (> IO_SIZE)
|
|
|
|
# we'll use table-level locking to delay slave SQL thread
|
|
eval CREATE TABLE t1 (n INT);
|
|
sync_slave_with_master;
|
|
--source include/stop_slave.inc
|
|
connection master;
|
|
--source include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
connection slave;
|
|
--source include/reset_slave.inc
|
|
|
|
connection master;
|
|
let $1=5000;
|
|
# Generate 16K of relay log
|
|
disable_query_log;
|
|
while ($1)
|
|
{
|
|
eval INSERT INTO t1 VALUES($1);
|
|
dec $1;
|
|
}
|
|
enable_query_log;
|
|
SELECT COUNT(*) FROM t1;
|
|
save_master_pos;
|
|
|
|
# Try to cause a large relay log lag on the slave by locking t1
|
|
connection slave;
|
|
LOCK TABLES t1 READ;
|
|
START SLAVE;
|
|
UNLOCK TABLES;
|
|
sync_with_master;
|
|
SELECT COUNT(*) FROM t1;
|
|
|
|
connection master;
|
|
DROP TABLE t1;
|
|
CREATE TABLE t1 (n INT);
|
|
INSERT INTO t1 VALUES(3456);
|
|
sync_slave_with_master;
|
|
SELECT n FROM t1;
|
|
|
|
connection master;
|
|
DROP TABLE t1;
|
|
|
|
sync_slave_with_master;
|
|
--source include/rpl_end.inc
|