mirror of
https://github.com/MariaDB/server.git
synced 2025-09-11 03:50:17 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
172 lines
5.2 KiB
Text
172 lines
5.2 KiB
Text
source include/have_debug.inc;
|
|
source include/have_innodb.inc;
|
|
-- source include/have_binlog_format_statement.inc
|
|
source include/master-slave.inc;
|
|
# MDEV-17614 INSERT on dup key update is replication unsafe
|
|
#
|
|
# The following cases are tested below:
|
|
# 1. 2 unique key, replication is UNSAFE
|
|
# 2. 2 unique key, with one auto increment key and implicit value to it.
|
|
# It is UNSAFE because autoinc column values of being inserted records
|
|
# are revealed dynamically, so unknown at the binlog-format decision time
|
|
# and hence this pessimistic expectation
|
|
# 3. 2 unique keys
|
|
# A. insert is only in 1 unique key, still all colums are specified => UNSAFE
|
|
# B. both unique keys are specified => UNSAFE
|
|
# C. only one unique key is specified => SAFE (motivated by MDEV-28310)
|
|
# 4. 2 unique key, with one auto increment key(but user gives auto inc value) =>
|
|
# UNSAFE to replicate
|
|
|
|
--echo # Case 1: UNSAFE
|
|
call mtr.add_suppression("Unsafe statement written to the binary log using statement format");
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY , b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(2, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--connection slave
|
|
# show the error message
|
|
--let $slave_sql_errno= 1062
|
|
--let $show_slave_sql_error= 1
|
|
--source include/wait_for_slave_sql_error.inc
|
|
--echo #Different value from server
|
|
SELECT * FROM t1;
|
|
|
|
# restart replication for the next testcase
|
|
--source include/stop_slave_io.inc
|
|
--source include/reset_slave.inc
|
|
connection master;
|
|
--source include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
drop table t1;
|
|
connection slave;
|
|
start slave;
|
|
--source include/wait_for_slave_to_start.inc
|
|
|
|
--echo # Case 2: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY auto_increment, b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (default, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (default, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(default, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 3A: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, NULL, 2, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(3, NULL, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 3B: UNSAFE - all column specified.
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, NULL, 2, 2) ON DUPLICATE KEY UPDATE c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(3, NULL, 2, 3) ON DUPLICATE KEY UPDATE c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
|
|
--echo # Case 3C: SAFE - only one unique key (PK) specified.
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY, b INT,
|
|
UNIQUE(b), c int, d int ) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 (`a`, `c`, `d`) VALUES (2, 2, 2) ON DUPLICATE KEY UPDATE c=99;
|
|
--connection master1
|
|
INSERT INTO t1 (`a`, `c`, `d`) VALUES(3, 2, 3) ON DUPLICATE KEY UPDATE c=100;
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--sync_slave_with_master
|
|
--echo #same data as master
|
|
SELECT * FROM t1;
|
|
connection master;
|
|
drop table t1;
|
|
--sync_slave_with_master
|
|
|
|
--echo # Case 4: UNSAFE
|
|
--connection master
|
|
CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY auto_increment, b INT,
|
|
UNIQUE(b), c int) engine=innodb;
|
|
sync_slave_with_master;
|
|
connection master;
|
|
INSERT INTO t1 VALUES (1, 1, 1);
|
|
BEGIN;
|
|
INSERT INTO t1 VALUES (2, 1, 2) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master1
|
|
INSERT INTO t1 VALUES(2, 2, 3) ON DUPLICATE KEY UPDATE b=VALUES(b), c=VALUES(c);
|
|
--connection master
|
|
COMMIT;
|
|
SELECT * FROM t1;
|
|
--connection slave
|
|
# show the error message
|
|
--let $slave_sql_errno= 1062
|
|
--let $show_slave_sql_error= 1
|
|
--source include/wait_for_slave_sql_error.inc
|
|
--echo #Different value from server
|
|
SELECT * FROM t1;
|
|
|
|
# restart replication for the next testcase
|
|
--source include/stop_slave_io.inc
|
|
--source include/reset_slave.inc
|
|
connection master;
|
|
--source include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
drop table t1;
|
|
connection slave;
|
|
start slave;
|
|
--source include/wait_for_slave_to_start.inc
|
|
|
|
--source include/rpl_end.inc
|