mirror of
https://github.com/MariaDB/server.git
synced 2025-10-26 08:28:13 +01:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
57 lines
1.8 KiB
Text
57 lines
1.8 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
"Command: STOP SLAVE --> STOP REPLICA"
|
|
connection slave;
|
|
STOP REPLICA;
|
|
include/wait_for_slave_io_to_stop.inc
|
|
include/wait_for_slave_sql_to_stop.inc
|
|
connection master;
|
|
CREATE USER 'repl_user';
|
|
"Privilege: SLAVE --> REPLICA"
|
|
GRANT REPLICATION REPLICA on *.* TO repl_user;
|
|
FLUSH PRIVILEGES;
|
|
connection slave;
|
|
"SHOW SLAVE STATUS --> SHOW REPLICA STATUS"
|
|
CHANGE MASTER TO MASTER_USER= 'repl_user';
|
|
"Command: START SLAVE --> START REPLICA"
|
|
START REPLICA;
|
|
include/wait_for_slave_io_to_start.inc
|
|
include/wait_for_slave_sql_to_start.inc
|
|
connection master;
|
|
connection slave;
|
|
connection master;
|
|
"Command: SHOW SLAVE HOSTS --> SHOW REPLICA HOSTS"
|
|
DROP USER 'repl_user';
|
|
connection slave;
|
|
"Command: SHOW SLAVE IO/SQL THREAD --> SHOW REPLICA IO/SQL THREAD"
|
|
STOP REPLICA IO_THREAD;
|
|
STOP REPLICA SQL_THREAD;
|
|
include/wait_for_slave_io_to_stop.inc
|
|
include/wait_for_slave_sql_to_stop.inc
|
|
"Command: RESET SLAVE ALL --> RESET REPLICA ALL"
|
|
RESET REPLICA ALL;
|
|
set @@global.gtid_slave_pos= "";
|
|
connection master;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
CREATE TABLE t(f INT) ENGINE=INNODB;
|
|
INSERT INTO t VALUES (10);
|
|
DROP TABLE t;
|
|
connection slave;
|
|
CHANGE MASTER TO MASTER_HOST='127.0.0.1',MASTER_PORT=MASTER_PORT,MASTER_USER='root';
|
|
"Command: START SLAVE UNTIL --> START REPLICA UNTIL"
|
|
START REPLICA UNTIL MASTER_LOG_FILE='MASTER_LOG_FILE', MASTER_LOG_POS=MASTER_POS;
|
|
include/wait_for_slave_sql_to_stop.inc
|
|
include/stop_slave_io.inc
|
|
SELECT * FROM t;
|
|
f
|
|
10
|
|
include/check_slave_param.inc [Exec_Master_Log_Pos]
|
|
"MASTER_USE_GTID=SLAVE_POS --> MASTER_USE_GTID=REPLICA_POS"
|
|
CHANGE MASTER TO master_host = '127.0.0.1', master_port = MASTER_PORT, MASTER_USE_GTID=REPLICA_POS;
|
|
include/start_slave.inc
|
|
connection master;
|
|
CREATE TABLE t2 (f INT PRIMARY KEY) ENGINE=INNODB;
|
|
INSERT INTO t2 VALUES (10);
|
|
DROP TABLE t2;
|
|
include/rpl_end.inc
|