mirror of
https://github.com/MariaDB/server.git
synced 2025-10-21 15:24:04 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
75 lines
3.2 KiB
Text
75 lines
3.2 KiB
Text
include/master-slave.inc
|
|
[connection master]
|
|
connection slave;
|
|
include/stop_slave.inc
|
|
connection master;
|
|
include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
connection slave;
|
|
set @restore_slave_net_timeout= @@global.slave_net_timeout;
|
|
set @@global.slave_net_timeout= 10;
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root';
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 5.000
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 4294968;
|
|
ERROR HY000: The requested value for the heartbeat period is either negative or exceeds the maximum allowed (4294967 seconds)
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 5.000
|
|
connection slave;
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 0.0009999;
|
|
Warnings:
|
|
Warning 1703 The requested value for the heartbeat period is less than 1 millisecond. The value is reset to 0, meaning that heartbeating will effectively be disabled
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 0.000
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 4294967;
|
|
Warnings:
|
|
Warning 1704 The requested value for the heartbeat period exceeds the value of `slave_net_timeout' seconds. A sensible value for the period should be less than the timeout
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 4294967.000
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 0.001;
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 0.001
|
|
reset slave;
|
|
set @@global.slave_net_timeout= 5;
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 5.001;
|
|
Warnings:
|
|
Warning 1704 The requested value for the heartbeat period exceeds the value of `slave_net_timeout' seconds. A sensible value for the period should be less than the timeout
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 5.001
|
|
reset slave;
|
|
set @@global.slave_net_timeout= 5;
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_heartbeat_period= 4;
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 4.000
|
|
set @@global.slave_net_timeout= 3 /* must be a warning */;
|
|
reset slave;
|
|
connection master;
|
|
drop table if exists t1;
|
|
connection slave;
|
|
set @@global.slave_net_timeout= 10;
|
|
change master to master_host='127.0.0.1',master_port=MASTER_PORT, master_user='root', master_ssl_verify_server_cert=0, master_heartbeat_period= 0.5;
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 0.500
|
|
start slave;
|
|
connection master;
|
|
create table t1 (f1 int);
|
|
connection slave;
|
|
include/check_slave_param.inc [Relay_Log_File]
|
|
show status like 'Slave_heartbeat_period';;
|
|
Variable_name Slave_heartbeat_period
|
|
Value 0.500
|
|
A heartbeat has been received by the slave
|
|
connection master;
|
|
drop table t1;
|
|
connection slave;
|
|
set @@global.slave_net_timeout= @restore_slave_net_timeout;
|
|
include/rpl_end.inc
|
|
End of tests
|