mirror of
https://github.com/MariaDB/server.git
synced 2025-09-21 16:45:30 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
124 lines
4 KiB
Text
124 lines
4 KiB
Text
connection node_2;
|
|
connection node_1;
|
|
connect node_6, 127.0.0.1, root, , test, $NODE_MYPORT_6;
|
|
connect node_5, 127.0.0.1, root, , test, $NODE_MYPORT_5;
|
|
connect node_4, 127.0.0.1, root, , test, $NODE_MYPORT_4;
|
|
connection node_4;
|
|
START SLAVE;
|
|
include/wait_for_slave_to_start.inc
|
|
connection node_1;
|
|
CREATE TABLE t1(c1 INTEGER NOT NULL AUTO_INCREMENT PRIMARY KEY, c2 INTEGER);
|
|
INSERT INTO t1(c2) VALUES(1);
|
|
connect node_3, 127.0.0.1, root, , test, $NODE_MYPORT_3;
|
|
connection node_3;
|
|
SELECT COUNT(*) = 1 FROM t1;
|
|
COUNT(*) = 1
|
|
1
|
|
connection node_1;
|
|
include/save_master_gtid.inc
|
|
connection node_4;
|
|
include/sync_with_master_gtid.inc
|
|
SELECT COUNT(*) = 1 FROM t1;
|
|
COUNT(*) = 1
|
|
1
|
|
connection node_6;
|
|
SELECT COUNT(*) = 1 FROM t1;
|
|
COUNT(*) = 1
|
|
1
|
|
connection node_2;
|
|
ALTER TABLE t1 ADD COLUMN t3 INTEGER;
|
|
Node 2 column number AFTER ALTER
|
|
SELECT COUNT(*) = 3 FROM information_schema.columns WHERE table_name ='t1';
|
|
COUNT(*) = 3
|
|
1
|
|
connection node_3;
|
|
Node 3 column number AFTER ALTER
|
|
SELECT COUNT(*) = 3 FROM information_schema.columns WHERE table_name ='t1';
|
|
COUNT(*) = 3
|
|
1
|
|
connection node_1;
|
|
include/save_master_gtid.inc
|
|
connection node_4;
|
|
include/sync_with_master_gtid.inc
|
|
Node 4 column number AFTER ALTER
|
|
SELECT COUNT(*) = 3 FROM information_schema.columns WHERE table_name ='t1';
|
|
COUNT(*) = 3
|
|
1
|
|
connection node_6;
|
|
Node 6 column number AFTER ALTER
|
|
SELECT COUNT(*) = 3 FROM information_schema.columns WHERE table_name ='t1';
|
|
COUNT(*) = 3
|
|
1
|
|
connection node_2;
|
|
connection node_1;
|
|
connection node_3;
|
|
connection node_4;
|
|
connection node_5;
|
|
connection node_6;
|
|
connection node_2;
|
|
OPTIMIZE TABLE t1;
|
|
Table Op Msg_type Msg_text
|
|
test.t1 optimize note Table does not support optimize, doing recreate + analyze instead
|
|
test.t1 optimize status OK
|
|
Warnings:
|
|
Note 1592 Unsafe statement written to the binary log using statement format since BINLOG_FORMAT = STATEMENT. Statement is unsafe because it uses a system variable that may have a different value on the slave
|
|
connection node_1;
|
|
connection node_3;
|
|
connection node_4;
|
|
connection node_5;
|
|
connection node_6;
|
|
connection node_1;
|
|
DROP TABLE t1;
|
|
connection node_4;
|
|
STOP SLAVE;
|
|
RESET SLAVE;
|
|
Warnings:
|
|
Note 4190 RESET SLAVE is implicitly changing the value of 'Using_Gtid' from 'Current_Pos' to 'Slave_Pos'
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
SET GLOBAL GTID_SLAVE_POS="";
|
|
connection node_1;
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
connection node_2;
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
connection node_3;
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
connection node_5;
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
connection node_6;
|
|
SET GLOBAL wsrep_on = OFF;
|
|
include/kill_binlog_dump_threads.inc
|
|
RESET MASTER;
|
|
SET GLOBAL wsrep_on = ON;
|
|
connection node_1;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|
|
connection node_2;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|
|
connection node_3;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|
|
connection node_4;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|
|
connection node_5;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|
|
connection node_6;
|
|
CALL mtr.add_suppression("Ignoring server id .* for non bootstrap node");
|
|
CALL mtr.add_suppression("Unsafe statement written to the binary log using statement format since ");
|