mirror of
https://github.com/MariaDB/server.git
synced 2025-09-19 23:55:29 +02:00
0a68328673
This is actually an existing problem in the old binlog implementation, and this patch is applicable to old binlog also. The problem is that RESET MASTER can run concurrently with binlog dump threads / connected slaves. This will remove the binlog from under the feet of the reader, which can cause all sorts of strange behaviour. This patch fixes the problem by disallowing to run RESET MASTER when dump threads (or other RESET MASTER or SHOW BINARY LOGS) are running. An error is thrown in this case, user must stop slaves and/or kill dump threads to make the RESET MASTER go through. A slave that connects in the middle of RESET MASTER will wait for it to complete. Fix a lot of test cases to kill any lingering dump threads before doing RESET MASTER, mostly just by sourcing include/kill_binlog_dump_threads.inc. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>
42 lines
1,004 B
Text
42 lines
1,004 B
Text
include/master-slave.inc
|
|
[connection master]
|
|
connection slave;
|
|
include/stop_slave.inc
|
|
CHANGE MASTER TO MASTER_USE_GTID=NO;
|
|
include/start_slave.inc
|
|
create table t1 (n int);
|
|
reset master;
|
|
stop slave;
|
|
include/wait_for_slave_to_stop.inc
|
|
change master to master_port=SLAVE_PORT;
|
|
start slave;
|
|
include/wait_for_slave_to_start.inc
|
|
insert into t1 values (1);
|
|
select * from t1;
|
|
n
|
|
1
|
|
1
|
|
stop slave;
|
|
include/wait_for_slave_to_stop.inc
|
|
drop table t1;
|
|
connection master;
|
|
include/kill_binlog_dump_threads.inc
|
|
reset master;
|
|
create table t1(n int);
|
|
create table t2(n int);
|
|
connection slave;
|
|
change master to master_port=MASTER_PORT;
|
|
start slave until master_log_file='master-bin.000001', master_log_pos=UNTIL_POS;
|
|
include/wait_for_slave_io_to_start.inc
|
|
include/wait_for_slave_sql_to_stop.inc
|
|
*** checking until position execution: must be only t1 in the list ***
|
|
show tables;
|
|
Tables_in_test
|
|
t1
|
|
connection slave;
|
|
start slave sql_thread;
|
|
connection master;
|
|
drop table t1;
|
|
drop table t2;
|
|
connection slave;
|
|
include/rpl_end.inc
|