mirror of
https://github.com/MariaDB/server.git
synced 2026-02-25 12:08:41 +01:00
5b05829739
Problem: ======== When an inplace ALTER operation is rolled back, InnoDB drops intermediate tables and their associated FTS internal tables. However, MariaBackup's DDL tracking can incorrectly report this as a backup failure. The issue occurs because backup_set_alter_copy_lock() downgrades the MDL_BACKUP_DDL lock before the inplace phase of ALTER, allowing FTS internal tables to be dropped during the later phases of backup when DDL tracking is still active. Solution: ======== backup_file_op_fail(): Ignore delete operations on FTS internal tables when not using --no-lock option, preventing false positive backup failures.
90 lines
3.1 KiB
Text
90 lines
3.1 KiB
Text
--source include/have_innodb.inc
|
|
--source include/have_debug.inc
|
|
--source include/have_debug_sync.inc
|
|
|
|
# The test demonstrates that intermediate tables (ALTER TABLE...ALGORITHM=COPY)
|
|
# are not always properly locked, e.g., can be dropped after
|
|
# BACKUP STAGE BLOCK_COMMIT
|
|
# succeeded.
|
|
# Thus mariabackup decides not to have them in backup at all,
|
|
# since they keep changing even after the backup LSN was determined.
|
|
|
|
echo # xtrabackup backup;
|
|
let $targetdir=$MYSQLTEST_VARDIR/tmp/backup;
|
|
|
|
CREATE TABLE t1(i int) ENGINE=InnoDB;
|
|
INSERT into t1 values(1);
|
|
|
|
connect con2, localhost, root,,;
|
|
connection con2;
|
|
set lock_wait_timeout=1;
|
|
SET debug_sync='copy_data_between_tables_before_reset_backup_lock SIGNAL go WAIT_FOR after_backup_stage_block_commit';
|
|
SET debug_sync='alter_table_after_temp_table_drop SIGNAL temp_table_dropped';
|
|
DELIMITER |;
|
|
send SET debug_sync='now WAIT_FOR after_backup_stage_start';ALTER TABLE test.t1 FORCE, algorithm=COPY;|
|
|
DELIMITER ;|
|
|
connection default;
|
|
|
|
# setup mariabackup events
|
|
let after_backup_stage_start=SET debug_sync='now SIGNAL after_backup_stage_start WAIT_FOR go';
|
|
let after_backup_stage_block_commit=SET debug_sync='now SIGNAL after_backup_stage_block_commit';
|
|
let backup_fix_ddl=SET debug_sync='now WAIT_FOR temp_table_dropped';
|
|
--disable_result_log
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir --dbug=+d,mariabackup_events;
|
|
--enable_result_log
|
|
|
|
connection con2;
|
|
--error ER_LOCK_WAIT_TIMEOUT
|
|
reap;
|
|
SET debug_sync='RESET';
|
|
disconnect con2;
|
|
|
|
connection default;
|
|
echo # xtrabackup prepare;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --prepare --target-dir=$targetdir;
|
|
-- source include/restart_and_restore.inc
|
|
--enable_result_log
|
|
|
|
SELECT * FROM t1;
|
|
DROP TABLE t1;
|
|
rmdir $targetdir;
|
|
|
|
--echo #
|
|
--echo # MDEV-38041 MariaBackup fails during rollback of
|
|
--echo # inplace FTS alter table
|
|
--echo #
|
|
|
|
let $targetdir=$MYSQLTEST_VARDIR/tmp/backup;
|
|
|
|
CREATE TABLE t1(f1 int, f2 char(100), fulltext(f2)) ENGINE=InnoDB;
|
|
INSERT into t1 values(1, "MariaDB"), (1, "MySQL");
|
|
|
|
connect con2, localhost, root,,;
|
|
set lock_wait_timeout=1;
|
|
SET debug_sync='copy_data_between_tables_before_reset_backup_lock SIGNAL go WAIT_FOR after_backup_stage_block_commit';
|
|
SET debug_sync='alter_table_after_temp_table_drop SIGNAL temp_table_dropped';
|
|
DELIMITER |;
|
|
send SET debug_sync='now WAIT_FOR after_backup_stage_start';ALTER TABLE test.t1 ADD PRIMARY KEY(f1), algorithm=COPY;|
|
|
DELIMITER ;|
|
|
connection default;
|
|
|
|
# setup mariabackup events
|
|
let backup_fix_ddl=;
|
|
let after_backup_stage_start=SET debug_sync='now SIGNAL after_backup_stage_start WAIT_FOR go';
|
|
let after_backup_stage_block_commit=SET debug_sync='now SIGNAL after_backup_stage_block_commit';
|
|
let after_backup_fix_ddl=SET debug_sync='now WAIT_FOR temp_table_dropped';
|
|
let $backup_log=$MYSQLTEST_VARDIR/tmp/backup.log;
|
|
--disable_result_log
|
|
exec $XTRABACKUP --defaults-file=$MYSQLTEST_VARDIR/my.cnf --backup --target-dir=$targetdir --dbug=+d,mariabackup_events > $backup_log 2>&1;
|
|
--enable_result_log
|
|
|
|
connection con2;
|
|
--error ER_DUP_ENTRY
|
|
reap;
|
|
SET debug_sync='RESET';
|
|
disconnect con2;
|
|
|
|
connection default;
|
|
DROP TABLE t1;
|
|
rmdir $targetdir;
|